Logged in as guest
Viewing Archive.Contrib/1646 Full headers
Major security issue: yes no
Notes: committed by lukeh Notification:
Date: Sat, 16 Mar 2002 05:09:37 GMT From: kpierre@fit.edu To: openldap-its@OpenLDAP.org Subject: back-perl on win32 - p1
Full_Name: Kervin Pierre Version: CVS HEAD 14MAR02 OS: windows 2000 URL: http://prdownloads.sourceforge.net/acctsync/bp1.patch.tar.gz Submission from: (NULL) (163.118.1.20) This is a patch to get back-perl on Win32. To test, you'll need to... 1. Install activestate perl from http://www.activestate.com/Products/ActivePerl/ 2. Add $INSTALLDIR/perl/lib/CORE in MSVC++ include and lib paths 3. Add '#define HAVE_WIN32_ASPERL 1' in ldap/include/portable.nt 4. Add back-perl project to the build and as a dependency of slapd I am hoping, with help testing and constructive critisms, to have the port completed by at least early next week. As usual, any insight/information/testing will be appreciated. will also make patches available at http://sourceforge.net/projects/acctsync
Date: Thu, 21 Mar 2002 17:39:00 -0500 From: Kervin Pierre <kpierre@fit.edu> To: openldap-its@OpenLDAP.org Subject: Re: back-perl on win32 - p2 (ITS#1646)
Hi, I just updated the patch to back-perl to have it compile on win32. It's at http://prdownloads.sourceforge.net/acctsync/back-perl.win32.21MAR02CVS.patch.gz It's a patch against today's CVS. It now compiles against activestate perl 5.6.1 This patch only affects ldap/servers/slapd/back-perl . To build back-perl, you'd have to edit ldap/include/portable.nt and add the backperl project to your workspace. If possible, can I get feedback on this patch soon? I have to move on to the next stage of this project urgently and I like to address any issues before then. That is, of course, if at all possible. I am available to make any modifications immediately. thanks, --Kervin -- http://linuxquestions.org/ - Ask linux questions, give linux help. http://splint.org/ - Write safe C code. splint source-code analyzer.
Date: Thu, 21 Mar 2002 23:15:03 -0500 From: Kervin Pierre <kpierre@fit.edu> To: openldap-its@OpenLDAP.org Subject: Re: back-perl on win32 - p3 (ITS#1646)
Hi, tested the patch on redhat linux 7.2 with the perl that comes with it ( version 5.6.0 ) I included the macro HAVE_PERL56 to wrap the changes ( there were only 2 changes ). That macro will have to be detected and defined by the configure script eventually. the patch is at http://prdownloads.sourceforge.net/acctsync/back-perl.win32.21MAR02CVS-b.patch.gz --Kervin openldap-its@OpenLDAP.org wrote: > *** THIS IS AN AUTOMATICALLY GENERATED REPLY *** > > Thanks for your report to openldap-its@OpenLDAP.org. Your report > has been placed into our Issue Tracking System and has been assigned > the tracking number ITS#1646. > > One of support engineers will look at your report in due course. > Note that this may take some time because our support engineers > are volunteers. They only work on OpenLDAP when they have spare > time. > If you need to provide additional information in regards to your > issue report, you may do so by replying to this message. Note that > any mail sent to openldap-its@openldap.org with (ITS#1646) > in the subject will automatically be attached to the issue report. > > mailto:openldap-its@openldap.org?subject=(ITS#1646) > > You may follow the progress of this message by loading the following > URL in a web browser: > http://www.OpenLDAP.org/its/index.cgi?findid=1646 > > Please remember to retain your issue tracking number (ITS#1646) > on any further messages you send to us regarding this message. If > you don't then you'll just waste our time and yours because we > won't be able to properly track the message. > > In our experience many people ask questions that have been asked > before. We recommend that you review our online FAQ: > http://www.OpenLDAP.org/faq/ > > and search archives of our many mailing lists (such as openldap-software > and openldap-bugs): > http://www.OpenLDAP.org/lists/#archives > > -------------- > Copyright 2002 The OpenLDAP Foundation, All Rights Reserved. > > -- http://linuxquestions.org/ - Ask linux questions, give linux help. http://splint.org/ - Write safe C code. splint source-code analyzer.
Date: Fri, 22 Mar 2002 03:47:53 -0500 From: Kervin Pierre <kpierre@fit.edu> To: openldap-its@OpenLDAP.org Subject: Re: back-perl on win32 - p4 (ITS#1646)
merged with Luke Howard's patch. http://prdownloads.sourceforge.net/acctsync/back-perl.win32.21MAR02CVS-c.patch.gz openldap-its@OpenLDAP.org wrote: > *** THIS IS AN AUTOMATICALLY GENERATED REPLY *** > > Thanks for your report to openldap-its@OpenLDAP.org. Your report > has been placed into our Issue Tracking System and has been assigned > the tracking number ITS#1646. > > One of support engineers will look at your report in due course. > Note that this may take some time because our support engineers > are volunteers. They only work on OpenLDAP when they have spare > time. > If you need to provide additional information in regards to your > issue report, you may do so by replying to this message. Note that > any mail sent to openldap-its@openldap.org with (ITS#1646) > in the subject will automatically be attached to the issue report. > > mailto:openldap-its@openldap.org?subject=(ITS#1646) > > You may follow the progress of this message by loading the following > URL in a web browser: > http://www.OpenLDAP.org/its/index.cgi?findid=1646 > > Please remember to retain your issue tracking number (ITS#1646) > on any further messages you send to us regarding this message. If > you don't then you'll just waste our time and yours because we > won't be able to properly track the message. > > In our experience many people ask questions that have been asked > before. We recommend that you review our online FAQ: > http://www.OpenLDAP.org/faq/ > > and search archives of our many mailing lists (such as openldap-software > and openldap-bugs): > http://www.OpenLDAP.org/lists/#archives > > -------------- > Copyright 2002 The OpenLDAP Foundation, All Rights Reserved. > > -- http://linuxquestions.org/ - Ask linux questions, give linux help. http://splint.org/ - Write safe C code. splint source-code analyzer.
Date: Thu, 18 Apr 2002 03:31:12 -0400 From: Kervin Pierre <kpierre@fit.edu> To: openldap-its@OpenLDAP.org Subject: win32 back-perl build fix - ITS#1646
This is a multi-part message in MIME format. --------------010401050003080706060101 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit I see that the patch was recently added. Thanks. 2 things... * remove unneeded XSUB.h includes * add PERL_SET_CONTEXT at the beginning of any operation which may be the first in a thread. ie., bind, search, modify. This tells the thread with interpreter object to use. The perl context should be explicitly set. --Kervin -- http://linuxquestions.org/ - Ask linux questions, give linux help. http://splint.org/ - Write safe C code. splint source-code analyzer. --------------010401050003080706060101 Content-Type: text/plain; name="p1.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="p1.patch" Index: ldap/servers/slapd/back-perl/bind.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/bind.c,v retrieving revision 1.13 diff -c -r1.13 bind.c *** ldap/servers/slapd/back-perl/bind.c 2002/04/16 03:36:22 1.13 --- ldap/servers/slapd/back-perl/bind.c 2002/04/18 07:09:32 *************** *** 20,26 **** #endif #include <EXTERN.h> - #include <XSUB.h> #include <perl.h> #include "perl_back.h" --- 20,25 ---- Index: ldap/servers/slapd/back-perl/close.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/close.c,v retrieving revision 1.8 diff -c -r1.8 close.c *** ldap/servers/slapd/back-perl/close.c 2002/04/16 03:36:22 1.8 --- ldap/servers/slapd/back-perl/close.c 2002/04/18 07:09:32 *************** *** 34,40 **** perl_back_close( BackendInfo *bd ) ! { ldap_pvt_thread_mutex_lock( &perl_interpreter_mutex ); perl_destruct(PERL_INTERPRETER); --- 34,45 ---- perl_back_close( BackendInfo *bd ) ! { ! ! #ifdef HAVE_WIN32_ASPERL ! PERL_SET_CONTEXT( PERL_INTERPRETER ); ! #endif ! ldap_pvt_thread_mutex_lock( &perl_interpreter_mutex ); perl_destruct(PERL_INTERPRETER); Index: ldap/servers/slapd/back-perl/compare.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/compare.c,v retrieving revision 1.14 diff -c -r1.14 compare.c *** ldap/servers/slapd/back-perl/compare.c 2002/04/16 03:36:22 1.14 --- ldap/servers/slapd/back-perl/compare.c 2002/04/18 07:09:32 *************** *** 51,56 **** --- 51,60 ---- slap_strcopy( slap_strcopy( slap_strcopy( avastr, ava->aa_desc->ad_cname.bv_val ), "=" ), ava->aa_value.bv_val ); + + #ifdef HAVE_WIN32_ASPERL + PERL_SET_CONTEXT( PERL_INTERPRETER ); + #endif ldap_pvt_thread_mutex_lock( &perl_interpreter_mutex ); Index: ldap/servers/slapd/back-perl/delete.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/delete.c,v retrieving revision 1.11 diff -c -r1.11 delete.c *** ldap/servers/slapd/back-perl/delete.c 2002/04/16 03:36:22 1.11 --- ldap/servers/slapd/back-perl/delete.c 2002/04/18 07:09:33 *************** *** 37,42 **** --- 37,46 ---- int return_code; PerlBackend *perl_back = (PerlBackend *) be->be_private; + + #ifdef HAVE_WIN32_ASPERL + PERL_SET_CONTEXT( PERL_INTERPRETER ); + #endif ldap_pvt_thread_mutex_lock( &perl_interpreter_mutex ); Index: ldap/servers/slapd/back-perl/init.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/init.c,v retrieving revision 1.26 diff -c -r1.26 init.c *** ldap/servers/slapd/back-perl/init.c 2002/04/16 03:36:22 1.26 --- ldap/servers/slapd/back-perl/init.c 2002/04/18 07:09:33 *************** *** 20,26 **** #endif #include <EXTERN.h> - #include <XSUB.h> #include <perl.h> #include "perl_back.h" --- 20,25 ---- *************** *** 176,182 **** static void ! perl_back_xs_init() { char *file = __FILE__; dXSUB_SYS; --- 175,181 ---- static void ! perl_back_xs_init(PERL_BACK_XS_INIT_PARAMS) { char *file = __FILE__; dXSUB_SYS; Index: ldap/servers/slapd/back-perl/modify.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/servers/slapd/back-perl/modify.c,v retrieving revision 1.11 diff -c -r1.11 modify.c *** ldap/servers/slapd/back-perl/modify.c 2002/04/16 03:36:22 1.11 --- ldap/servers/slapd/back-perl/modify.c 2002/04/18 07:09:33 *************** *** 41,46 **** --- 41,50 ---- char *matched = NULL, *info = NULL; PerlBackend *perl_back = (PerlBackend *)be->be_private; + + #ifdef HAVE_WIN32_ASPERL + PERL_SET_CONTEXT( PERL_INTERPRETER ); + #endif ldap_pvt_thread_mutex_lock( &perl_interpreter_mutex ); Index: ldap/servers/slapd/back-perl/modrdn.c =================================================================== RCS file: /repo/OpenLDAP
______________ © Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org
