Full_Name: Hugh McMaster Version: 2.4.47 OS: Debian URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (60.224.220.43) Dear maintainer, Automated detection of openldap (libldap) is more laborious than it needs to be. pkg-config is comfortably available everywhere these days, making it very attractive for easier development and detection of headers and libraries. It would be very helpful if openldap could supply a pkg-config (.pc) files for libldap. If you need a patch for this, please let me know. Thank you
In reference to #8996, I have prepared a patchset that adds support for generating pkg-config files at configure-time. There are three patches, one each for libldap, libldap_r and liblber. The attached patch files are derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Hugh McMaster <hugh.mcmaster at outlook.com>. I have not assigned rights and/or interest in this work to any party. I, Hugh McMaster, hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. ftp://ftp.openldap.org/incoming/hugh-mcmaster-190405.patch ftp://ftp.openldap.org/incoming/hugh-mcmaster-190405-02.patch ftp://ftp.openldap.org/incoming/hugh-mcmaster-190405-03.patch Please review the above patches and let me know if you require any changes. Thank you Hugh
Dear OpenLDAP developers, I've rebased the above patches on the current master branch (as of 29 September) and replaced them on the FTP server. I'm hoping someone can review them as development begins on the 2.5 branch. Thank you, Hugh
Hello Hugh, Thanks for providing the patches. I have reviewed and tested them, everything I could think of works properly. As a personal opinion I might prefer shorter descriptions, for example "OpenLDAP ASN.1 Basic Encoding Rules library for LDAP" and "OpenLDAP Lightweight Directory Access Protocol library (reentrant version)". Only an opinion, there's nothing wrong with what you wrote. I'd like to see this included, however a more senior team member should approve it first. Good luck! cheers, Ryan
Hi Ryan, Thank you for your review. On Thu, 3 Oct 2019 at 13:05, Ryan Tandy wrote: > Thanks for providing the patches. I have reviewed and tested them, > everything I could think of works properly. Excellent! :) > As a personal opinion I might prefer shorter descriptions, for example > "OpenLDAP ASN.1 Basic Encoding Rules library for LDAP" and "OpenLDAP > Lightweight Directory Access Protocol library (reentrant version)". Only > an opinion, there's nothing wrong with what you wrote. I'm happy for the descriptions to be whatever describes the libraries best. I particularly like your shortened ASN.1 description. > I'd like to see this included, however a more senior team member should > approve it first. Good luck! Thanks. Hopefully that will happen soon. Kind regards, Hugh
Created attachment 767 [details] hugh-mcmaster-190405.patch
Created attachment 768 [details] hugh-mcmaster-190405-02.patch
Created attachment 769 [details] hugh-mcmaster-190405-03.patch
https://git.openldap.org/openldap/openldap/-/merge_requests/264
Commits: • 3eea13bd by Hugh McMaster at 2021-03-15T21:39:55+00:00 ITS#8996 - Generate and install a pkg-config file for the liblber library • baee6c47 by Hugh McMaster at 2021-03-15T21:39:55+00:00 ITS#8996 - Generate and install a pkg-config file for the libldap library