Full_Name: Ondrej Kuznik Version: master OS: URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170913-LDAP_CIRCLEQ.patch Submission from: (NULL) (82.10.24.68) The CIRCLEQ macros are incomplete and not very useful on their own, but when providing a few more that allow rotating it, they are. Patch to that effect is attached. They could probably be made a bit more efficient as well, though.
ondra@openldap.org wrote: > Full_Name: Ondrej Kuznik > Version: master > OS: > URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170913-LDAP_CIRCLEQ.patch > Submission from: (NULL) (82.10.24.68) > > > The CIRCLEQ macros are incomplete and not very useful on their > own, but when providing a few more that allow rotating it, they > are. Patch to that effect is attached. > > They could probably be made a bit more efficient as well, though. Nothing in this patch says "rotate" anywhere. Please add some more descriptive comments describing the purpose of each new macro. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
On Tue, Sep 26, 2017 at 02:00:40PM +0100, Howard Chu wrote: > Nothing in this patch says "rotate" anywhere. Please add some more > descriptive comments describing the purpose of each new macro. A version with the circular queue description extended to cover the rotation macros is available here: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170926-LDAP_CIRCLEQ.patch -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP
okuznik@symas.com wrote: > On Tue, Sep 26, 2017 at 02:00:40PM +0100, Howard Chu wrote: >> Nothing in this patch says "rotate" anywhere. Please add some more >> descriptive comments describing the purpose of each new macro. > > A version with the circular queue description extended to cover the > rotation macros is available here: > > ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170926-LDAP_CIRCLEQ.patch OK. Go ahead and merge. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
Added to master
changed notes changed state Open to Test moved from Incoming to Software Enhancements