Issue 90 - Missing return values from backends
Summary: Missing return values from backends
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1999-03-03 19:41 UTC by Hallvard Furuseth
Modified: 2014-08-01 21:06 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Hallvard Furuseth 1999-03-03 19:41:38 UTC 
Some callback routines fail to return an integer status.

  perl_back_db_destroy in back-perl/close.c
  perl_back_search     in back-perl/search.c
  ldbm_back_unbind     in back-ldbm/unbind.c

All are caught by gcc -Wimplicit -Wreturn-type.  That is,
-Wimplicit would have discovered that back-ldbm needs this patch

--- unbind.c	1998/11/15 21:40:22	1.3
+++ unbind.c	1999/03/03 16:23:19
@@ -7,6 +7,8 @@
 
 #include "slap.h"
+#include "back-ldbm.h"
+#include "proto-back-ldbm.h"
 
-void
+int
 ldbm_back_unbind(
 	Backend     *be,


...but I'm not sure _what_ these routines should return.
Is there a brief README for the backend interfaces somewhere?

-- 
Hallvard
Comment 1 Hallvard Furuseth 1999-03-03 20:56:37 UTC 
moved from Incoming to Software Bugs
Comment 2 Kurt Zeilenga 1999-03-03 22:32:27 UTC 
changed notes
Comment 3 Kurt Zeilenga 1999-03-26 19:06:34 UTC 
changed state Open to Closed
Comment 4 Kurt Zeilenga 1999-03-26 19:08:21 UTC 
I've closed this ITS as it's a development issue.
You're welcome to apply the suggested fix if you
believe it is correct.

Kurt
Comment 5 OpenLDAP project 2014-08-01 21:06:52 UTC 
devel issue?