Full_Name: Ian Brabham Version: 1.1.4 -Devel OS: Win32 (NT/95/98) URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (130.194.41.14) Dear LDAP'ers, The LDAPDelete, LDAPModify, LDAPModrdn, LDAPSearch have been modified to accept -W option now and subsequently have calls to "char *getpass(char *)" included. In the standard Win32 environment this routine is not available. To complete the build I ripped off the mygetpasswd() routine from .../ldap/client/ud/util.c to make a getpass.c and included it in the libutil project along with getopt.c, etc. It might be a good idea to use this everywhere as some getpass() implementation break with long passwords sometimes used in the LDAP world. Also there appears to be some confusion as to the correct names various libraries should have in various projects. I have unified these across all projects based on names "ol*32.lib" which seems to be your upcoming standard. I will try to conform to any guidlines you have and can ship you a full set of updated *.dsp and *.dsw project files with the updates if you like. Also what happened to LDAP32.DLL from the project? Ian
At 12:57 AM 2/11/99 GMT, Ian.Brabham@SirJohnMonash.com.au wrote: >Full_Name: Ian Brabham >Version: 1.1.4 -Devel No such beast? I assume you mean 2.0-Devel (or some 1.2-beta) >OS: Win32 (NT/95/98) > >The LDAPDelete, LDAPModify, LDAPModrdn, LDAPSearch have been >modified to accept -W option now and subsequently have calls >to "char *getpass(char *)" included. In the standard Win32 >environment this routine is not available. > >To complete the build I ripped off the mygetpasswd() routine from >.../ldap/client/ud/util.c to make a getpass.c and included it in >the libutil project along with getopt.c, etc. It might be a good >idea to use this everywhere as some getpass() implementation break >with long passwords sometimes used in the LDAP world. Wrap it an #ifndef HAVE_GETPASS. We may still want to use getpass() on some systems. This makes it easy to enable or disable (based on whatever configure test decided to use). >Also there appears to be some confusion as to the correct names >various libraries should have in various projects. I have unified >these across all projects based on names "ol*32.lib" which seems >to be your upcoming standard. Yes, they should be ol{dap,ber,util,...}32.lib. >I will try to conform to any guidlines you have and can ship you >a full set of updated *.dsp and *.dsw project files with the updates >if you like. Unified diffs please, relative to -devel if possible. I recommend all contributing developers use CVS whenever possible... the NT version works like a charm. >Also what happened to LDAP32.DLL from the project? That's a task for an enterprising developer... Kurt
moved from Incoming to Software Bugs
changed notes changed state Open to Suspended
I made the necessary changes for 1.2.
changed notes changed state Suspended to Closed
Full_Name: Ian Brabham Version: 2.0-Devel OS: WIN32 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (130.194.41.14) I have been putting the latest version of the clients and libraries under WIN32 through it's paces and it all appears very good so far. One issue that has come up since the August 1998 build I was using is that you have upgraded to Winsock 2 (HAVE_WINSOCK2 & ws2_32.lib). One of my test PC's of course didn't have it. So I built a Winsock 1.1 version (linking with wsock32.lib) and open.c wouldn't compile with this option. Below is a diff of the patch that is required. Works a treat on all WIN32 (95/98/NT) platforms tested so far :-) Index: open.c =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/libraries/libldap/open.c,v retrieving revision 1.17 diff -u -r1.17 open.c --- open.c 1999/01/31 00:09:00 1.17 +++ open.c 1999/02/19 05:03:24 @@ -132,9 +132,11 @@ } /* The WinSock DLL is acceptable. Proceed. */ #elif HAVE_WINSOCK - if ( WSAStartup( 0x0101, &wsadata ) != 0 ) { +{ WSADATA wsaData; + if ( WSAStartup( 0x0101, &wsaData ) != 0 ) { return( NULL ); } +} #endif if ( (ld = (LDAP *) calloc( 1, sizeof(LDAP) )) == NULL ) { ===================================================================
Full_Name: Ian Brabham Version: 2.0-Devel OS: WIN32 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (130.194.41.14) While doing a Batch Build All I found the release build version of dtest.exe did not link, it was missing the /libpath:"..\Release" Index: dtest.dsp =================================================================== RCS file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/dtest.dsp,v retrieving revision 1.3 diff -u -r1.3 dtest.dsp --- dtest.dsp 1999/02/11 20:16:03 1.3 +++ dtest.dsp 1999/02/19 05:03:56 @@ -49,7 +49,7 @@ # ADD BSC32 /nologo LINK32=link.exe # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /subsystem:console /machine:I386 -# ADD LINK32 olber32.lib ws2_32.lib /nologo /subsystem:console /machine:I386 +# ADD LINK32 olber32.lib ws2_32.lib /nologo /subsystem:console /machine:I386 /libpath:"..\Release" !ELSEIF "$(CFG)" == "dtest - Win32 Debug" ===================================================================
Fixed in release 1.2