Issue 673 - slapindex check for be functions
Summary: slapindex check for be functions
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-08-18 14:04 UTC by Mark Adamson
Modified: 2014-08-01 21:05 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Mark Adamson 2000-08-18 14:04:37 UTC 
slapindex checks to see if the backend db has the functions necessary for
reindexing. But the check should fail if ANY are missing, not just the
special case where ALL are missing. The logic is wrong. Right?

-Mark Adamson
 Carnegie Mellon




--- .orig/servers/slapd/tools/slapindex.c       Wed Jul 26 11:23:07 2000
+++ servers/slapd/tools/slapindex.c     Fri Aug 18 09:57:46 2000
@@ -24,10 +24,10 @@
 
        slap_tool_init( "slapindex", SLAPINDEX, argc, argv );
 
-       if( !be->be_entry_open &&
-               !be->be_entry_close &&
-               !be->be_entry_first &&
-               !be->be_entry_next &&
+       if( !be->be_entry_open ||
+               !be->be_entry_close ||
+               !be->be_entry_first ||
+               !be->be_entry_next  ||
                !be->be_entry_reindex )
        {
                fprintf( stderr, "%s: database doesn't support necessary
operations.\n",
Comment 1 Kurt Zeilenga 2000-08-18 16:30:24 UTC 
changed notes
changed state Open to Closed
moved from Incoming to Development
Comment 2 OpenLDAP project 2014-08-01 21:05:27 UTC 
commit