Full_Name: John E. Schimmel Version: 2.0-dev OS: FreeBSD 3.4 URL: ftp://ftp.openldap.org/incoming/jschimmel-000727.tgz Submission from: (NULL) (208.48.74.2) These are just some simple performance tweaks to the current server source. Later, John
John, I review your suggestions. Some general notes: we opt for correctness over portability, portability over performance. So, before any change are made to improve performance, we must ensure the suggested changes are correct, improve portability, and improve performance significantly across all (or most) platforms. This generally takes time. Also note that it's generally advised to submit separate patch for each unrelated change. Though these changes are related by their common goal, they are other quite unrelated and must be reviewed separately. At 03:39 PM 7/27/00 +0000, jschimmel@mirapoint.com wrote: >Full_Name: John E. Schimmel >Version: 2.0-dev >OS: FreeBSD 3.4 >URL: ftp://ftp.openldap.org/incoming/jschimmel-000727.tgz >Submission from: (NULL) (208.48.74.2) > > > >These are just some simple performance tweaks to the current server >source. > >Later, >John
These changes were fairly easy to review. SAFEMEMCPY suggested change is not safe (overlapping regions). Per analysis of others, likely only a simple (and SAFE) len==1 optimization would be yield performance improvement across most platforms. man alloca(3) BUGS: The alloca() function is machine dependent; its use is discouraged. connection.c/tmpdn change applied. fast_strs/fast_cstr optimizations may be worth generalizing and extended to support buffer overrun detection
changed state Open to Suspended moved from Incoming to Development
I believe the generally useful parts of this submission were committed. The list issues need to be solved in a more general manner. Discussion to -devel, please. Kurt
changed state Suspended to Closed