Issue 634 - Compile error in libraries/liblber/io.c
Summary: Compile error in libraries/liblber/io.c
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-07-21 18:49 UTC by Steve Sonntag
Modified: 2000-07-30 08:37 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Steve Sonntag 2000-07-21 18:49:08 UTC 
I am getting a compile error in io.c when using the 
Metrowerks compiler.  It needs a simple cast to fix it.


Index: io.c
===================================================================
RCS file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/io.c,v
retrieving revision 1.50
diff -u -r1.50 io.c
--- io.c 2000/06/14 19:12:16 1.50
+++ io.c 2000/07/21 18:43:06
@@ -36,7 +36,7 @@
 
 static ber_slen_t BerRead LDAP_P((
  Sockbuf *sb,
- char *buf,
+ unsigned char *buf,
  ber_len_t len ));
 
 #define EXBUFSIZ 1024
@@ -52,7 +52,7 @@
 static ber_slen_t
 BerRead(
  Sockbuf *sb,
- char *buf,
+ unsigned char *buf,
  ber_len_t len )
 {
  ber_slen_t c;



------------------------
Steve Sonntag
Novell Directory Services
+1 801 861 7097
Comment 1 Kurt Zeilenga 2000-07-21 19:46:16 UTC 
What was the actual error which prompted this suggestion?

At 06:49 PM 7/21/00 +0000, VTAG@novell.com wrote:
>This is a MIME message. If you are reading this text, you may want to 
>consider changing to a mail reader or gateway that understands how to 
>properly handle MIME multipart messages.
>
>--=_8CD4C03E.ACCDA7C7
>Content-Type: text/plain; charset=US-ASCII
>Content-Transfer-Encoding: quoted-printable
>
>I am getting a compile error in io.c when using the=20
>Metrowerks compiler.  It needs a simple cast to fix it.
>
>
>Index: io.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>RCS file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/io.c,v
>retrieving revision 1.50
>diff -u -r1.50 io.c
>--- io.c 2000/06/14 19:12:16 1.50
>+++ io.c 2000/07/21 18:43:06
>@@ -36,7 +36,7 @@
>=20
> static ber_slen_t BerRead LDAP_P((
>  Sockbuf *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len ));
>=20
> #define EXBUFSIZ 1024
>@@ -52,7 +52,7 @@
> static ber_slen_t
> BerRead(
>  Sockbuf *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len )
> {
>  ber_slen_t c;
>
>
>
>------------------------
>Steve Sonntag
>Novell Directory Services
>+1 801 861 7097
>
>--=_8CD4C03E.ACCDA7C7
>Content-Type: text/html; charset=ISO-8859-1
>Content-Transfer-Encoding: quoted-printable
>
><!DOCTYPE HTML PUBLIC "-//W3C//DTD W3 HTML//EN">
>I am getting a compile error in io.c when using the=20 
>Metrowerks compiler.  It needs a simple cast to = fix=20 it.
> 
> 
>Index:=20 io.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>RCS=20 file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/io.c,v
>retrieving = revision=20 1.50
>diff -u -r1.50 io.c
>--- io.c 2000/06/14 19:12:16 1.50
>+++ = io.c=20 2000/07/21 18:43:06
>@@ -36,7 +36,7 @@
> 
> static = ber_slen_t=20 BerRead LDAP_P((
>  Sockbuf *sb,
>- char *buf,
>+ unsigned = char=20 *buf,
>  ber_len_t len ));
> 
> #define EXBUFSIZ = 1024
>@@=20 -52,7 +52,7 @@
> static ber_slen_t
> BerRead(
>  = Sockbuf=20 *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len=20 )
> {
>  ber_slen_t c;
> 
> 
> 
>------------------------
>Steve Sonntag
>Novell = Directory=20 Services
>+1 801 861 7097
>
>--=_8CD4C03E.ACCDA7C7--
Comment 2 Kurt Zeilenga 2000-07-21 19:59:19 UTC 
Fixed, thanks.

At 06:49 PM 7/21/00 +0000, VTAG@novell.com wrote:
>This is a MIME message. If you are reading this text, you may want to 
>consider changing to a mail reader or gateway that understands how to 
>properly handle MIME multipart messages.
>
>--=_8CD4C03E.ACCDA7C7
>Content-Type: text/plain; charset=US-ASCII
>Content-Transfer-Encoding: quoted-printable
>
>I am getting a compile error in io.c when using the=20
>Metrowerks compiler.  It needs a simple cast to fix it.
>
>
>Index: io.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>RCS file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/io.c,v
>retrieving revision 1.50
>diff -u -r1.50 io.c
>--- io.c 2000/06/14 19:12:16 1.50
>+++ io.c 2000/07/21 18:43:06
>@@ -36,7 +36,7 @@
>=20
> static ber_slen_t BerRead LDAP_P((
>  Sockbuf *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len ));
>=20
> #define EXBUFSIZ 1024
>@@ -52,7 +52,7 @@
> static ber_slen_t
> BerRead(
>  Sockbuf *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len )
> {
>  ber_slen_t c;
>
>
>
>------------------------
>Steve Sonntag
>Novell Directory Services
>+1 801 861 7097
>
>--=_8CD4C03E.ACCDA7C7
>Content-Type: text/html; charset=ISO-8859-1
>Content-Transfer-Encoding: quoted-printable
>
><!DOCTYPE HTML PUBLIC "-//W3C//DTD W3 HTML//EN">
>I am getting a compile error in io.c when using the=20 
>Metrowerks compiler.  It needs a simple cast to = fix=20 it.
> 
> 
>Index:=20 io.c
>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>RCS=20 file: /repo/OpenLDAP/pkg/ldap/libraries/liblber/io.c,v
>retrieving = revision=20 1.50
>diff -u -r1.50 io.c
>--- io.c 2000/06/14 19:12:16 1.50
>+++ = io.c=20 2000/07/21 18:43:06
>@@ -36,7 +36,7 @@
> 
> static = ber_slen_t=20 BerRead LDAP_P((
>  Sockbuf *sb,
>- char *buf,
>+ unsigned = char=20 *buf,
>  ber_len_t len ));
> 
> #define EXBUFSIZ = 1024
>@@=20 -52,7 +52,7 @@
> static ber_slen_t
> BerRead(
>  = Sockbuf=20 *sb,
>- char *buf,
>+ unsigned char *buf,
>  ber_len_t len=20 )
> {
>  ber_slen_t c;
> 
> 
> 
>------------------------
>Steve Sonntag
>Novell = Directory=20 Services
>+1 801 861 7097
>
>--=_8CD4C03E.ACCDA7C7--
Comment 3 Kurt Zeilenga 2000-07-24 16:15:00 UTC 
moved from Incoming to Documentation
Comment 4 Kurt Zeilenga 2000-07-30 08:37:56 UTC 
changed state Open to Closed
moved from Documentation to Development