Issue 41 - Adding rev id's to source files
Summary: Adding rev id's to source files
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 1999-01-13 02:22 UTC by brad.rubenstein@gs.com
Modified: 2014-08-01 21:07 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description brad.rubenstein@gs.com 1999-01-13 02:22:21 UTC
Full_Name: Brad Rubenstein
Version: 1.1.2
OS: solaris 2.6
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (208.168.16.140)


A suggestion: if we put /* $Header$ */ at the top of all 
source files, I can easily figure out the revision number of some problem code,

when I have no context except the source file (long after I've pulled a release
and
unzipped it,
which release it is and what patchlevel, is information that I no longer have).
Alternatively (and perhaps easier), when you
build the tgz files for the distributions,
leave the CVS directories in, so after the tgz is long gone, there is still
enough information in the source code to figure out
which release the sources came from.
Comment 1 Kurt Zeilenga 1999-01-13 02:50:30 UTC
moved from Incoming to Software
Comment 2 Kurt Zeilenga 1999-01-13 03:13:51 UTC
At 02:22 AM 1/13/99 GMT, brad.rubenstein@gs.com wrote:
>Full_Name: Brad Rubenstein
>Version: 1.1.2
>OS: solaris 2.6
>URL: ftp://ftp.openldap.org/incoming/
>Submission from: (NULL) (208.168.16.140)
>
>
>A suggestion: if we put /* $Header$ */ at the top of all 
>source files, I can easily figure out the revision number of some problem code,

I had problem initially with CVS variable substitute causing conflicts
during merges.  However, this was primarily with preexisting RCS tags
from the U-Mich distribution.   I may try to add new tags to a couple
of a file or two, but if they cause conflicts they are gone (merges
are hard enough).  If they don't cause problems, then we can consider
adding them across the board.

>when I have no context except the source file (long after I've pulled a release
>and
>unzipped it,
>which release it is and what patchlevel, is information that I no longer have).
>Alternatively (and perhaps easier), when you
>build the tgz files for the distributions,
>leave the CVS directories in, so after the tgz is long gone, there is still
>enough information in the source code to figure out
>which release the sources came from.

The CVS directories are only useful if you have CVS.  If you have CVS,
you should really grab OpenLDAP via AnonCVS or CVSup.  And, if you applied
a patch, the patch (generated using CVSweb) the files in CVS wouldn't
be updated.
Comment 3 Brad Rubenstein 1999-01-13 03:35:54 UTC
Kurt@OpenLDAP.org wrote:
> The CVS directories are only useful if you have CVS.  If you have CVS,
> you should really grab OpenLDAP via AnonCVS or CVSup.  And, if you applied
> a patch, the patch (generated using CVSweb) the files in CVS wouldn't
> be updated.

I have CVS, but I'm behind a serious corporate firewall, so can't use it
for openldap. 

However, if i know there is a bug in line 52 of search.c, I can look up
the revision in CVS/Entries (if it is there), and what the tag was (in
CVS/Tag).  
I guess I could say "there is a bug in line 52 of .../search.c in
openldap-stable-981231", but I'm open to whatever you prefer.

Brad
Comment 4 Kurt Zeilenga 1999-01-13 17:41:33 UTC
changed notes
changed state Open to Suspended
Comment 5 Kurt Zeilenga 1999-01-13 17:55:29 UTC
moved from Software to Software Enhancements
Comment 6 Kurt Zeilenga 1999-07-27 15:39:17 UTC
changed notes
changed state Suspended to Closed
Comment 7 OpenLDAP project 2014-08-01 21:07:00 UTC
Need to be tested with latest CVS to ensure merge conflicts
do not result from change.
Not needed.