Issue 8918 - sasl.c:326: possible bad assignment ?
Summary: sasl.c:326: possible bad assignment ?
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.46
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-22 10:11 UTC by dcb314@hotmail.com
Modified: 2018-12-19 17:21 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description dcb314@hotmail.com 2018-09-22 10:11:36 UTC 
Full_Name: David Binderman
Version: 2.4.46
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (79.65.83.114)


sasl.c:326:6: warning: equality comparison result unused [-Wunused-comparison]

view +326 openldap/openldap-2.4.46/servers/slapd/sasl.c

Source code is

        if ( !conn ) {
                rc == LDAP_SUCCESS;
                goto done;
        }

Suggest new code

        if ( !conn ) {
                rc = LDAP_SUCCESS;
                goto done;
        }
Comment 1 Quanah Gibson-Mount 2018-09-24 17:19:10 UTC 
changed notes
changed state Open to Release
moved from Incoming to Software Bugs
Comment 2 Quanah Gibson-Mount 2018-09-26 20:01:56 UTC 
--On Saturday, September 22, 2018 11:11 AM +0000 dcb314@hotmail.com wrote:

> Full_Name: David Binderman
> Version: 2.4.46
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (79.65.83.114)

Thanks for the report, this has been fixed.

--Quanah


--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
Comment 3 OpenLDAP project 2018-12-19 17:21:21 UTC 
Fixed in master
Fixed in RE24 (2.4.47)
Comment 4 Quanah Gibson-Mount 2018-12-19 17:21:21 UTC 
changed notes
changed state Release to Closed