OpenLDAP
Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest

Viewing Software Enhancements/8732
Full headers

From: ondra@openldap.org
Subject: LDAP_CIRCLEQ improvements
Compose comment
Download message
State:
0 replies:
3 followups: 1 2 3

Major security issue: yes  no

Notes:

Notification:


Date: Wed, 13 Sep 2017 12:44:01 +0000
From: ondra@openldap.org
To: openldap-its@OpenLDAP.org
Subject: LDAP_CIRCLEQ improvements
Full_Name: Ondrej Kuznik
Version: master
OS: 
URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170913-LDAP_CIRCLEQ.patch
Submission from: (NULL) (82.10.24.68)


The CIRCLEQ macros are incomplete and not very useful on their
own, but when providing a few more that allow rotating it, they
are. Patch to that effect is attached.

They could probably be made a bit more efficient as well, though.

Followup 1

Download message
Subject: Re: (ITS#8732) LDAP_CIRCLEQ improvements
To: ondra@openldap.org, openldap-its@OpenLDAP.org
From: Howard Chu <hyc@symas.com>
Date: Tue, 26 Sep 2017 14:00:40 +0100
ondra@openldap.org wrote:
> Full_Name: Ondrej Kuznik
> Version: master
> OS:
> URL: ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170913-LDAP_CIRCLEQ.patch
> Submission from: (NULL) (82.10.24.68)
> 
> 
> The CIRCLEQ macros are incomplete and not very useful on their
> own, but when providing a few more that allow rotating it, they
> are. Patch to that effect is attached.
> 
> They could probably be made a bit more efficient as well, though.

Nothing in this patch says "rotate" anywhere. Please add some more descriptive 
comments describing the purpose of each new macro.


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/



Followup 2

Download message
Date: Tue, 26 Sep 2017 15:20:54 +0100
From: =?utf-8?B?T25kxZllaiBLdXpuw61r?= <okuznik@symas.com>
To: Howard Chu <hyc@symas.com>
Cc: ondra@openldap.org, openldap-its@OpenLDAP.org
Subject: Re: (ITS#8732) LDAP_CIRCLEQ improvements
On Tue, Sep 26, 2017 at 02:00:40PM +0100, Howard Chu wrote:
> Nothing in this patch says "rotate" anywhere. Please add some more
> descriptive comments describing the purpose of each new macro.

A version with the circular queue description extended to cover the
rotation macros is available here:

ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170926-LDAP_CIRCLEQ.patch

--=20
Ond=C5=99ej Kuzn=C3=ADk
Senior Software Engineer
Symas Corporation                       http://www.symas.com
Packaged, certified, and supported LDAP solutions powered by OpenLDAP



Followup 3

Download message
Subject: Re: (ITS#8732) LDAP_CIRCLEQ improvements
To: okuznik@symas.com, openldap-its@OpenLDAP.org
From: Howard Chu <hyc@symas.com>
Date: Thu, 28 Sep 2017 03:55:12 +0100
okuznik@symas.com wrote:
> On Tue, Sep 26, 2017 at 02:00:40PM +0100, Howard Chu wrote:
>> Nothing in this patch says "rotate" anywhere. Please add some more
>> descriptive comments describing the purpose of each new macro.
> 
> A version with the circular queue description extended to cover the
> rotation macros is available here:
> 
> ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170926-LDAP_CIRCLEQ.patch

OK. Go ahead and merge.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/


Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest


The OpenLDAP Issue Tracking System uses a hacked version of JitterBug

______________
© Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org