Viewing Software Enhancements/7501
Full headers

Major security issue: yes  no

Notes:
Applied to master Applied to RE24 Breaks back-ldap dynamic config Needs back-meta support
Notification:

Date: Thu, 24 Jan 2013 04:03:57 +0000
From: tedcheng@symas.com
To: openldap-its@OpenLDAP.org
Subject: added TCP keepalive support to back_ldap

Full_Name: Ted C. Cheng
Version: master
OS: Linux/Solaris
URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
Submission from: (NULL) (76.174.253.197)



Please find in the URL a patch that adds TCP keepalive support to back_ldap.

Please review and apply the patch.

Thanks,


Ted C. Cheng
Symas Corporation

Followup 1

Date: Thu, 24 Jan 2013 13:32:20 +0000
From: Howard Chu <hyc@symas.com>
To: tedcheng@symas.com, openldap-its@openldap.org
Subject: Re: (ITS#7501) added TCP keepalive support to back_ldap

tedcheng@symas.com wrote:
> Full_Name: Ted C. Cheng
> Version: master
> OS: Linux/Solaris
> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
> Submission from: (NULL) (76.174.253.197)
>
>
>
> Please find in the URL a patch that adds TCP keepalive support to
back_ldap.
>
> Please review and apply the patch.

Note - constructs like "#if 0" are only used for tentative/experimental 
changes. For patches intended to be released to the public, just delete the 
blocked out lines.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Followup 2

Subject: Re: (ITS#7501) added TCP keepalive support to back_ldap
From: "Ted C. Cheng" <tedcheng@symas.com>
Date: Thu, 24 Jan 2013 08:16:15 -0800
Cc: openldap-its@openldap.org
To: Howard Chu <hyc@symas.com>

On Jan 24, 2013, at 5:32 AM, Howard Chu wrote:

> tedcheng@symas.com wrote:
>> Full_Name: Ted C. Cheng
>> Version: master
>> OS: Linux/Solaris
>> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
>> Submission from: (NULL) (76.174.253.197)
>> 
>> 
>> 
>> Please find in the URL a patch that adds TCP keepalive support to
back_ldap.
>> 
>> Please review and apply the patch.
> 
> Note - constructs like "#if 0" are only used for tentative/experimental
changes. For patches intended to be released to the public, just delete the
blocked out lines.
> 

"#if 0" seems to be a common practice in the code. I only removed the one in the
patch. Please find in the link below.

https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch


Ted C. Cheng
Symas Corporation

Followup 3

Date: Sun, 27 Jan 2013 10:02:42 -0800
From: Quanah Gibson-Mount <quanah@zimbra.com>
To: tedcheng@symas.com, openldap-its@openldap.org
Subject: Re: (ITS#7501) added TCP keepalive support to back_ldap

--On Thursday, January 24, 2013 4:16 PM +0000 tedcheng@symas.com wrote:

>
> On Jan 24, 2013, at 5:32 AM, Howard Chu wrote:
>
>> tedcheng@symas.com wrote:
>>> Full_Name: Ted C. Cheng
>>> Version: master
>>> OS: Linux/Solaris
>>> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
>>> Submission from: (NULL) (76.174.253.197)

Hi Ted,

This has been applied to HEAD and RE24, but it has exposed two issues.

1) This has broken back-ldap with dynamic configuration
2) back-meta should be updated to support this parameter as well.

Can you please supply an updated patch based off current RE24 and HEAD 
addressing these two issues.

Thanks!

--Quanah



--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Followup 4

Subject: Re: (ITS#7501) added TCP keepalive support to back_ldap
From: "Ted C. Cheng" <tedcheng@symas.com>
Date: Sun, 27 Jan 2013 11:56:31 -0800
Cc: openldap-its@openldap.org
To: Quanah Gibson-Mount <quanah@zimbra.com>

Hi Quanah,

On Jan 27, 2013, at 10:02 AM, Quanah Gibson-Mount wrote:
> 
> This has been applied to HEAD and RE24, but it has exposed two issues.
> 
> 1) This has broken back-ldap with dynamic configuration

I got a bug report that the static configuration of the keepalive parameter does
not get successfully converted to dynamic configuration. Is this the same issue
as yours? If not, could you elaborate further?

Thanks,

Ted C. Cheng
Symas Corporation

Followup 5

Date: Sun, 27 Jan 2013 13:41:35 -0800
From: Quanah Gibson-Mount <quanah@zimbra.com>
To: tedcheng@symas.com, openldap-its@openldap.org
Subject: Re: (ITS#7501) added TCP keepalive support to back_ldap

--On Sunday, January 27, 2013 7:56 PM +0000 tedcheng@symas.com wrote:

> Hi Quanah,
>
> On Jan 27, 2013, at 10:02 AM, Quanah Gibson-Mount wrote:
>>
>> This has been applied to HEAD and RE24, but it has exposed two issues.
>>
>> 1) This has broken back-ldap with dynamic configuration
>
> I got a bug report that the static configuration of the keepalive
> parameter does not get successfully converted to dynamic configuration.
> Is this the same issue as yours? If not, could you elaborate further?

Hi Ted,

Yes, the same issue.

Thanks,
Quanah

--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration