Issue 7501 - added TCP keepalive support to back_ldap
Summary: added TCP keepalive support to back_ldap
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-24 04:03 UTC by tedcheng@symas.com
Modified: 2020-08-19 16:22 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description tedcheng@symas.com 2013-01-24 04:03:57 UTC
Full_Name: Ted C. Cheng
Version: master
OS: Linux/Solaris
URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
Submission from: (NULL) (76.174.253.197)



Please find in the URL a patch that adds TCP keepalive support to back_ldap.

Please review and apply the patch.

Thanks,


Ted C. Cheng
Symas Corporation

Comment 1 Howard Chu 2013-01-24 13:32:20 UTC
tedcheng@symas.com wrote:
> Full_Name: Ted C. Cheng
> Version: master
> OS: Linux/Solaris
> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
> Submission from: (NULL) (76.174.253.197)
>
>
>
> Please find in the URL a patch that adds TCP keepalive support to back_ldap.
>
> Please review and apply the patch.

Note - constructs like "#if 0" are only used for tentative/experimental 
changes. For patches intended to be released to the public, just delete the 
blocked out lines.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 2 tedcheng@symas.com 2013-01-24 16:16:15 UTC
On Jan 24, 2013, at 5:32 AM, Howard Chu wrote:

> tedcheng@symas.com wrote:
>> Full_Name: Ted C. Cheng
>> Version: master
>> OS: Linux/Solaris
>> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
>> Submission from: (NULL) (76.174.253.197)
>> 
>> 
>> 
>> Please find in the URL a patch that adds TCP keepalive support to back_ldap.
>> 
>> Please review and apply the patch.
> 
> Note - constructs like "#if 0" are only used for tentative/experimental changes. For patches intended to be released to the public, just delete the blocked out lines.
> 

"#if 0" seems to be a common practice in the code. I only removed the one in the patch. Please find in the link below.

https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch


Ted C. Cheng
Symas Corporation




Comment 3 Quanah Gibson-Mount 2013-01-24 19:35:55 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Enhancements
Comment 4 Quanah Gibson-Mount 2013-01-27 03:27:41 UTC
changed notes
changed state Test to Release
Comment 5 Quanah Gibson-Mount 2013-01-27 18:02:42 UTC
--On Thursday, January 24, 2013 4:16 PM +0000 tedcheng@symas.com wrote:

>
> On Jan 24, 2013, at 5:32 AM, Howard Chu wrote:
>
>> tedcheng@symas.com wrote:
>>> Full_Name: Ted C. Cheng
>>> Version: master
>>> OS: Linux/Solaris
>>> URL:  https://dl.dropbox.com/u/94235048/back_ldap_tcp_keepalive.patch
>>> Submission from: (NULL) (76.174.253.197)

Hi Ted,

This has been applied to HEAD and RE24, but it has exposed two issues.

1) This has broken back-ldap with dynamic configuration
2) back-meta should be updated to support this parameter as well.

Can you please supply an updated patch based off current RE24 and HEAD 
addressing these two issues.

Thanks!

--Quanah



--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 6 Quanah Gibson-Mount 2013-01-27 18:03:21 UTC
changed notes
changed state Release to Open
Comment 7 tedcheng@symas.com 2013-01-27 19:56:31 UTC
Hi Quanah,

On Jan 27, 2013, at 10:02 AM, Quanah Gibson-Mount wrote:
> 
> This has been applied to HEAD and RE24, but it has exposed two issues.
> 
> 1) This has broken back-ldap with dynamic configuration

I got a bug report that the static configuration of the keepalive parameter does not get successfully converted to dynamic configuration. Is this the same issue as yours? If not, could you elaborate further?

Thanks,

Ted C. Cheng
Symas Corporation


Comment 8 Quanah Gibson-Mount 2013-01-27 21:41:35 UTC
--On Sunday, January 27, 2013 7:56 PM +0000 tedcheng@symas.com wrote:

> Hi Quanah,
>
> On Jan 27, 2013, at 10:02 AM, Quanah Gibson-Mount wrote:
>>
>> This has been applied to HEAD and RE24, but it has exposed two issues.
>>
>> 1) This has broken back-ldap with dynamic configuration
>
> I got a bug report that the static configuration of the keepalive
> parameter does not get successfully converted to dynamic configuration.
> Is this the same issue as yours? If not, could you elaborate further?

Hi Ted,

Yes, the same issue.

Thanks,
Quanah

--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 9 OpenLDAP project 2014-08-01 21:04:56 UTC
Applied to master
Applied to RE24
Breaks back-ldap dynamic config
Needs back-meta support
Comment 10 Quanah Gibson-Mount 2020-03-20 17:15:17 UTC
Need to confirm that dynamic config conversion still works.

Need to ensure similar support in back-meta (back-asyncmeta too?)

Need to examine the bits that use #if 0 (comment#1)
Comment 11 Quanah Gibson-Mount 2020-03-20 17:15:57 UTC
Related commits:

ae74fa109def47dafbf899d4453f07d15f152e19
0fe475ed651894b1678ed28ad7ee4e20167fd48f
Comment 12 Quanah Gibson-Mount 2020-05-22 19:26:29 UTC
(In reply to Quanah Gibson-Mount from comment #10)
> Need to confirm that dynamic config conversion still works.

conversion works

> Need to ensure similar support in back-meta (back-asyncmeta too?)

Support exists

> Need to examine the bits that use #if 0 (comment#1)

Looks fine

Fixed in 2.4.34