Issue 8583 - LDAPCtrl::LDAPCtrl(const LDAPControl* ctrl) issue
Summary: LDAPCtrl::LDAPCtrl(const LDAPControl* ctrl) issue
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.44
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 22:28 UTC by jim.rooks@neustar.biz
Modified: 2018-03-22 19:25 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jim.rooks@neustar.biz 2017-02-06 22:28:43 UTC
Full_Name: Jim Rooks
Version: 2.4.44
OS: RedHat 6.8
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (104.129.194.54)


The following code in contrib/ldapc++/src/LDAPControl.cpp needs to be
corrected:

LDAPCtrl::LDAPCtrl(const LDAPControl* ctrl){
    DEBUG(LDAP_DEBUG_CONSTRUCT,"LDAPCtrl::LDAPCtrl()" << endl);
    m_oid = string(ctrl->ldctl_oid);
    m_oid = ctrl->ldctl_iscritical ? true : false;
    m_oid = string(ctrl->ldctl_value.bv_val, ctrl->ldctl_value.bv_len );
}

to something like:

LDAPCtrl::LDAPCtrl(const LDAPControl* ctrl){
    DEBUG(LDAP_DEBUG_CONSTRUCT,"LDAPCtrl::LDAPCtrl()" << endl);
    m_oid = string(ctrl->ldctl_oid);
    m_isCritical = ctrl->ldctl_iscritical ? true : false;
    m_data = string(ctrl->ldctl_value.bv_val, ctrl->ldctl_value.bv_len );
    m_noData = ctrl->ldctl_value.bv_len ? false : true;
}

Comment 1 Quanah Gibson-Mount 2017-03-17 16:44:47 UTC
moved from Incoming to Software Bugs
Comment 2 Quanah Gibson-Mount 2017-09-06 23:47:08 UTC
changed notes
Comment 3 Quanah Gibson-Mount 2017-09-12 22:16:01 UTC
changed notes
Comment 4 Quanah Gibson-Mount 2017-10-06 17:56:22 UTC
changed notes
changed state Open to Test
Comment 5 Quanah Gibson-Mount 2017-10-11 19:43:48 UTC
changed notes
changed state Test to Release
Comment 6 OpenLDAP project 2018-03-22 19:25:28 UTC
fixed in master
fixed in RE24 (2.4.46)
Comment 7 Quanah Gibson-Mount 2018-03-22 19:25:28 UTC
changed notes
changed state Release to Closed