Issue 8578 - remove unused-variables in RE24 testing call (2.4.45)
Summary: remove unused-variables in RE24 testing call (2.4.45)
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-01 22:04 UTC by sca@andreasschulze.de
Modified: 2018-03-22 19:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description sca@andreasschulze.de 2017-02-01 22:04:16 UTC 
Full_Name: A. Schulze
Version: RE24 testing call (2.4.45)
OS: 
URL: ftp://ftp.openldap.org/incoming/andreas-schulze-20170201.patch
Submission from: (NULL) (2001:a60:f0b4:e502:758b:b0b2:3fc:f121)


the patch remove variables that are declared but unused.
Comment 1 sca@andreasschulze.de 2017-03-19 14:55:17 UTC 

Am 01.02.2017 um 23:04 schrieb openldap-its@OpenLDAP.org:
> If you need to provide additional information in regards to your
> issue report, you may do so by replying to this message.

the patch I provided 20170201 remove variables that are unused as long as
"configure --disable-rewrite" was given. Now I enabled rewrite and build fail :-/

server/slapd/syncrepl.c define variables named 'bv2' that are used if
rewrite is enabled and unused otherwise.

Maybe the definition of 'REWRITE_DN' ( server/slapd/syncrepl.c, ~line 1726 )
could declare bv2 as unused to avoid a compiler warning.

uploaded a new version: ftp://ftp.openldap.org/incoming/andreas-schulze-its8578-20170319.patch

Andreas
Comment 2 Quanah Gibson-Mount 2017-03-20 23:32:46 UTC 
moved from Incoming to Software Bugs
Comment 3 Quanah Gibson-Mount 2017-08-30 21:52:35 UTC 
changed notes
Comment 4 Quanah Gibson-Mount 2017-09-06 23:41:57 UTC 
changed notes
Comment 5 Quanah Gibson-Mount 2017-09-07 16:30:05 UTC 
changed notes
Comment 6 Quanah Gibson-Mount 2017-09-07 16:32:16 UTC 
--On Sunday, March 19, 2017 3:56 PM +0000 sca+openldap@andreasschulze.de 
wrote:

> uploaded a new version:
> ftp://ftp.openldap.org/incoming/andreas-schulze-its8578-20170319.patch

Hi Andreas,

For this to be included in the OpenLDAP project an IPR is necessary as 
documented at <http://www.openldap.org/devel/contributing.html>.

Thanks,
Quanah



--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
Comment 7 Quanah Gibson-Mount 2017-09-07 21:46:03 UTC 
changed notes
Comment 8 Quanah Gibson-Mount 2017-09-07 21:46:17 UTC 
changed notes
Comment 9 Quanah Gibson-Mount 2017-10-06 17:56:02 UTC 
changed notes
changed state Open to Test
Comment 10 Quanah Gibson-Mount 2017-10-11 19:42:12 UTC 
changed notes
changed state Test to Release
Comment 11 OpenLDAP project 2018-03-22 19:25:24 UTC 
fixed in master
fixed in RE24 (2.4.46)
Comment 12 Quanah Gibson-Mount 2018-03-22 19:25:24 UTC 
changed notes
changed state Release to Closed