Issue 8266 - empty ldapmodify refused with slapo-unique
Summary: empty ldapmodify refused with slapo-unique
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.42
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-08 15:33 UTC by Geert Hendrickx
Modified: 2017-06-01 22:08 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Geert Hendrickx 2015-10-08 15:33:27 UTC 
Full_Name: Geert Hendrickx
Version: 2.4.42
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (212.123.14.2)


When slapo-unique constraints are in effect, it seems empty updates are
no longer allowed:

$ ldapmodify -x -h localhost -D cn=Manager,dc=my-domain,dc=com -w secret
dn: cn=test1,dc=my-domain,dc=com
changetype: modify
A%A
modifying entry "cn=test1,dc=my-domain,dc=com"
ldap_modify: Invalid syntax (21)
        additional info: unique_modify() got null op.orm_modlist

Why is this considered invalid syntax?  Without slapo-unique constraint,
empty updates like these are accepted.
Comment 1 Quanah Gibson-Mount 2017-03-29 22:40:56 UTC 
moved from Incoming to Software Bugs
Comment 2 Ondřej Kuzník 2017-03-30 10:00:41 UTC 
On Thu, Oct 08, 2015 at 03:33:28PM +0000, geert@hendrickx.be wrote:
> When slapo-unique constraints are in effect, it seems empty updates are
> no longer allowed:
> 
> $ ldapmodify -x -h localhost -D cn=Manager,dc=my-domain,dc=com -w secret
> dn: cn=test1,dc=my-domain,dc=com
> changetype: modify
> modifying entry "cn=test1,dc=my-domain,dc=com"
> ldap_modify: Invalid syntax (21)
>         additional info: unique_modify() got null op.orm_modlist
> 
> Why is this considered invalid syntax?  Without slapo-unique constraint,
> empty updates like these are accepted.

Hi Geert,
the following patch should fix the issue.
ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170330a-ITS-8266-Allow-empty-mods.patch

Regards,

-- 
Ondřej Kuzník
Senior Software Engineer
Symas Corporation                       http://www.symas.com
Packaged, certified, and supported LDAP solutions powered by OpenLDAP
Comment 3 Geert Hendrickx 2017-03-30 11:18:10 UTC 
On Thu, Mar 30, 2017 at 12:00:41 +0200, Ondřej Kuzník wrote:
> Hi Geert,
> the following patch should fix the issue.
> ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20170330a-ITS-8266-Allow-empty-mods.patch


Hi Ondřej,

I verified your patch on 2.4.x and it works for me!

Thanks,


	Geert


-- 
geert.hendrickx.be :: geert@hendrickx.be :: PGP: 0xC4BB9E9F
This e-mail was composed using 100% recycled spam messages!
Comment 4 Quanah Gibson-Mount 2017-03-30 22:28:07 UTC 
changed notes
changed state Open to Test
Comment 5 Quanah Gibson-Mount 2017-04-06 19:05:53 UTC 
changed notes
changed state Test to Release
Comment 6 OpenLDAP project 2017-06-01 22:08:46 UTC 
Fixed in master
Fixed in RE25
Fixed in RE24 (2.4.45)
Comment 7 Quanah Gibson-Mount 2017-06-01 22:08:46 UTC 
changed notes
changed state Release to Closed