Issue 8057 - slapo-unique can be bypassed by anyone
Summary: slapo-unique can be bypassed by anyone
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-02-14 18:16 UTC by Ondřej Kuzník
Modified: 2015-09-02 20:43 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Ondřej Kuzník 2015-02-14 18:16:47 UTC
Full_Name: Ondrej Kuznik
Version: master
OS: 
URL: ftp://ftp.openldap.org/pub/Ondrej-Kuznik-20150214-ITS-8057-uniqueness-ACL.patch
Submission from: (NULL) (86.177.93.243)


This is caused by my fix for #6641. Since anyone can specify the manageDSAit
control on an operation it is trivial to bypass the uniqueness check as it
stands.

The above patch is derived from OpenLDAP Software. All of the
modifications to OpenLDAP Software represented in the above patches
were developed by Ondrej Kuznik <ondra@mistotebe.net>. I have not
assigned rights and/or interest in this work to any party. 

I, Ondrej Kuznik, hereby place the above modifications to OpenLDAP
Software (and only these modifications) into the public domain. Hence,
these modifications may be freely used and/or redistributed for any
purpose with or without attribution and/or other notice.
Comment 1 Howard Chu 2015-02-16 17:34:45 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 2 Quanah Gibson-Mount 2015-02-17 17:06:35 UTC
changed notes
changed state Test to Release
Comment 3 Quanah Gibson-Mount 2015-04-07 03:00:19 UTC
changed notes
changed state Release to Open
Comment 4 Quanah Gibson-Mount 2015-04-07 03:01:07 UTC
--On Saturday, February 14, 2015 6:16 PM +0000 ondra@mistotebe.net wrote:

> Full_Name: Ondrej Kuznik
> Version: master
> OS:
> URL:
> ftp://ftp.openldap.org/pub/Ondrej-Kuznik-20150214-ITS-8057-uniqueness-ACL
> .patch Submission from: (NULL) (86.177.93.243)
>
>
> This is caused by my fix for #6641. Since anyone can specify the
> manageDSAit control on an operation it is trivial to bypass the
> uniqueness check as it stands.

This "fix" causes OpenLDAP to crash during replication:

<http://fpaste.org/207817/70741142/>

--Quanah



--

Quanah Gibson-Mount
Platform Architect
Zimbra, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 5 Quanah Gibson-Mount 2015-04-07 03:03:15 UTC
--On Tuesday, April 07, 2015 4:01 AM +0000 quanah@zimbra.com wrote:

> --On Saturday, February 14, 2015 6:16 PM +0000 ondra@mistotebe.net wrote:
>
>> Full_Name: Ondrej Kuznik
>> Version: master
>> OS:
>> URL:
>> ftp://ftp.openldap.org/pub/Ondrej-Kuznik-20150214-ITS-8057-uniqueness-ACL
>> .patch Submission from: (NULL) (86.177.93.243)
>>
>>
>> This is caused by my fix for #6641. Since anyone can specify the
>> manageDSAit control on an operation it is trivial to bypass the
>> uniqueness check as it stands.
>
> This "fix" causes OpenLDAP to crash during replication:
>
> <http://fpaste.org/207817/70741142/>

Also crashes when using ldapmodify -M or ldapmodrdn -M

--Quanah


--

Quanah Gibson-Mount
Platform Architect
Zimbra, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 6 Ondřej Kuzník 2015-04-08 19:14:32 UTC
A fix for that is at
ftp://ftp.openldap.org/incoming/Ondrej-Kuznik-20150408-ITS-8057-uniqueness-fix.tgz

The above patch is derived from OpenLDAP Software. All of the
modifications to OpenLDAP Software represented in the above patches were
developed by Ondrej Kuznik <ondra@mistotebe.net>. I have not assigned
rights and/or interest in this work to any party. 

I, Ondrej Kuznik, hereby place the above modifications to OpenLDAP
Software (and only these modifications) into the public domain. Hence,
these modifications may be freely used and/or redistributed for any
purpose with or without attribution and/or other notice

Comment 7 OpenLDAP project 2015-09-02 20:43:51 UTC
Breaks replication
Fixed in master, RE25, RE24 (2.4.41)
Comment 8 Ryan Tandy 2015-09-02 20:43:51 UTC
changed notes
changed state Open to Closed