Issue 7976 - Bug in syncrepl.c short-circuits overlay stack cleanup
Summary: Bug in syncrepl.c short-circuits overlay stack cleanup
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.32
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-30 00:12 UTC by mwarren@symas.com
Modified: 2015-07-02 17:45 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description mwarren@symas.com 2014-10-30 00:12:30 UTC
Full_Name: Mark Warren
Version: 2.4.32
OS: RHEL
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (72.35.133.119)



via Howard:

"The bug is syncrepl.c lines 2036-2038. Returning LDAP_SUCCESS here
short-circuits the overlay stack and *doesn't* call the cleanup handlers."

Note: The line numbers are skewed as we're working with an older version.


Best Regards,
Mark
Comment 1 Howard Chu 2014-10-30 15:02:08 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 2 Howard Chu 2014-10-31 12:26:25 UTC
mwarren@symas.com wrote:
> Full_Name: Mark Warren
> Version: 2.4.32
> OS: RHEL
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (72.35.133.119)
>
>
>
> via Howard:
>
> "The bug is syncrepl.c lines 2036-2038. Returning LDAP_SUCCESS here
> short-circuits the overlay stack and *doesn't* call the cleanup handlers."
>
> Note: The line numbers are skewed as we're working with an older version.

On further analysis, it appears the patch is not needed in current code. It 
seems the problem (an incoming mod whose entryCSN matches the existing 
entryCSN of the target entry) was already avoided by the patch for ITS#7427, 
which was released in 2.4.34.

Definitely unable to reproduce the issue in 2.4.40.
-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 3 Quanah Gibson-Mount 2014-12-11 00:19:00 UTC
changed notes
changed state Test to Release
Comment 4 OpenLDAP project 2015-07-02 17:45:45 UTC
fixed in master
fixed in RE25
fixed in RE24
Comment 5 Quanah Gibson-Mount 2015-07-02 17:45:45 UTC
changed notes
changed state Release to Closed