Issue 7959 - [LMDB] check fstat return value.
Summary: [LMDB] check fstat return value.
Status: VERIFIED FIXED
Alias: None
Product: LMDB
Classification: Unclassified
Component: liblmdb (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-03 19:50 UTC by jcd@tribudubois.net
Modified: 2020-03-12 15:55 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description jcd@tribudubois.net 2014-10-03 19:50:51 UTC 
Full_Name: Jean-Christophe Dubois
Version: 2.4.40
OS: Linux
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (78.235.240.156)


in mdb_env_copyfd0() the function fstat() is called but the return value is not
checked.

There is no reason not to check if the system call is successful as the result
is used just after.

Patch available at URL below: 

https://github.com/jcduboi2F2Flmdb/commit/fda581a6dd2e56fac4cab2aa872753f6f0993680

JC
Comment 1 Howard Chu 2014-10-03 20:12:22 UTC 
jcd@tribudubois.net wrote:
> Full_Name: Jean-Christophe Dubois
> Version: 2.4.40
> OS: Linux
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (78.235.240.156)
>
>
> in mdb_env_copyfd0() the function fstat() is called but the return value is not
> checked.
>
> There is no reason not to check if the system call is successful as the result
> is used just after.
>
> Patch available at URL below:
>
> https://github.com/jcduboi2F2Flmdb/commit/fda581a6dd2e56fac4cab2aa872753f6f0993680

Thanks, fixed in mdb.master.

Please read http://www.openldap.org/devel/contributing.html re: submission 
formats.
>
> JC
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
Comment 2 OpenLDAP project 2014-10-03 20:13:16 UTC 
fixed in mdb.master
Comment 3 Howard Chu 2014-10-03 20:13:16 UTC 
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 4 Quanah Gibson-Mount 2014-12-11 01:05:42 UTC 
changed state Test to Release
Comment 5 Quanah Gibson-Mount 2015-07-02 17:45:11 UTC 
changed state Release to Closed