Viewing Software Bugs/7505
Full headers

Major security issue: yes  no

Notes:
fixed in mdb.master fixed in master fixed in RE24
Notification:

Date: Sun, 27 Jan 2013 18:01:52 +0000
From: hyc@openldap.org
To: openldap-its@OpenLDAP.org
Subject: liblmdb can fail with MDB_PAGE_FULL on a delete

Full_Name: Howard Chu
Version: RE24/master
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (78.155.233.73)
Submitted by: hyc


This is the last remaining FIXME in liblmdb/mdb.c...

mdb_rebalance() is always called after a delete operation. If the tree needs
balancing and it needs to move a node from one page to its sibling, the parent
page's separator keys will need updating. If the new separator key is larger
than the old one, it may not fit into the parent page, and mdb_update_key() will
return MDB_PAGE_FULL.

Instead of giving up, mdb_update_key() should invoke mdb_page_split() to make
room for the new key.

Followup 1

From: Sung Ruo <sruo@vmware.com>
Subject: Re: (ITS#7505) liblmdb can fail with MDB_PAGE_FULL on a delete
Date: Tue, 29 Jan 2013 09:36:30 -0800
Cc: hyc@openldap.org
To: openldap-its@openldap.org

Hi Howard:
Our test program has been running for about a day now and the fix is holding up
good still.
We used to reproduce this in about 1~2 days.  So I'll let it runs for another
day.

Will update again sometime tomorrow.

Thanks.

--Sung

Followup 2

Date: Tue, 29 Jan 2013 10:53:23 -0800
From: Quanah Gibson-Mount <quanah@zimbra.com>
To: sruo@vmware.com, openldap-its@openldap.org
Subject: Re: (ITS#7505) liblmdb can fail with MDB_PAGE_FULL on a delete

--On Tuesday, January 29, 2013 5:36 PM +0000 sruo@vmware.com wrote:

> Hi Howard:
> Our test program has been running for about a day now and the fix is
> holding up good still. We used to reproduce this in about 1~2 days.  So
> I'll let it runs for another day.
>
> Will update again sometime tomorrow.

Hi Sung,

I don't know if you saw, but Howard made a tweak to the 7505 commit 
yesterday.  If you could try current mdb.master from git, that would be 
helpful.  It also has a commit addressing ITS#7511.

Thanks,
Quanah

--

Quanah Gibson-Mount
Sr. Member of Technical Staff
Zimbra, Inc
A Division of VMware, Inc.
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Followup 3

Date: Tue, 29 Jan 2013 18:30:22 -0800
From: Howard Chu <hyc@symas.com>
To: Sung Ruo <sruo@vmware.com>, openldap-its@openldap.org
Subject: Re: (ITS#7505) liblmdb can fail with MDB_PAGE_FULL on a delete

Sung Ruo wrote:
> Hi Howard:
> Our test program has been running for about a day now and the fix is
holding up good still.
> We used to reproduce this in about 1~2 days.  So I'll let it runs for
another day.
>
> Will update again sometime tomorrow.

That's good news, thanks for the followup.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Followup 4

From: Sung Ruo <sruo@vmware.com>
Subject: Re: (ITS#7505) liblmdb can fail with MDB_PAGE_FULL on a delete
Date: Thu, 31 Jan 2013 12:13:40 -0800
Cc: hyc@openldap.org
To: openldap-its@openldap.org

Hi Howard:
Our test finished last night and the news is GOOD.
We did not see MDB_PAGE_FULL error using patch 7505.  At the same time, the
other test ended with MDB_PAGE_FULL running older drop.

Thank you very much for the fix.

--Sung