Viewing Software Bugs/7291
Full headers

Major security issue: yes  no

Notes:
fixed in master fixed in RE24
Notification:

Date: Wed, 06 Jun 2012 12:58:30 +0000
From: jvcelak@redhat.com
To: openldap-its@OpenLDAP.org
Subject: [PATCH] MozNSS: read pin from file file can cause infinite loop

Full_Name: Jan Vcelak
Version: git master
OS: Linux
URL: ftp://ftp.openldap.org/incoming/jvcelak-20120606-moznss-read-pin-from-file-infinite-loop.patch
Submission from: (NULL) (209.132.186.34)


The buffer allocated for reading password (pin) file has to be initialized with
zeros, or we need to append zero at the end of the file. Otherwise we might read
initialized memory and consider it to be a password. In this situation, all
incoming TLS connections can hang.

Attached patch fixes this bug.

The attached file is derived from OpenLDAP Software. All of the modifications to
OpenLDAP Software represented in the following patch(es) were developed by Red
Hat. Red Hat has not assigned rights and/or interest in this work to any party.
I, Jan Vcelak am authorized by Red Hat, my employer, to release this work under
the following terms. 

Red Hat hereby place the following modifications to OpenLDAP Software (and only
these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution
and/or other notice. 

Followup 1

From: Jan =?utf-8?B?VsSNZWzDoWs=?= <jvcelak@redhat.com>
To: openldap-its@openldap.org
Subject: Re: (ITS#7291) [PATCH] MozNSS: read pin from file file can cause infinite loop
Date: Wed, 06 Jun 2012 18:25:48 +0200

> might read initialized memory and consider it to be a password. In this

sorry, typo: uninitialized

Followup 2

Date: Thu, 07 Jun 2012 05:07:04 -0700
From: Howard Chu <hyc@symas.com>
To: jvcelak@redhat.com
CC: openldap-its@openldap.org
Subject: Re: (ITS#7291) [PATCH] MozNSS: read pin from file file can cause
 infinite loop

jvcelak@redhat.com wrote:
>> might read initialized memory and consider it to be a password. In this
>
> sorry, typo: uninitialized

Thanks for the patch, committed to master.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/