Issue 6937 - Remove --enable-proctitle and strdup(optarg)
Summary: Remove --enable-proctitle and strdup(optarg)
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: 2.5.0
Assignee: Quanah Gibson-Mount
URL:
Keywords:
: 9258 (view as issue list)
Depends on:
Blocks:
 
Reported: 2011-05-10 17:21 UTC by Hallvard Furuseth
Modified: 2020-10-14 21:03 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Hallvard Furuseth 2011-05-10 17:21:31 UTC 
Full_Name: Hallvard B Furuseth
Version: master, 2.4.25
OS: 
URL: 
Submission from: (NULL) (129.240.6.233)
Submitted by: hallvard


"configure --enable-proctitle" uses setproctitle/proctitle(), which
we no longer use.  So I'll remove that and liblutil/setproctitle.c.
That's the default implementation, which works by overwriting argv[].

That's got to be why we have strdup(optarg) instead of just optarg all
over the place.  So we can drop the strdup()s, which gets rid some
admittedly unimportant memory leak reports from program checkers.
Comment 1 Quanah Gibson-Mount 2017-04-12 15:13:51 UTC 
moved from Incoming to Software Bugs
Comment 3 Quanah Gibson-Mount 2020-04-16 14:45:18 UTC 
Commits: 
  • a97eed06 
by Quanah Gibson-Mount at 2020-04-15T19:32:28+00:00 
ITS#6937 - Remove unused proctitle bits
Comment 4 Quanah Gibson-Mount 2020-05-11 15:02:20 UTC 
commit fc8a7b25b8b5da95ce11743cc2386b257af26923
Author: Ryan Tandy <ryan@nardis.ca>
Date:   Sun May 10 08:47:54 2020 -0700

    ITS#9258 More for ITS#6937, don't free user/group
Comment 5 Quanah Gibson-Mount 2020-05-11 15:02:35 UTC 
*** Issue 9258 has been marked as a duplicate of this issue. ***