Issue 6490 - dds and pcache overlays not checking NULL value
Summary: dds and pcache overlays not checking NULL value
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 17:50 UTC by etienne.bagnoud@irovision.ch
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description etienne.bagnoud@irovision.ch 2010-03-10 17:50:12 UTC
Full_Name: Etienne Bagnoud
Version: 2.4.11 and HEAD
OS: Debian GNU/Linux 5.0.4
URL: http://www.tchetch.net/code/openldap/
Submission from: (NULL) (153.109.35.2)


When sending a refresh request (RFC 2589) with an empty DN, the server
segfault.
This did work on default Debian installed version (slapd 2.4.11) as well as on
the actual (today) version in HEAD.

The actual return value returned by 'select_backend' is not checked for NULL
value and passed directly to 'SLAP_DYNAMIC' macro.

While digging through the code to find how others overlays where doing, if found
that pcache has the same behavior. I can't test for that overlay (if the bug is
corrected or not), but I suppose it's the same.

So here are two patches to correct dds overlay and pcache overlay :
- http://www.tchetch.net/code/openldap/servers-slapd-overlays-dds.patch
- http://www.tchetch.net/code/openldap/servers-slapd-overlays-pcache.patch

I'm not used to dig into openldap code (in fact, this is the first time), so I
hope it's ok.

Etienne.
Comment 1 ando@openldap.org 2010-03-22 13:49:26 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Bugs
Comment 2 ando@openldap.org 2010-03-22 20:49:14 UTC
Fixed (slighlty differently) in HEAD.  Please test.  Thanks, p.

Comment 3 etienne.bagnoud@irovision.ch 2010-03-29 10:16:10 UTC
I've tested dds and it seems fine to me. Thanks.
Comment 4 Quanah Gibson-Mount 2010-04-15 13:00:13 UTC
changed notes
changed state Test to Release
Comment 5 Quanah Gibson-Mount 2010-04-29 08:34:37 UTC
changed notes
changed state Release to Closed
Comment 6 OpenLDAP project 2014-08-01 21:04:28 UTC
fixed in HEAD
fixed in RE24