Full_Name: Emmanuel Dreyfus Version: HEAD OS: NetBSD URL: ftp://ftp.openldap.org/incoming/manu-180729.patch Submission from: (NULL) (213.41.141.172) contrib/slapd-modules/smbk5pwd uses hdb_generate_key_set_password() from Heimdal, which was shortly turned from a 5 arguments function to a 7 arguments function before the prototype change was rolled back to address API incompatibility. Unfortunately, the 7 arguments hdb_generate_key_set_password() made it into released NetBSD 8.0, causing a build break in contrib/slapd-modules/smbk5pwd. The attached patch adds a configure test for 7 arguments prototype so that contrib/slapd-modules/smbk5pwd build again on NetBSD 8.0, and other OS that would include the 7 arguments hdb_generate_key_set_password().
On Mon, Jul 30, 2018 at 01:44:31AM +0000, manu@netbsd.org wrote: >--- a/configure.in >+++ b/configure.in >@@ -1312,6 +1312,14 @@ if test $ol_enable_lmpasswd != no; then > AC_DEFINE(SLAPD_LMHASH, 1, [define to support LAN Manager passwords]) > fi > >+dnl ---------------------------------------------------------------- >+dnl Threads? Copypasta from the paragraph below? Looks off topic for this hunk.
Ryan Tandy <ryan@nardis.ca> wrote: > Copypasta from the paragraph below? Looks off topic for this hunk. I just updated the patch. -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz manu@netbsd.org
Heimdal fixed on their end
changed notes changed state Open to Closed