Issue 8882 - Empty Directory String Overlay
Summary: Empty Directory String Overlay
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.46
Hardware: All All
: --- normal
Target Milestone: 2.5.13
Assignee: Ondřej Kuzník
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-23 09:23 UTC by tamim.ziai@daasi.de
Modified: 2022-07-14 21:18 UTC (History)
1 user (show)

See Also:


Attachments
source code for empty-directory-string overlay (4.18 KB, application/x-gzip)
2022-04-27 15:14 UTC, Quanah Gibson-Mount
Details

Note You need to log in before you can comment on or make changes to this issue.
Description tamim.ziai@daasi.de 2018-07-23 09:23:57 UTC
Full_Name: Tamim Ziai
Version: 2.4.46
OS: linux
URL: https://storage.daasi.de/s/piQ3WQxgYDSDkKZ
Submission from: (NULL) (37.24.13.226)


As requested by Matthew Hardin I'm submitting the overlay "Empty Directory
String" (eds) as contrib software. It can be downloaded form the URL below.
Comment 1 Howard Chu 2018-07-23 15:59:37 UTC
tamim.ziai@daasi.de wrote:
> Full_Name: Tamim Ziai
> Version: 2.4.46
> OS: linux
> URL: https://storage.daasi.de/s/piQ3WQxgYDSDkKZ
> Submission from: (NULL) (37.24.13.226)
> 
> 
> As requested by Matthew Hardin I'm submitting the overlay "Empty Directory
> String" (eds) as contrib software. It can be downloaded form the URL below.

Thanks Tamim, but please also provide an IPR notice as documented in 
http://www.openldap.org/devel/contributing.html#submitting

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 2 tamim.ziai@daasi.de 2018-07-24 08:09:36 UTC
I miserably lost the fight against your ticket system! No way to modify
anything as guest user and no way to create/register a new user as
described in the Jitterbug help pages. Could you please tell me how I
can modify an issue or where I can find a description how to proceed?

Thanks,
Tamim


On 23.07.2018 17:59, Howard Chu wrote:
> tamim.ziai@daasi.de wrote:
>> Full_Name: Tamim Ziai
>> Version: 2.4.46
>> OS: linux
>> URL: https://storage.daasi.de/s/piQ3WQxgYDSDkKZ
>> Submission from: (NULL) (37.24.13.226)
>>
>>
>> As requested by Matthew Hardin I'm submitting the overlay "Empty
>> Directory
>> String" (eds) as contrib software. It can be downloaded form the URL
>> below.
>
> Thanks Tamim, but please also provide an IPR notice as documented in
> http://www.openldap.org/devel/contributing.html#submitting
>


Comment 3 Michael Ströder 2018-07-24 08:49:11 UTC
On 07/24/2018 10:09 AM, tamim.ziai@daasi.de wrote:
> I miserably lost the fight against your ticket system! No way to modify
> anything as guest user and no way to create/register a new user as
> described in the Jitterbug help pages. Could you please tell me how I
> can modify an issue or where I can find a description how to proceed?

You can only add new messages to tickets,
mainly by a simple follow-up e-mail preserving the e-mail subject.

 From my understanding this is also the accepted way to add an IPR 
notice after initial submission.

Ciao, Michael.

Comment 4 tamim.ziai@daasi.de 2018-07-24 09:16:57 UTC
The eds overlay eliminates empty values of type directory string
(OID 1.3.6.1.4.1.1466.115.121.1.15) from the list of the values in the
following manner:

    - add: All empty attribute values will be removed before the add request
      is executed
    - mod-replace: A replace with empty values will be modified to a replace
      without values. As result the attribute will be deleted
    - mod-add: All empty attribute values will be removed before the mod-add
      request is executed
    - mod-delete: All empty attribute values will be removed before the
      mod-delete request is executed
   


On 23.07.2018 17:59, Howard Chu wrote:
> tamim.ziai@daasi.de wrote:
>> Full_Name: Tamim Ziai
>> Version: 2.4.46
>> OS: linux
>> URL: https://storage.daasi.de/s/piQ3WQxgYDSDkKZ
>> Submission from: (NULL) (37.24.13.226)
>>
>>
>> As requested by Matthew Hardin I'm submitting the overlay "Empty
>> Directory
>> String" (eds) as contrib software. It can be downloaded form the URL
>> below.
>
> Thanks Tamim, but please also provide an IPR notice as documented in
> http://www.openldap.org/devel/contributing.html#submitting
>


Comment 5 Michael Ströder 2018-07-24 11:25:57 UTC
On 07/24/2018 11:17 AM, tamim.ziai@daasi.de wrote:
> The eds overlay eliminates empty values of type directory string
> (OID 1.3.6.1.4.1.1466.115.121.1.15) from the list of the values in the
> following manner:
> 
>   Â
   ^^^^^
(Jitterbug has big deficiencies processing Unicode chars in e-mails. 
I've reformatted what came through.)

Sorry, for nit-picking a bit:

>  - add: All empty attribute values will be removed before the add request
>    is executed

What happens if after removing all empty values there are no attributes 
at all anymore? Is the add operation still processed or just internally 
abandoned/canceled?

>  - mod-replace: A replace with empty values will be modified to a replace
>    without values. As result the attribute will be deleted

Maybe it's just a wording issue. But I understand "As result the 
attribute will be deleted" that the attribute in the target entry is 
removed.

What happens exactly if all empty values are removed from a MOD_REPLACE 
attribute list? Is the MOD_REPLACE for this attribute removed from the 
modify operation? This would mean no change to the target entry.
Or do you remove the attribute in the entry?

>  - mod-add: All empty attribute values will be removed before the mod-add
>    request is executed

"mod-add request" is a bit blurry:
What happens exactly if all empty values are removed from a MOD_ADD 
attribute list? Is the MOD_ADD for this attribute removed from the 
modify operation?

>  - mod-delete: All empty attribute values will be removed before the
>    mod-delete request is executed

Again: What happens exactly if all empty values are removed from a 
MOD_DEL attribute list?

Is the MOD_DEL for this attribute removed from the modify operation?

Or is the MOD_DEL processed with empty attribute list?
IMO this would be harmful because it would alter the processing in a way 
probably not intended by the client.

I vaguely remember that this is meant to deal with broken clients and 
I'm concerned that following the README all clients are affected by this 
special processing. Wouldn't it make sense to limit the functionality to 
a defined group of broken LDAP clients (by group membership, peer 
address check or similar)?

Ciao, Michael.

Comment 6 Howard Chu 2018-07-25 15:59:47 UTC
hyc@symas.com wrote:
> tamim.ziai@daasi.de wrote:
>> Full_Name: Tamim Ziai
>> Version: 2.4.46
>> OS: linux
>> URL: https://storage.daasi.de/s/piQ3WQxgYDSDkKZ
>> Submission from: (NULL) (37.24.13.226)
>>
>>
>> As requested by Matthew Hardin I'm submitting the overlay "Empty Directory
>> String" (eds) as contrib software. It can be downloaded form the URL below.
> 
> Thanks Tamim, but please also provide an IPR notice as documented in
> http://www.openldap.org/devel/contributing.html#submitting
> 
Still waiting for the IPR notice. We cannot add it to the OpenLDAP git repo 
without it.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 7 Quanah Gibson-Mount 2020-03-23 20:34:46 UTC
No IPR
Patch was not uploaded to the FTP server as per documented procedures for the time, and is not available at the listed link.

Suspending until author can provide patch and necessary IPR notice.
Comment 8 Quanah Gibson-Mount 2021-02-15 17:23:00 UTC
Need IPR
Comment 9 tamim.ziai@daasi.de 2021-05-20 12:10:56 UTC
The attached file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by DAASI International. DAASI International has not assigned rights and/or interest in this work to any party. I, Tamim Ziai is authorized by DAASI International to release this work under the following terms.

The attached modifications to OpenLDAP Software are subject to the following notice:

Copyright 2019 DAASI International
Redistribution and use in source and binary forms, with or without modification, are permitted only as authorized by the OpenLDAP Public License.
Comment 10 Matthew Hardin 2021-05-21 20:04:58 UTC
It appears that the source code for the module is no longer on the FTP server. Would someone from daasi please upload it and mark the correct URL in the comment?

Thanks,
Comment 12 Quanah Gibson-Mount 2022-04-27 15:14:01 UTC
Created attachment 896 [details]
source code for empty-directory-string overlay
Comment 13 Quanah Gibson-Mount 2022-04-27 15:14:38 UTC
Tamim provided me the source code previously referenced, now attached to the ticket.
Comment 14 Quanah Gibson-Mount 2022-04-28 15:39:22 UTC
Ship in contrib for 2.5.13+
Comment 16 Quanah Gibson-Mount 2022-05-12 15:49:33 UTC
head:

  • d2057745 
by Ondřej Kuzník at 2022-05-10T14:24:49+00:00 
ITS#8882 Add slapo-emptyds to contrib

RE26:

  • edc67c6d 
by Ondřej Kuzník at 2022-05-12T15:45:18+00:00 
ITS#8882 Add slapo-emptyds to contrib


RE25:

  • 6c9cb00f 
by Ondřej Kuzník at 2022-05-12T15:46:13+00:00 
ITS#8882 Add slapo-emptyds to contrib