Issue 8837 - fix pw-pbkdf2 manpage name to get it installed
Summary: fix pw-pbkdf2 manpage name to get it installed
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.46
Hardware: All All
: --- normal
Target Milestone: 2.5.0
Assignee: Quanah Gibson-Mount
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-13 17:30 UTC by peter@adpm.de
Modified: 2020-10-14 21:15 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description peter@adpm.de 2018-04-13 17:30:24 UTC 
Full_Name: Peter Marschall
Version: 2.4.46
OS: Linux
URL: 
Submission from: (NULL) (217.249.216.145)


Hi,

although pw-pbkdf2 is not an overlay but a mere module, the existing man page
for this module is named slapo-pw-pbkdf2.5.
On the other hand, pw-pbkdf2's Makefile correctly mentions the manual page as
slapd-pw-pbkdf2.5.
Together this results in pw-pbpkdf2's manual page not getting installed despite
being available.

To fix the issue, please rename
  contrib/slapd-modules/passwd/pbkdf2/slapo-pw-pbkdf2.5
to
  contrib/slapd-modules/passwd/pbkdf2/slapd-pw-pbkdf2.5

Thanks in advance
Peter
Comment 1 Quanah Gibson-Mount 2020-03-26 18:00:33 UTC 
Actually, since it is an overlay, the slapo prefix is correct (o=overlay) and the slapd prefix is incorrect (used for backends).
Comment 2 Ryan Tandy 2020-03-26 18:13:27 UTC 
(In reply to Quanah Gibson-Mount from comment #1)
> Actually, since it is an overlay, the slapo prefix is correct (o=overlay)
> and the slapd prefix is incorrect (used for backends).

I don't think calling a password module an "overlay" is accurate.

I agree with Peter, it should be called slapd-pw-pbkdf2.5 (and slapo-totp.5 to slapd-pw-totp.5 while we're at it). Or introduce a new "slapp-" convention if it must be distinguished from backends, but that seems overkill...
Comment 3 Quanah Gibson-Mount 2020-03-26 19:06:53 UTC 
(In reply to Ryan Tandy from comment #2)
> (In reply to Quanah Gibson-Mount from comment #1)
> > Actually, since it is an overlay, the slapo prefix is correct (o=overlay)
> > and the slapd prefix is incorrect (used for backends).
> 
> I don't think calling a password module an "overlay" is accurate.
> 
> I agree with Peter, it should be called slapd-pw-pbkdf2.5 (and slapo-totp.5
> to slapd-pw-totp.5 while we're at it). Or introduce a new "slapp-"
> convention if it must be distinguished from backends, but that seems
> overkill...

Pretty sure we actually discussed slapm- for module in the past, actually.
Comment 4 Howard Chu 2020-03-27 03:58:34 UTC 
(In reply to Ryan Tandy from comment #2)
> (In reply to Quanah Gibson-Mount from comment #1)
> > Actually, since it is an overlay, the slapo prefix is correct (o=overlay)
> > and the slapd prefix is incorrect (used for backends).
> 
> I don't think calling a password module an "overlay" is accurate.
> 
> I agree with Peter, it should be called slapd-pw-pbkdf2.5 (and slapo-totp.5
> to slapd-pw-totp.5 while we're at it). Or introduce a new "slapp-"
> convention if it must be distinguished from backends, but that seems
> overkill...

The totp module is actually an overlay. There is nothing to rename there.
Comment 5 Ryan Tandy 2020-03-27 05:29:48 UTC 
(In reply to Howard Chu from comment #4)
> The totp module is actually an overlay. There is nothing to rename there.

OK. Sorry, that was an assumption based on it being under passwd/. Thanks for the correction.
Comment 6 Ryan Tandy 2020-03-29 17:06:59 UTC 
Fixed in d86caacaa1772e0c9a4c856558e1c5d538c5b549
Comment 7 Quanah Gibson-Mount 2020-03-30 19:25:00 UTC 
I was really planning to get this fixed as part of 8628, which covers a bunch of modules with the same problem.. ;)