Issue 8829 - Right shift build warning VS2017 mdb.c
Summary: Right shift build warning VS2017 mdb.c
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-01 05:46 UTC by robin.rowe@cinepaint.org
Modified: 2018-09-10 18:08 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description robin.rowe@cinepaint.org 2018-04-01 05:46:03 UTC
Full_Name: Robin Rowe
Version: git
OS: Windows 10
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (23.242.20.216)


Warning from VS2017:

mdb.c(7455): warning C4333: '>>': right shift by too large amount, data loss

7455:    SETDSZ(node, nsize);

960: #define SETDSZ(node,size)	do { \
961:    (node)->mn_lo = (size) & 0xffff; (node)->mn_hi = (size) >> 16;} while(0)
Comment 1 Howard Chu 2018-04-01 09:52:03 UTC
robin.rowe@cinepaint.org wrote:
> Full_Name: Robin Rowe
> Version: git
> OS: Windows 10
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (23.242.20.216)
> 
> 
> Warning from VS2017:
> 
> mdb.c(7455): warning C4333: '>>': right shift by too large amount, data loss
> 
> 7455:    SETDSZ(node, nsize);
> 
> 960: #define SETDSZ(node,size)	do { \
> 961:    (node)->mn_lo = (size) & 0xffff; (node)->mn_hi = (size) >> 16;} while(0)
> 
> 
Intentional and irrelevant. Closing this ITS.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 2 Howard Chu 2018-09-10 18:08:50 UTC
changed state Open to Closed