Issue 8780 - Plug a socket leak in ldap_new_connection made by unsuccessful connection attempts
Summary: Plug a socket leak in ldap_new_connection made by unsuccessful connection att...
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-30 14:02 UTC by hguo@suse.com
Modified: 2019-04-19 15:43 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hguo@suse.com 2017-11-30 14:02:28 UTC
Full_Name: Houzuo Guo
Version: master
OS: 
URL: ftp://ftp.openldap.org/incoming/houzuo-guo-171130.patch
Submission from: (NULL) (195.135.221.2)


In case that ldap connection is attempted on failed URLs prior to establishing a
successful connection, the failed connection sockets are never freed. This patch
plugs the socket descriptor leak.
Comment 1 Quanah Gibson-Mount 2019-04-17 22:33:33 UTC
--On Thursday, November 30, 2017 2:02 PM +0000 hguo@suse.com wrote:

> Full_Name: Houzuo Guo
> Version: master
> OS:
> URL: ftp://ftp.openldap.org/incoming/houzuo-guo-171130.patch
> Submission from: (NULL) (195.135.221.2)
>
>
> In case that ldap connection is attempted on failed URLs prior to
> establishing a successful connection, the failed connection sockets are
> never freed. This patch plugs the socket descriptor leak.

Hello,

Thank you for the report!  Please reply with an IPR statement as documented 
at

<https://www.openldap.org/devel/contributing.html#notice>

if you wish your patch to be reviewed for inclusion in the OpenLDAP 
software.

Regards,
Quanah


--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>


Comment 2 Quanah Gibson-Mount 2019-04-17 22:44:41 UTC
--On Wednesday, April 17, 2019 11:33 PM +0000 quanah@symas.com wrote:

Hello,

Sending this to your @suse.com email bounced.  Please see below and update 
with an IPR as requested.  Thanks!

Regards,
Quanah

> --On Thursday, November 30, 2017 2:02 PM +0000 hguo@suse.com wrote:
>
>> Full_Name: Houzuo Guo
>> Version: master
>> OS:
>> URL: ftp://ftp.openldap.org/incoming/houzuo-guo-171130.patch
>> Submission from: (NULL) (195.135.221.2)
>>
>>
>> In case that ldap connection is attempted on failed URLs prior to
>> establishing a successful connection, the failed connection sockets are
>> never freed. This patch plugs the socket descriptor leak.
>
> Hello,
>
> Thank you for the report!  Please reply with an IPR statement as
> documented  at
>
> <https://www.openldap.org/devel/contributing.html#notice>
>
> if you wish your patch to be reviewed for inclusion in the OpenLDAP
> software.
>
> Regards,
> Quanah
>
>
> --
>
> Quanah Gibson-Mount
> Product Architect
> Symas Corporation
> Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
> <http://www.symas.com>
>
>
>
>



--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>


Comment 3 Michael Ströder 2019-04-18 12:12:27 UTC
On 4/18/19 12:44 AM, quanah@symas.com wrote:
> Sending this to your @suse.com email bounced.  Please see below and update
> with an IPR as requested.  Thanks!

Since quite a while Howard Guo does not work for SUSE anymore.

Do you need Howard's IPR notice or one from SUSE?

Ciao, Michael.

Comment 4 Houzuo Guo 2019-04-18 12:25:44 UTC
Hello Quanah.

Sorry - my passion for Linux remains but I am no longer involved in OS
foundation development at SUSE.

Have a lovely Easter holiday!

Kind regards,
Howard

On Thu, 18 Apr 2019 at 01:44, Quanah Gibson-Mount <quanah@symas.com> wrote:

> --On Wednesday, April 17, 2019 11:33 PM +0000 quanah@symas.com wrote:
>
> Hello,
>
> Sending this to your @suse.com email bounced.  Please see below and
> update
> with an IPR as requested.  Thanks!
>
> Regards,
> Quanah
>
> > --On Thursday, November 30, 2017 2:02 PM +0000 hguo@suse.com wrote:
> >
> >> Full_Name: Houzuo Guo
> >> Version: master
> >> OS:
> >> URL: ftp://ftp.openldap.org/incoming/houzuo-guo-171130.patch
> >> Submission from: (NULL) (195.135.221.2)
> >>
> >>
> >> In case that ldap connection is attempted on failed URLs prior to
> >> establishing a successful connection, the failed connection sockets are
> >> never freed. This patch plugs the socket descriptor leak.
> >
> > Hello,
> >
> > Thank you for the report!  Please reply with an IPR statement as
> > documented  at
> >
> > <https://www.openldap.org/devel/contributing.html#notice>
> >
> > if you wish your patch to be reviewed for inclusion in the OpenLDAP
> > software.
> >
> > Regards,
> > Quanah
> >
> >
> > --
> >
> > Quanah Gibson-Mount
> > Product Architect
> > Symas Corporation
> > Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
> > <http://www.symas.com>
> >
> >
> >
> >
>
>
>
> --
>
> Quanah Gibson-Mount
> Product Architect
> Symas Corporation
> Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
> <http://www.symas.com>
>
>
Comment 5 Quanah Gibson-Mount 2019-04-18 15:59:34 UTC
--On Thursday, April 18, 2019 1:12 PM +0000 michael@stroeder.com wrote:

> On 4/18/19 12:44 AM, quanah@symas.com wrote:
>> Sending this to your @suse.com email bounced.  Please see below and
>> update with an IPR as requested.  Thanks!
>
> Since quite a while Howard Guo does not work for SUSE anymore.
>
> Do you need Howard's IPR notice or one from SUSE?

Hi Michael & Howard,

The problem is that while the ITS was filed from an @suse address, the 
patch is from Howard's @gmail address.  At this point, we would need an IPR 
from both SuSE and Howard.

Thanks!

Regards,
Quanah


--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>


Comment 6 Michael Ströder 2019-04-18 15:59:38 UTC
I considered contacting current SUSE maintainers of package openldap2.

In preparation to that I tried to find out which bug caused this patch 
to be developed.

AFAIK the patch is not applied to the package anymore:
https://build.opensuse.org/package/show/network:ldap/openldap2

And I have no reference to further information.

To OpenLDAP devs:
Does Howard's patch still make sense?
Is it worth to dig into SUSE's bugzilla to find out more?


Comment 7 Quanah Gibson-Mount 2019-04-19 15:18:34 UTC
--On Thursday, April 18, 2019 4:59 PM +0000 michael@stroeder.com wrote:

> I considered contacting current SUSE maintainers of package openldap2.
>
> In preparation to that I tried to find out which bug caused this patch
> to be developed.
>
> AFAIK the patch is not applied to the package anymore:
> https://build.opensuse.org/package/show/network:ldap/openldap2
>
> And I have no reference to further information.
>
> To OpenLDAP devs:
> Does Howard's patch still make sense?
> Is it worth to dig into SUSE's bugzilla to find out more?

Hi Michael,

Thanks for the updated information.  It sounds like this patch is no longer 
necessary, so I'm going to close out the ITS.

--Quanah

--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>


Comment 8 OpenLDAP project 2019-04-19 15:43:27 UTC
Apparently fixed via different changes in OpenLDAP in the intervening time.
Comment 9 Quanah Gibson-Mount 2019-04-19 15:43:27 UTC
changed notes
changed state Open to Closed