Issue 8683 - SLAPD_META_CLIENT_PR hidden behind LDAP_DEVEL
Summary: SLAPD_META_CLIENT_PR hidden behind LDAP_DEVEL
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: 2.4.50
Assignee: Quanah Gibson-Mount
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-05 16:13 UTC by Quanah Gibson-Mount
Modified: 2020-04-28 16:56 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Quanah Gibson-Mount 2017-07-05 16:13:27 UTC
Full_Name: Quanah Gibson-Mount
Version: RE24
OS: N/A
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (47.208.148.239)


The back-meta(5) man page discusses the following option:

       client-pr {accept-unsolicited|DISABLE|<size>}
              This feature allows one to use RFC 2696  Paged  Results  control
              when  performing  search  operations  with  a  specific  target,
              irrespective of the client's request.  When  set  to  a  numeric
              value,  Paged  Results  control  is always used with size as the
              page size.  When set to  accept-unsolicited,  unsolicited  Paged
              Results   control   responses   are  accepted  and  honored  for
              compatibility with  broken  remote  DSAs.   The  client  is  not
              exposed  to paged results handling between slapd-meta(5) and the
              remote servers.  By default (disabled), Paged Results control is
              not  used  and  responses  are  not accepted.  If set before any
              target specification, it affects all targets, unless  overridden
              by any per-target directive.


However, this feature is actually disabled by default, as it is #ifdef'd behind
LDAP_DEVEL in back-meta.h:

#ifdef LDAP_DEVEL
#define SLAPD_META_CLIENT_PR 1
#endif /* LDAP_DEVEL */


So we need to determine if either:

(a) The documentation should be removed from the man page, 
or
(b) The feature should be enabled by default, and moved out from behind
LDAP_DEVEL
Comment 1 Quanah Gibson-Mount 2020-03-23 15:45:25 UTC
Fix man page for 2.4.50, this is a 2.5 item.
Comment 2 Quanah Gibson-Mount 2020-03-24 17:39:56 UTC
https://git.openldap.org/openldap/openldap/-/merge_requests/2
Comment 3 Quanah Gibson-Mount 2020-03-24 19:44:00 UTC
Commits: 
  • 71d4e47e 
by Quanah Gibson-Mount at 2020-03-24T17:03:29+00:00 
ITS#8683 - Delete client-pr information from slapd-meta(5) for RE24