Issue 8553 - LMDB Windows UWP Patch
Summary: LMDB Windows UWP Patch
Status: VERIFIED FIXED
Alias: None
Product: LMDB
Classification: Unclassified
Component: liblmdb (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 14:08 UTC by smlu@s5.net
Modified: 2020-03-12 15:56 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description smlu@s5.net 2016-12-22 14:08:57 UTC
Full_Name: Crt Vavros
Version: 0.9.70
OS: Windows 10
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (89.142.169.104)


This patch updates LMDB library code to compile under windows UWP platform. The
patch was made against mdb.master branch [4bc270a2c] (21.12.2016).
Note that the code was not modified much, merely additional code was added to
existing one. The code had to be adapted to compile under C++ standards (LMDB
lib cannot be compiled as C code under UWP platform). This is handled via "TC"
macro which casts "raw type" to appropriate type when compiling library under
C++, it should do nothing when compiling as C code.

The test github repo can be found at https://github.com/ZeroPass/lmdb (Note that
this port is not made aginst the latest commit)

Patch was uploaded to ftp.openldap.org/incoming 
Comment 1 Howard Chu 2017-04-10 13:41:01 UTC
I see no patch filename or URL in this ticket.

Comment 2 smlu 2017-04-11 12:37:44 UTC
The patch was uploaded to ftp.openldap.org/incoming. However it was also uploaded to github: https://github.com/ZeroPass/lmdb/blob/mdb.master/mdb_uwp_patch.diff

On 10. apr. 2017, at 15:40, Howard Chu <openldap-its@OpenLDAP.org> wrote:

> I see no patch filename or URL in this ticket.
> 
> 
Comment 3 Luka Percic 2018-01-29 11:37:57 UTC
Hi, why is this not merged yet? Any particular reason?

Comment 4 Howard Chu 2018-01-29 14:46:59 UTC
temp@zeropass-app.io wrote:
> Hi, why is this not merged yet? Any particular reason?

Lack of support. AFAICS the only reason UWP exists is to support Windows 10 
Mobile, which Microsoft has discontinued.

The LMDB source is C code. Compiling under a C++ compiler is a non-goal and we 
will not support C++ syntax compatibility going forward.

Closing this ITS.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 5 Howard Chu 2018-01-29 14:47:28 UTC
changed state Open to Closed