Issue 8511 - Rename "mirrormode" to "multiprovider", deprecate "mirrormode" parameter
Summary: Rename "mirrormode" to "multiprovider", deprecate "mirrormode" parameter
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.44
Hardware: All All
: --- normal
Target Milestone: 2.5.0
Assignee: Quanah Gibson-Mount
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 17:00 UTC by Quanah Gibson-Mount
Modified: 2020-10-14 21:08 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Quanah Gibson-Mount 2016-10-06 17:00:45 UTC 
Full_Name: Quanah Gibson-Mount
Version: 2.4.44
OS: N/A
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (47.208.148.26)


In bconfig.c, the following should be reworked:

        { "mirrormode", "on|off", 2, 2, 0,
ARG_DB|ARG_ON_OFF|ARG_MAGIC|CFG_MIRRORMODE,
                &config_generic, "( OLcfgDbAt:0.16 NAME 'olcMirrorMode' "


So that the parameter name is multimaster, and the config attr is
olcMultiMaster

The term "mirrormode" is both confusing and misleading, as what it really
controls is whether or not this node is enabled for multimaster.
Comment 1 Michael Ströder 2016-10-06 17:17:41 UTC 
quanah@openldap.org wrote:
> In bconfig.c, the following should be reworked:
> [..]
> So that the parameter name is multimaster, and the config attr is
> olcMultiMaster
> 
> The term "mirrormode" is both confusing and misleading, as what it really
> controls is whether or not this node is enabled for multimaster.

+1

Ciao, Michael.
Comment 2 Quanah Gibson-Mount 2017-09-06 23:46:20 UTC 
changed notes
Comment 3 OpenLDAP project 2017-09-30 00:28:08 UTC 
has patch;openldap-scratch
IPR ok
Comment 4 Quanah Gibson-Mount 2017-09-30 00:28:08 UTC 
changed notes
Comment 5 Ondřej Kuzník 2020-03-31 08:08:16 UTC 
Can't see the patch anywhere, could you create a merge request for this?
Comment 6 Quanah Gibson-Mount 2020-04-01 20:02:36 UTC 
(In reply to Ondřej Kuzník from comment #5)
> Can't see the patch anywhere, could you create a merge request for this?

Yeah, I need to rebase it. ;)
Comment 8 Quanah Gibson-Mount 2020-07-22 20:24:40 UTC 
Commits: 
  • 3716245f 
by Quanah Gibson-Mount at 2020-07-22T19:32:49+00:00 
Issue#8511 - Update documentation and configs to correctly use multiprovider