Full_Name: Version: HEAD and RE24 OS: URL: Submission from: (NULL) (212.227.35.93) Especially when using set-based ACLs the amount of "not indexed" messages is really annoying even when only "loglevel stats" is used. Since those messages are useless even for beginners the log-level should be changed to LDAP_DEBUG_TRACE instead of LDAP_DEBUG_ANY.
I, Michael Ströder, hereby place the attached modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.
I, Michael Ströder, hereby place the attached modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. Resent as readable ASCII diff for ITS. diff --git a/servers/slapd/back-bdb/filterindex.c b/servers/slapd/back-bdb/filterindex.c index 71e3ea4..bafef72 100644 --- a/servers/slapd/back-bdb/filterindex.c +++ b/servers/slapd/back-bdb/filterindex.c @@ -741,7 +741,7 @@ equality_candidates( &db, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= bdb_equality_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -858,7 +858,7 @@ approx_candidates( &db, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= bdb_approx_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -978,7 +978,7 @@ substring_candidates( &db, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= bdb_substring_candidates: (%s) not indexed\n", sub->sa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -1095,7 +1095,7 @@ inequality_candidates( &db, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= bdb_inequality_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0; diff --git a/servers/slapd/back-mdb/filterindex.c b/servers/slapd/back-mdb/filterindex.c index 58c1cc8..20c58b7 100644 --- a/servers/slapd/back-mdb/filterindex.c +++ b/servers/slapd/back-mdb/filterindex.c @@ -709,7 +709,7 @@ equality_candidates( &dbi, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= mdb_equality_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -825,7 +825,7 @@ approx_candidates( &dbi, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= mdb_approx_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -944,7 +944,7 @@ substring_candidates( &dbi, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= mdb_substring_candidates: (%s) not indexed\n", sub->sa_desc->ad_cname.bv_val, 0, 0 ); return 0; @@ -1060,7 +1060,7 @@ inequality_candidates( &dbi, &mask, &prefix ); if ( rc == LDAP_INAPPROPRIATE_MATCHING ) { - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_TRACE, "<= mdb_inequality_candidates: (%s) not indexed\n", ava->aa_desc->ad_cname.bv_val, 0, 0 ); return 0;
I'd consider instead, resurrecting the LDAP_DEBUG_INDEX debug flag, or putting these in LDAP_DEBUG_FILTER. TRACE is already too verbose. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
hyc@symas.com wrote: > I'd consider instead, resurrecting the LDAP_DEBUG_INDEX debug flag, or putting > these in LDAP_DEBUG_FILTER. TRACE is already too verbose. I'm fine with any solution which avoids that these messages are sent to the log in case of "loglevel stats stats2". Ciao, Michael.
Hi, On Sun, 9 Mar 2014, michael@stroeder.com wrote: > hyc@symas.com wrote: >> I'd consider instead, resurrecting the LDAP_DEBUG_INDEX debug flag, or putting >> these in LDAP_DEBUG_FILTER. TRACE is already too verbose. > > I'm fine with any solution which avoids that these messages are sent to the > log in case of "loglevel stats stats2". I would also welcome a separate loglevel for these daemon messages: Mar 9 11:00:24 ldap1 slapd[19539]: daemon: read activity on 9 Mar 9 11:00:24 ldap1 slapd[19539]: daemon: select: listen=6 active_threads=0 tvp=zero Mar 9 11:00:24 ldap1 slapd[19539]: daemon: select: listen=7 active_threads=0 tvp=zero Mar 9 11:00:24 ldap1 slapd[19539]: daemon: activity on 1 descriptor Mar 9 11:00:24 ldap1 slapd[19539]: daemon: waked Mar 9 11:00:24 ldap1 slapd[19539]: daemon: select: listen=6 active_threads=0 tvp=zero Mar 9 11:00:24 ldap1 slapd[19539]: daemon: select: listen=7 active_threads=0 tvp=zero They currently seem to be triggered by loglevel conns. So what about adding loglevel daemon or even conns2 for these. Greetings Christian -- Christian Kratzer CK Software GmbH Email: ck@cksoft.de Wildberger Weg 24/2 Phone: +49 7032 893 997 - 0 D-71126 Gaeufelden Fax: +49 7032 893 997 - 9 HRB 245288, Amtsgericht Stuttgart Mobile: +49 171 1947 843 Geschaeftsfuehrer: Christian Kratzer Web: http://www.cksoft.de/
Could you please add this patch to RE24? The amount of unneeded log messages in my setup with lots of ACLs using non-indexed filters is huge and I hate to maintain local build patches. Ciao, Michael.
Needs review, may be unnecessary with logging rewrite work?
I'm using this trivial modification as back-port patch in my own package builds.
(In reply to Michael Ströder from comment #8) > I'm using this trivial modification as back-port patch in my own package > builds. Sure, but if we completely overhaul how logging is handled, then it's not clear to me exactly where this falls in what needs to be done. ;)
I guess it's more specific to the filter loglevel so changed accordingly. Part of merge request https://git.openldap.org/openldap/openldap/-/merge_requests/80
• 79960723 by Ondřej Kuzník at 2020-06-22T09:28:26+01:00 ITS#7796 Move 'not indexed' messages to loglevel filter