Issue 6703 - Patch - Mozilla NSS - reject non-file key and cert files
Summary: Patch - Mozilla NSS - reject non-file key and cert files
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: contrib (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 21:40 UTC by rich.megginson@gmail.com
Modified: 2014-08-01 21:03 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description rich.megginson@gmail.com 2010-11-12 21:40:19 UTC
Full_Name: Rich Megginson
Version: 2.4.23 (current CVS HEAD)
OS: RHEL5
URL: ftp://ftp.openldap.org/incoming/openldap-2.4.23-reject_non_file_key_cert_pem_files-20101111.patch
Submission from: (NULL) (76.113.111.209)


If you specify a directory instead of a file to TLS_CACERT, or if one of the
items in the TLS_CACERTDIR is a directory, the NSS PEM reader will crash.  This
patch rejects any item which looks like a directory.

This patch file is derived from OpenLDAP Software. All of the 
modifications to OpenLDAP Software represented in the following 
patch(es) were developed by Red Hat. Red Hat has not assigned rights 
and/or interest in this work to any party. I, Rich Megginson am 
authorized by Red Hat, my employer, to release this work under the 
following terms.

Red Hat hereby place the following modifications to OpenLDAP Software 
(and only these modifications) into the public domain. Hence, these 
modifications may be freely used and/or redistributed for any purpose 
with or without attribution and/or other notice.
Comment 1 Howard Chu 2010-11-15 11:47:54 UTC
changed notes
changed state Open to Test
moved from Incoming to Contrib
Comment 2 Howard Chu 2010-11-15 19:39:40 UTC
rmeggins@redhat.com wrote:
> Full_Name: Rich Megginson
> Version: 2.4.23 (current CVS HEAD)
> OS: RHEL5
> URL: ftp://ftp.openldap.org/incoming/openldap-2.4.23-reject_non_file_key_cert_pem_files-20101111.patch
> Submission from: (NULL) (76.113.111.209)
>
>
> If you specify a directory instead of a file to TLS_CACERT, or if one of the
> items in the TLS_CACERTDIR is a directory, the NSS PEM reader will crash.  This
> patch rejects any item which looks like a directory.

It sounds like this is a bug that ought to be patched in the NSS PEM reader 
instead, no?

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 3 rich.megginson@gmail.com 2010-11-15 20:01:51 UTC
  On 11/15/2010 12:39 PM, Howard Chu wrote:
> rmeggins@redhat.com wrote:
>> Full_Name: Rich Megginson
>> Version: 2.4.23 (current CVS HEAD)
>> OS: RHEL5
>> URL: 
>> ftp://ftp.openldap.org/incoming/openldap-2.4.23-reject_non_file_key_cert_pem_files-20101111.patch
>> Submission from: (NULL) (76.113.111.209)
>>
>>
>> If you specify a directory instead of a file to TLS_CACERT, or if one 
>> of the
>> items in the TLS_CACERTDIR is a directory, the NSS PEM reader will 
>> crash.  This
>> patch rejects any item which looks like a directory.
>
> It sounds like this is a bug that ought to be patched in the NSS PEM 
> reader instead, no?
>
Yes, you are correct.  I have filed this bug - 
https://bugzilla.redhat.com/show_bug.cgi?id=653619
But the patch to openldap will allow it to bypass this problem.

Comment 4 Howard Chu 2010-11-15 20:22:01 UTC
rmeggins@redhat.com wrote:
>    On 11/15/2010 12:39 PM, Howard Chu wrote:
>> rmeggins@redhat.com wrote:
>>> Full_Name: Rich Megginson
>>> Version: 2.4.23 (current CVS HEAD)
>>> OS: RHEL5
>>> URL:
>>> ftp://ftp.openldap.org/incoming/openldap-2.4.23-reject_non_file_key_cert_pem_files-20101111.patch
>>> Submission from: (NULL) (76.113.111.209)
>>>
>>>
>>> If you specify a directory instead of a file to TLS_CACERT, or if one
>>> of the
>>> items in the TLS_CACERTDIR is a directory, the NSS PEM reader will
>>> crash.  This
>>> patch rejects any item which looks like a directory.
>>
>> It sounds like this is a bug that ought to be patched in the NSS PEM
>> reader instead, no?
>>
> Yes, you are correct.  I have filed this bug -
> https://bugzilla.redhat.com/show_bug.cgi?id=653619
> But the patch to openldap will allow it to bypass this problem.

OK. I've reviewed and committed all of your patches 6703-6706.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 5 rich.megginson@gmail.com 2010-11-15 21:02:15 UTC
  On 11/15/2010 01:22 PM, Howard Chu wrote:
> rmeggins@redhat.com wrote:
>>    On 11/15/2010 12:39 PM, Howard Chu wrote:
>>> rmeggins@redhat.com wrote:
>>>> Full_Name: Rich Megginson
>>>> Version: 2.4.23 (current CVS HEAD)
>>>> OS: RHEL5
>>>> URL:
>>>> ftp://ftp.openldap.org/incoming/openldap-2.4.23-reject_non_file_key_cert_pem_files-20101111.patch 
>>>>
>>>> Submission from: (NULL) (76.113.111.209)
>>>>
>>>>
>>>> If you specify a directory instead of a file to TLS_CACERT, or if one
>>>> of the
>>>> items in the TLS_CACERTDIR is a directory, the NSS PEM reader will
>>>> crash.  This
>>>> patch rejects any item which looks like a directory.
>>>
>>> It sounds like this is a bug that ought to be patched in the NSS PEM
>>> reader instead, no?
>>>
>> Yes, you are correct.  I have filed this bug -
>> https://bugzilla.redhat.com/show_bug.cgi?id=653619
>> But the patch to openldap will allow it to bypass this problem.
>
> OK. I've reviewed and committed all of your patches 6703-6706.
>
Thanks!

Comment 6 Quanah Gibson-Mount 2010-12-11 18:25:34 UTC
changed notes
changed state Test to Release
Comment 7 Quanah Gibson-Mount 2011-02-14 12:34:02 UTC
changed notes
changed state Release to Closed
Comment 8 OpenLDAP project 2014-08-01 21:03:29 UTC
in HEAD
in RE24