Full_Name: Rafal Szczesniak Version: Stable (2.4.16) OS: GNU/Linux URL: http://www.samba.org/~mimir/gssapi-bugfix.diff Submission from: (NULL) (67.51.54.234) This is a bugfix patch for OpenLDAP's gssapi support.
mimir@samba.org wrote: > Full_Name: Rafal Szczesniak > Version: Stable (2.4.16) > OS: GNU/Linux > URL: http://www.samba.org/~mimir/gssapi-bugfix.diff > Submission from: (NULL) (67.51.54.234) > > > This is a bugfix patch for OpenLDAP's gssapi support. > One of these patches appears to duplicate ITS#6092. As the original author of this code, could you also take a look at #6091 and #6093? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
hyc@symas.com wrote: > mimir@samba.org wrote: >> Full_Name: Rafal Szczesniak >> Version: Stable (2.4.16) >> OS: GNU/Linux >> URL: http://www.samba.org/~mimir/gssapi-bugfix.diff >> Submission from: (NULL) (67.51.54.234) >> >> >> This is a bugfix patch for OpenLDAP's gssapi support. >> > One of these patches appears to duplicate ITS#6092. As the original author of > this code, could you also take a look at #6091 and #6093? > Yes, I think this patch tries to resolve the same problem like #6093 but with a different approach. And after some discussion with Hallvard B Furuseth about the guess_service_principal() string problem (#6223) I have sent a all-in-one-patch which results in #6110. best regards mike
On Fri, Jul 24, 2009 at 09:20:46PM -0700, Howard Chu wrote: > mimir@samba.org wrote: >> Full_Name: Rafal Szczesniak >> Version: Stable (2.4.16) >> OS: GNU/Linux >> URL: http://www.samba.org/~mimir/gssapi-bugfix.diff >> Submission from: (NULL) (67.51.54.234) >> >> >> This is a bugfix patch for OpenLDAP's gssapi support. >> > One of these patches appears to duplicate ITS#6092. As the original > author of this code, could you also take a look at #6091 and #6093? Yes, will do. Sorry about late reply, but first I was travelling and then I went for a holidays. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewise.com
Howard, On Fri, Jul 24, 2009 at 09:20:46PM -0700, Howard Chu wrote: > mimir@samba.org wrote: > >Full_Name: Rafal Szczesniak > >Version: Stable (2.4.16) > >OS: GNU/Linux > >URL: http://www.samba.org/~mimir/gssapi-bugfix.diff > >Submission from: (NULL) (67.51.54.234) > > > > > >This is a bugfix patch for OpenLDAP's gssapi support. > > > One of these patches appears to duplicate ITS#6092. As the original > author of this code, could you also take a look at #6091 and #6093? I'm really sorry but after I looked at current code in HEAD and I thought I liked it (the actual issue was fixed), following with this thread completely went off my radar. I've found it while looking through my mailbox. The last chunk of this its' patch still applies though. It's a minor thing but fixes potential memory leak. I can open a separate ITS for it if you like. As for the other patches - #6091 is (was) convenient but not absolutely necessary and #6093 is interesting but I'm not sure if it isn's a bit too much. If you're connecting invalid (from kerberos point of view) hostname then, well, find out what's the correct hostname first. This its # can be closed of course. cheers, -- Rafal Szczesniak Samba Team member http://www.samba.org Likewise Software http://www.likewise.com
moved from Incoming to Software Bugs
Created attachment 758 [details] gssapi-bugfix.diff
Need to check the last bit here about the potential memory leak fix
Superceded by Issue#6567