Full_Name: Emmanuel Dreyfus Version: HEAD OS: NetBSD-4.0 URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/databases/openldap/patches/patch-ad?rev=1.7 Submission from: (NULL) (213.41.141.172) NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build problem on sparc64 with gcc 3.x (x <= 3). The build failure is caused by a bug in gcc. I think it would not hurt to commit this patch in OpenLDAP CVS: everything is guarded by macros, so it cannot cause any harm to unaffected systems, and the workaround has been tested by NetBSD people for 5 years.
manu@netbsd.org wrote: > Full_Name: Emmanuel Dreyfus > Version: HEAD > OS: NetBSD-4.0 > URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/databases/openldap/patches/patch-ad?rev=1.7 > Submission from: (NULL) (213.41.141.172) > > > NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build problem on > sparc64 with gcc 3.x (x<= 3). The build failure is caused by a bug in gcc. > > I think it would not hurt to commit this patch in OpenLDAP CVS: everything is > guarded by macros, so it cannot cause any harm to unaffected systems, and the > workaround has been tested by NetBSD people for 5 years. Kurt will probably have something to say about this too - this is more than a couple-line patch, it needs to be submitted by its original author, with appropriate rights attributions etc. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
On Dec 28, 2008, at 4:10 PM, hyc@symas.com wrote: > manu@netbsd.org wrote: >> Full_Name: Emmanuel Dreyfus >> Version: HEAD >> OS: NetBSD-4.0 >> URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/ >> databases/openldap/patches/patch-ad?rev=1.7 >> Submission from: (NULL) (213.41.141.172) >> >> >> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a >> build problem on >> sparc64 with gcc 3.x (x<= 3). The build failure is caused by a bug >> in gcc. >> >> I think it would not hurt to commit this patch in OpenLDAP CVS: >> everything is >> guarded by macros, so it cannot cause any harm to unaffected >> systems, and the >> workaround has been tested by NetBSD people for 5 years. > > Kurt will probably have something to say about this too - this is > more than a > couple-line patch, it needs to be submitted by its original author, > with > appropriate rights attributions etc. On a technical note, use of platform macros (sun and gcc versions) should be avoided. Instead, autoconf should be used to detect conditions for need to be adapted for. On an IPR review, I suspect it would be easier to update to: http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/hash/sha1.c?rev=1.21;content-type=text%2Fplain then to try to identify the contributors and get their "okay". -- Kurt
Howard Chu <hyc@symas.com> wrote: > > NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build > > problem on sparc64 with gcc 3.x (x<= 3). The build failure is caused by > > a bug in gcc. > > > > I think it would not hurt to commit this patch in OpenLDAP CVS: > > everything is guarded by macros, so it cannot cause any harm to > > unaffected systems, and the workaround has been tested by NetBSD people > > for 5 years. > > Kurt will probably have something to say about this too - this is more than a > couple-line patch, it needs to be submitted by its original author, with > appropriate rights attributions etc. Klaus Klein <kleink@kleink.org> is the contributor (I added him to the recipients of this messages). Do we need anything more than an e-mail with the patch and the excerpt below correctly filled? "This patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by <YOUR NAME> <YOUR-EMAIL-ADDRESS>. I have not assigned rights and/or interest in this work to any party. " -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz manu@netbsd.org
On Dec 28, 2008, at 10:37 PM, manu@netbsd.org wrote: > Howard Chu <hyc@symas.com> wrote: > >>> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a >>> build >>> problem on sparc64 with gcc 3.x (x<= 3). The build failure is >>> caused by >>> a bug in gcc. >>> >>> I think it would not hurt to commit this patch in OpenLDAP CVS: >>> everything is guarded by macros, so it cannot cause any harm to >>> unaffected systems, and the workaround has been tested by NetBSD >>> people >>> for 5 years. >> >> Kurt will probably have something to say about this too - this is >> more than a >> couple-line patch, it needs to be submitted by its original author, >> with >> appropriate rights attributions etc. > > Klaus Klein <kleink@kleink.org> is the contributor (I added him to the > recipients of this messages). > > Do we need anything more than an e-mail with the patch and the excerpt > below correctly filled? > > "This patch file is derived from OpenLDAP Software. All of the > modifications to OpenLDAP Software represented in the following > patch(es) were developed by <YOUR NAME> <YOUR-EMAIL-ADDRESS>. I have > not > assigned rights and/or interest in this work to any party. " One would also need an appropriate "rights statement". See http://www.openldap.org/devel/contributing.html . -- Kurt
For Klaus's benefit. Begin forwarded message: > From: Kurt Zeilenga <Kurt@OpenLDAP.org> > Date: December 29, 2008 11:01:08 AM PST > To: manu@netbsd.org > Cc: openldap-its@openldap.org > Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix > > > On Dec 28, 2008, at 10:37 PM, manu@netbsd.org wrote: > >> Howard Chu <hyc@symas.com> wrote: >> >>>> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a >>>> build >>>> problem on sparc64 with gcc 3.x (x<= 3). The build failure is >>>> caused by >>>> a bug in gcc. >>>> >>>> I think it would not hurt to commit this patch in OpenLDAP CVS: >>>> everything is guarded by macros, so it cannot cause any harm to >>>> unaffected systems, and the workaround has been tested by NetBSD >>>> people >>>> for 5 years. >>> >>> Kurt will probably have something to say about this too - this is >>> more than a >>> couple-line patch, it needs to be submitted by its original >>> author, with >>> appropriate rights attributions etc. >> >> Klaus Klein <kleink@kleink.org> is the contributor (I added him to >> the >> recipients of this messages). >> >> Do we need anything more than an e-mail with the patch and the >> excerpt >> below correctly filled? >> >> "This patch file is derived from OpenLDAP Software. All of the >> modifications to OpenLDAP Software represented in the following >> patch(es) were developed by <YOUR NAME> <YOUR-EMAIL-ADDRESS>. I >> have not >> assigned rights and/or interest in this work to any party. " > > One would also need an appropriate "rights statement". See http://www.openldap.org/devel/contributing.html > . > > -- Kurt
On Dec 28, 2008, at 4:52 PM, kurt@openldap.org wrote: > On a technical note, use of platform macros (sun and gcc versions) > should be avoided. Instead, autoconf should be used to detect > conditions for need to be adapted for. > > On an IPR review, I suspect it would be easier to update to: > http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/hash/sha1.c?rev=1.21;content-type=text%2Fplain > > then to try to identify the contributors and get their "okay". I should note that, from a technical point of view, it might also be better to integrate the latest from OpenBSD. This would hopefully provide a SHA1 implementation which works on more platforms than the current version, or the current version as modified by Klaus's patch. -- Kurt
moved from Incoming to Build
Emmanuel, Is this bug still relevant?