OpenLDAP
Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest

Viewing Incoming/5875
Full headers

From: manu@netbsd.org
Subject: sparc64/gcc-3.3 build fix
Compose comment
Download message
State:
0 replies:
6 followups: 1 2 3 4 5 6

Major security issue: yes  no

Notes:

Notification:


Date: Sun, 28 Dec 2008 15:09:24 GMT
From: manu@netbsd.org
To: openldap-its@OpenLDAP.org
Subject: sparc64/gcc-3.3 build fix
Full_Name: Emmanuel Dreyfus
Version: HEAD
OS: NetBSD-4.0
URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/databases/openldap/patches/patch-ad?rev=1.7
Submission from: (NULL) (213.41.141.172)


NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build problem on
sparc64 with gcc 3.x (x <= 3). The build failure is caused by a bug in gcc. 

I think it would not hurt to commit this patch in OpenLDAP CVS: everything is
guarded by macros, so it cannot cause any harm to unaffected systems, and the
workaround has been tested by NetBSD people for 5 years. 


Followup 1

Download message
Date: Sun, 28 Dec 2008 16:10:42 -0800
From: Howard Chu <hyc@symas.com>
To: manu@netbsd.org
CC: openldap-its@openldap.org
Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
manu@netbsd.org wrote:
> Full_Name: Emmanuel Dreyfus
> Version: HEAD
> OS: NetBSD-4.0
> URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/databases/openldap/patches/patch-ad?rev=1.7
> Submission from: (NULL) (213.41.141.172)
>
>
> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build
problem on
> sparc64 with gcc 3.x (x<= 3). The build failure is caused by a bug in
gcc.
>
> I think it would not hurt to commit this patch in OpenLDAP CVS: everything
is
> guarded by macros, so it cannot cause any harm to unaffected systems, and
the
> workaround has been tested by NetBSD people for 5 years.

Kurt will probably have something to say about this too - this is more than a 
couple-line patch, it needs to be submitted by its original author, with 
appropriate rights attributions etc.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/



Followup 2

Download message
Cc: openldap-its@OpenLDAP.org
From: Kurt Zeilenga <Kurt@OpenLDAP.org>
To: hyc@symas.com
Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
Date: Sun, 28 Dec 2008 16:52:18 -0800
On Dec 28, 2008, at 4:10 PM, hyc@symas.com wrote:

> manu@netbsd.org wrote:
>> Full_Name: Emmanuel Dreyfus
>> Version: HEAD
>> OS: NetBSD-4.0
>> URL: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/ 
>> databases/openldap/patches/patch-ad?rev=1.7
>> Submission from: (NULL) (213.41.141.172)
>>
>>
>> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a  
>> build problem on
>> sparc64 with gcc 3.x (x<= 3). The build failure is caused by a bug  
>> in gcc.
>>
>> I think it would not hurt to commit this patch in OpenLDAP CVS:  
>> everything is
>> guarded by macros, so it cannot cause any harm to unaffected  
>> systems, and the
>> workaround has been tested by NetBSD people for 5 years.
>
> Kurt will probably have something to say about this too - this is  
> more than a
> couple-line patch, it needs to be submitted by its original author,  
> with
> appropriate rights attributions etc.

On a technical note, use of platform macros (sun and gcc versions)  
should be avoided.  Instead, autoconf should be used to detect  
conditions for need to be adapted for.

On an IPR review, I suspect it would be easier to update to:
   http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/hash/sha1.c?rev=1.21;content-type=text%2Fplain

then to try to identify the contributors and get their "okay".

-- Kurt



Followup 3

Download message
To: hyc@symas.com (Howard Chu), kleink@netbsd.org
Cc: openldap-its@openldap.org
Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
From: manu@netbsd.org (Emmanuel Dreyfus)
Date: Mon, 29 Dec 2008 07:37:02 +0100
Howard Chu <hyc@symas.com> wrote:

> > NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a build
> > problem on sparc64 with gcc 3.x (x<= 3). The build failure is
caused by
> > a bug in gcc.
> >
> > I think it would not hurt to commit this patch in OpenLDAP CVS:
> > everything is guarded by macros, so it cannot cause any harm to
> > unaffected systems, and the workaround has been tested by NetBSD
people
> > for 5 years.
> 
> Kurt will probably have something to say about this too - this is more than
a
> couple-line patch, it needs to be submitted by its original author, with
> appropriate rights attributions etc.

Klaus Klein <kleink@kleink.org> is the contributor (I added him to the
recipients of this messages).

Do we need anything more than an e-mail with the patch and the excerpt
below correctly filled?

"This patch file is derived from OpenLDAP Software. All of the
modifications to OpenLDAP Software represented in the following
patch(es) were developed by <YOUR NAME> <YOUR-EMAIL-ADDRESS>. I have
not
assigned rights and/or interest in this work to any party. "

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu@netbsd.org



Followup 4

Download message
Cc: openldap-its@OpenLDAP.org
From: Kurt Zeilenga <Kurt@OpenLDAP.org>
To: manu@netbsd.org
Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
Date: Mon, 29 Dec 2008 11:01:08 -0800
On Dec 28, 2008, at 10:37 PM, manu@netbsd.org wrote:

> Howard Chu <hyc@symas.com> wrote:
>
>>> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a  
>>> build
>>> problem on sparc64 with gcc 3.x (x<= 3). The build failure is  
>>> caused by
>>> a bug in gcc.
>>>
>>> I think it would not hurt to commit this patch in OpenLDAP CVS:
>>> everything is guarded by macros, so it cannot cause any harm to
>>> unaffected systems, and the workaround has been tested by NetBSD  
>>> people
>>> for 5 years.
>>
>> Kurt will probably have something to say about this too - this is  
>> more than a
>> couple-line patch, it needs to be submitted by its original author,  
>> with
>> appropriate rights attributions etc.
>
> Klaus Klein <kleink@kleink.org> is the contributor (I added him to
the
> recipients of this messages).
>
> Do we need anything more than an e-mail with the patch and the excerpt
> below correctly filled?
>
> "This patch file is derived from OpenLDAP Software. All of the
> modifications to OpenLDAP Software represented in the following
> patch(es) were developed by <YOUR NAME> <YOUR-EMAIL-ADDRESS>. I
have  
> not
> assigned rights and/or interest in this work to any party. "

One would also need an appropriate "rights statement".  See
http://www.openldap.org/devel/contributing.html 
.

-- Kurt



Followup 5

Download message
Cc: OpenLDAP ITS <openldap-its@OpenLDAP.org>
From: Kurt Zeilenga <Kurt@OpenLDAP.org>
To: Klaus Klein <kleink@kleink.org>
Subject: Fwd: (ITS#5875) sparc64/gcc-3.3 build fix
Date: Mon, 29 Dec 2008 11:03:55 -0800
For Klaus's benefit.

Begin forwarded message:
> From: Kurt Zeilenga <Kurt@OpenLDAP.org>
> Date: December 29, 2008 11:01:08 AM PST
> To: manu@netbsd.org
> Cc: openldap-its@openldap.org
> Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
>
>
> On Dec 28, 2008, at 10:37 PM, manu@netbsd.org wrote:
>
>> Howard Chu <hyc@symas.com> wrote:
>>
>>>> NetBSD's pkgsrc has a 5 years old OpenLDAP patch that address a
 
>>>> build
>>>> problem on sparc64 with gcc 3.x (x<= 3). The build failure
is  
>>>> caused by
>>>> a bug in gcc.
>>>>
>>>> I think it would not hurt to commit this patch in OpenLDAP CVS:
>>>> everything is guarded by macros, so it cannot cause any harm to
>>>> unaffected systems, and the workaround has been tested by
NetBSD  
>>>> people
>>>> for 5 years.
>>>
>>> Kurt will probably have something to say about this too - this is  
>>> more than a
>>> couple-line patch, it needs to be submitted by its original  
>>> author, with
>>> appropriate rights attributions etc.
>>
>> Klaus Klein <kleink@kleink.org> is the contributor (I added him
to  
>> the
>> recipients of this messages).
>>
>> Do we need anything more than an e-mail with the patch and the  
>> excerpt
>> below correctly filled?
>>
>> "This patch file is derived from OpenLDAP Software. All of the
>> modifications to OpenLDAP Software represented in the following
>> patch(es) were developed by <YOUR NAME>
<YOUR-EMAIL-ADDRESS>. I  
>> have not
>> assigned rights and/or interest in this work to any party. "
>
> One would also need an appropriate "rights statement".  See
http://www.openldap.org/devel/contributing.html 
> .
>
> -- Kurt



Followup 6

Download message
Cc: OpenLDAP ITS <openldap-its@OpenLDAP.org>
From: Kurt Zeilenga <Kurt@OpenLDAP.org>
To: Klaus Klein <kleink@kleink.org>
Subject: Re: (ITS#5875) sparc64/gcc-3.3 build fix
Date: Mon, 29 Dec 2008 11:07:30 -0800
On Dec 28, 2008, at 4:52 PM, kurt@openldap.org wrote:

> On a technical note, use of platform macros (sun and gcc versions)
> should be avoided.  Instead, autoconf should be used to detect
> conditions for need to be adapted for.
>
> On an IPR review, I suspect it would be easier to update to:
>   http://www.openbsd.org/cgi-bin/cvsweb/src/lib/libc/hash/sha1.c?rev=1.21;content-type=text%2Fplain
>
> then to try to identify the contributors and get their "okay".

I should note that, from a technical point of view, it might also be  
better to integrate the latest from OpenBSD.  This would hopefully  
provide a SHA1 implementation which works on more platforms than the  
current version, or the current version as modified by Klaus's patch.

-- Kurt


Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest


The OpenLDAP Issue Tracking System uses a hacked version of JitterBug

______________
© Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org