Full_Name: Quanah Gibson-Mount Version: 2.4.44 OS: N/A URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.148.26) The "reloadhint" option for the syncprov overlay currently defaults to FALSE. However, the documentation clearly notes that you want to set it to true for any release > 2.3.11. Given that 2.3 has been obsolete for years and it has been over 11 years since the release of 2.3.11, we should really fix the default value, and note that it should be changed if and only if there is a consumer running 2.3.11 or prior.
--On Monday, February 06, 2017 11:54 PM +0000 quanah@openldap.org wrote: > The "reloadhint" option for the syncprov overlay currently defaults to > FALSE. However, the documentation clearly notes that you want to set it > to true for any release > 2.3.11. Given that 2.3 has been obsolete for > years and it has been over 11 years since the release of 2.3.11, we > should really fix the default value, and note that it should be changed > if and only if there is a consumer running 2.3.11 or prior. Actually, since it is not a valid configuration scenario to have a 2.4 provider and a 2.3 consumer, it seems that the configuration option should be deprecated entirely, and the internal code simply default to TRUE. --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>
quanah@openldap.org wrote: > Full_Name: Quanah Gibson-Mount > Version: 2.4.44 > OS: N/A > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (47.208.148.26) > > > The "reloadhint" option for the syncprov overlay currently defaults to FALSE. > However, the documentation clearly notes that you want to set it to true for any > release > 2.3.11. Given that 2.3 has been obsolete for years and it has been > over 11 years since the release of 2.3.11, we should really fix the default > value, and note that it should be changed if and only if there is a consumer > running 2.3.11 or prior. The relevant part of the doc is "It must be set TRUE when using the accesslog overlay for delta-based syncrepl support." Otherwise it has no effect, so there is no reason to change it in the default case. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
--On Tuesday, February 07, 2017 8:53 AM +0000 Howard Chu <hyc@symas.com> wrote: > The relevant part of the doc is "It must be set TRUE when using the > accesslog overlay for delta-based syncrepl support." Otherwise it has no > effect, so there is no reason to change it in the default case. Actually, what the manpage says is: This option should be set TRUE when working with newer releases that properly support this flag. It must be set TRUE when using the accesslog overlay for delta-based syncrepl replication support. So, that clearly states it should *always* be TRUE unless you have a 2.3.11 or earlier consumer, which is technically not allowable. There is zero reason for this tunable to exist. It should be deprecated and the internal code changed to simply set the flag to TRUE. One less item for anyone to have to ever deal with is a win. --Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>
Quanah Gibson-Mount wrote: > --On Tuesday, February 07, 2017 8:53 AM +0000 Howard Chu <hyc@symas.com> wrote: > > >> The relevant part of the doc is "It must be set TRUE when using the >> accesslog overlay for delta-based syncrepl support." Otherwise it has no >> effect, so there is no reason to change it in the default case. > > Actually, what the manpage says is: > > This option should be set TRUE when working with > newer releases that properly support this flag. It must be set > TRUE when using the accesslog overlay for delta-based syncrepl > replication support. > > So, that clearly states it should *always* be TRUE unless you have a 2.3.11 or > earlier consumer, which is technically not allowable. There is zero reason > for this tunable to exist. It should be deprecated and the internal code > changed to simply set the flag to TRUE. One less item for anyone to have to > ever deal with is a win. "when working with newer releases that properly support this flag." The syncrepl consumer only pays attention to this flag in delta-sync. There is no reason to use reloadhint in regular syncrepl. Turning it on by default only slows down the refresh negotiation in regular syncrepl. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
> On Feb 7, 2017, at 10:25 AM, hyc@symas.com wrote: > > Quanah Gibson-Mount wrote: >> --On Tuesday, February 07, 2017 8:53 AM +0000 Howard Chu <hyc@symas.com> wrote: >> >> >>> The relevant part of the doc is "It must be set TRUE when using the >>> accesslog overlay for delta-based syncrepl support." Otherwise it has no >>> effect, so there is no reason to change it in the default case. >> >> Actually, what the manpage says is: >> >> This option should be set TRUE when working with >> newer releases that properly support this flag. It must be set >> TRUE when using the accesslog overlay for delta-based syncrepl >> replication support. >> >> So, that clearly states it should *always* be TRUE unless you have a 2.3.11 or >> earlier consumer, which is technically not allowable. There is zero reason >> for this tunable to exist. It should be deprecated and the internal code >> changed to simply set the flag to TRUE. One less item for anyone to have to >> ever deal with is a win. > > "when working with newer releases that properly support this flag." > > The syncrepl consumer only pays attention to this flag in delta-sync. There is > no reason to use reloadhint in regular syncrepl. Turning it on by default only > slows down the refresh negotiation in regular syncrepl. > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > Then the man page needs updating since the information on it is blatantly wrong. The "newer releases" is clearly indicated to be anything later than 2.3.11. --Quanah
moved from Incoming to Documentation
changed notes changed state Open to Release
Fixed in master Fixed in RE25 Fixed in RE24 (2.4.45)
changed notes changed state Release to Closed