Issue 7860 - [PATCH] correction to ldap_ava in ldap_get_dn.3
Summary: [PATCH] correction to ldap_ava in ldap_get_dn.3
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: documentation (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-27 05:12 UTC by Ryan Tandy
Modified: 2014-10-23 07:28 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Ryan Tandy 2014-05-27 05:12:34 UTC 
Full_Name: Ryan Tandy
Version: master/b22a614, RE24/d961650
OS: Debian unstable
URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=38;bug=465024
Submission from: (NULL) (24.68.121.206)


Hi,

In Debian bug #465024, Philipp Hahn has provided the following patch,
supplementing the change from ITS#5366:

Index: openldap-2.4.39/doc/man/man3/ldap_get_dn.3
===================================================================
--- openldap-2.4.39.orig/doc/man/man3/ldap_get_dn.3     2014-02-21
00:12:24.000000000 +0100
+++ openldap-2.4.39/doc/man/man3/ldap_get_dn.3  2014-04-17 11:28:10.468925942
+0200
@@ -82,8 +82,8 @@
 .ft B

 typedef struct ldap_ava {
-    char *la_attr;
-    struct berval *la_value;
+    struct berval la_attr;
+    struct berval la_value;
     unsigned la_flags;
 } LDAPAVA;

It looks correct to me. (I assume the omission of la_private is intentional.)

thanks,
Ryan
Comment 1 Howard Chu 2014-07-18 11:29:39 UTC 
changed notes
changed state Open to Test
moved from Incoming to Documentation
Comment 2 Howard Chu 2014-07-18 18:27:27 UTC 
ryan@nardis.ca wrote:
> Full_Name: Ryan Tandy
> Version: master/b22a614, RE24/d961650
> OS: Debian unstable
> URL: https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=38;bug=465024
> Submission from: (NULL) (24.68.121.206)
>
>
> Hi,

Thanks, fixed now in master.

>
> In Debian bug #465024, Philipp Hahn has provided the following patch,
> supplementing the change from ITS#5366:
>
> Index: openldap-2.4.39/doc/man/man3/ldap_get_dn.3
> ===================================================================
> --- openldap-2.4.39.orig/doc/man/man3/ldap_get_dn.3     2014-02-21
> 00:12:24.000000000 +0100
> +++ openldap-2.4.39/doc/man/man3/ldap_get_dn.3  2014-04-17 11:28:10.468925942
> +0200
> @@ -82,8 +82,8 @@
>   .ft B
>
>   typedef struct ldap_ava {
> -    char *la_attr;
> -    struct berval *la_value;
> +    struct berval la_attr;
> +    struct berval la_value;
>       unsigned la_flags;
>   } LDAPAVA;
>
> It looks correct to me. (I assume the omission of la_private is intentional.)
>
> thanks,
> Ryan
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
Comment 3 Quanah Gibson-Mount 2014-07-22 15:23:19 UTC 
changed notes
changed state Test to Release
Comment 4 OpenLDAP project 2014-10-23 07:28:55 UTC 
fixed in master
fixed in RE25
fixed in RE24
Comment 5 Quanah Gibson-Mount 2014-10-23 07:28:55 UTC 
changed notes
changed state Release to Closed