Viewing Documentation/5366
Full headers

Major security issue: yes  no

Notes:
FIXED in HEAD Fixed in RE24
Notification:

Date: Sun, 10 Feb 2008 19:58:22 GMT
From: rra@stanford.edu
To: openldap-its@OpenLDAP.org
Subject: ldap_get_dn man page errors

Full_Name: Russ Allbery
Version: 2.4.7
OS: Debian GNU/Linux
URL: 
Submission from: (NULL) (171.66.157.14)


The ldap_get_dn man page has the following prototype for ldap_str2dn:

int ldap_str2dn( const char *str, LDAPDN **dn, unsigned flags )

However, ldap.h has:

LDAP_F( int )
ldap_str2dn LDAP_P((
        LDAP_CONST char *str,
        LDAPDN *dn,
        unsigned flags ));

Note the difference for the second argument.   This is related to, later in the
man page:

       typedef struct ldap_ava {
           char *la_attr;
           struct berval *la_value;
           unsigned la_flags;
       } LDAPAVA;

       typedef LDAPAVA** LDAPRDN;
       typedef LDAPRDN** LDAPDN;

but ldap.h says:

typedef struct ldap_ava {
        struct berval la_attr;
        struct berval la_value;
        unsigned la_flags;
        void *la_private;
} LDAPAVA;

typedef LDAPAVA** LDAPRDN;
typedef LDAPRDN* LDAPDN;

Note the type difference for LDAPDN (which explains the earlier varience) and
for la_attr.

Original Debian bug report: http://bugs.debian.org/465024

Reply 1

From: Gavin Henry <openldap-its@OpenLDAP.org>
To: openldap-its@OpenLDAP.org
Subject: Re: ldap_get_dn man page errors (ITS#5366)
Date: Tue Feb 19 21:32:59 2008

Should I change code man pages?

Followup 1

From: Peter Marschall <peter@adpm.de>
To: openldap-its@openldap.org
Subject: Re: patch filed (ITS#5366)
Date: Sun, 22 Mar 2009 18:56:57 +0100
Cc: rra@stanford.edu

Hi,

I filed a patch that should fix this ITS.
It can be found at 
  ftp://ftp.openldap.org/incoming/PeterMarschall-090322.patch
and brings the man page in line with the code.

Regards
Peter
-- 
Peter Marschall
peter@adpm.de