OpenLDAP
Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest

Viewing Development/8978
Full headers

From: khng300@gmail.com
Subject: Fix mdb_env_open2() failing when getting handle for NTDLL.dll
Compose comment
Download message
State:
0 replies:
1 followups: 1

Major security issue: yes  no

Notes:

Notification:


Date: Sun, 17 Feb 2019 17:03:05 +0000
From: khng300@gmail.com
To: openldap-its@OpenLDAP.org
Subject: Fix mdb_env_open2() failing when getting handle for NTDLL.dll
Full_Name: Ka Ho Ng
Version: mdb.master
OS: Windows 10
URL: ftp://ftp.openldap.org/incoming/Ka-Ho-Ng-190218.patch
Submission from: (NULL) (2001:470:fa95:1300::1)


Fix mdb_env_open2() failing when getting handle for NTDLL.dll

Always call GetModuleHandleW() with Unicode string, as mdb_fopen() is
calling CreateFileW() already. Otherwise GetModuleHandle() will fail with
non-Unicode string.

I, Ka Ho Ng, hereby place the following modifications to OpenLDAP Software (and
only these modifications) into the public domain. Hence, these modifications may
be freely used and/or redistributed for any purpose with or without attribution
and/or other notice. 

Followup 1

Download message
Subject: Re: (ITS#8978) Fix mdb_env_open2() failing when getting handle for
 NTDLL.dll
To: khng300@gmail.com, openldap-its@OpenLDAP.org
From: Howard Chu <hyc@symas.com>
Date: Sun, 17 Feb 2019 17:48:20 +0000
khng300@gmail.com wrote:
> Full_Name: Ka Ho Ng
> Version: mdb.master
> OS: Windows 10
> URL: ftp://ftp.openldap.org/incoming/Ka-Ho-Ng-190218.patch
> Submission from: (NULL) (2001:470:fa95:1300::1)

Thanks for the patch, committed to mdb.master
> 
> Fix mdb_env_open2() failing when getting handle for NTDLL.dll
> 
> Always call GetModuleHandleW() with Unicode string, as mdb_fopen() is
> calling CreateFileW() already. Otherwise GetModuleHandle() will fail with
> non-Unicode string.
> 
> I, Ka Ho Ng, hereby place the following modifications to OpenLDAP Software
(and
> only these modifications) into the public domain. Hence, these
modifications may
> be freely used and/or redistributed for any purpose with or without
attribution
> and/or other notice. 
> 
> 


-- 
  -- Howard Chu
  CTO, Symas Corp.           http://www.symas.com
  Director, Highland Sun     http://highlandsun.com/hyc/
  Chief Architect, OpenLDAP  http://www.openldap.org/project/


Up to top level
Build   Contrib   Development   Documentation   Historical   Incoming   Software Bugs   Software Enhancements   Web  

Logged in as guest


The OpenLDAP Issue Tracking System uses a hacked version of JitterBug

______________
© Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org