Issue 5974 - libldap not consistently using namespaces
Summary: libldap not consistently using namespaces
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: libraries (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-24 19:40 UTC by ando@openldap.org
Modified: 2020-06-04 15:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description ando@openldap.org 2009-02-24 19:40:46 UTC
Full_Name: Pierangelo Masarati
Version: any
OS: irrelevant
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (81.72.89.40)
Submitted by: ando


There are quite a few local functions with no namespace (e.g.
re_encode_request()), but what seems to be mostly incorrect is ldap namespace
pollution (e.g. ldap_chase_v3referrals()).  Finally, there are quite a few
occurrences of ldap_int_tls_config() used outside libldap (in slapd).

Since all those functions are not meant to be exposed, I guess fixing the
(mis)use of the ldap namespace should not create issues.

p.
Comment 1 ando@openldap.org 2009-02-24 19:43:55 UTC
moved from Incoming to Development
Comment 2 Hallvard Furuseth 2009-02-24 19:48:18 UTC
ando@sys-net.it writes:
> Since all those functions are not meant to be exposed, I guess fixing
> the (mis)use of the ldap namespace should not create issues.

Wait for 2.5 to break binary compatibility.  If a function is there and
is useful, people will dig it out and use it.  Just like back-bdb used
(uses?) some internal Berkeley DB locking function.

-- 
Hallvard

Comment 3 ando@openldap.org 2009-02-24 19:50:50 UTC
h.b.furuseth@usit.uio.no wrote:
> ando@sys-net.it writes:
>> Since all those functions are not meant to be exposed, I guess fixing
>> the (mis)use of the ldap namespace should not create issues.
> 
> Wait for 2.5 to break binary compatibility.

Sure, no hurry.  I'm just getting a bit confused when digging into very 
nested libldap stuff...

> If a function is there and
> is useful, people will dig it out and use it.

That's probably my last concern, though :)

p.


Ing. Pierangelo Masarati
OpenLDAP Core Team

SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office:  +39 02 23998309
Mobile:  +39 333 4963172
Fax:     +39 0382 476497
Email:   ando@sys-net.it
-----------------------------------

Comment 4 Howard Chu 2009-02-24 19:54:06 UTC
h.b.furuseth@usit.uio.no wrote:
> ando@sys-net.it writes:
>> Since all those functions are not meant to be exposed, I guess fixing
>> the (mis)use of the ldap namespace should not create issues.

> Wait for 2.5 to break binary compatibility.  If a function is there and
> is useful, people will dig it out and use it.

Agreed. But we can probably fix slapd's use of ldap_int APIs.

> Just like back-bdb used
> (uses?) some internal Berkeley DB locking function.

(Not any more...)

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 5 ando@openldap.org 2009-02-24 20:51:13 UTC
changed notes
Comment 6 OpenLDAP project 2014-08-01 21:04:59 UTC
s/ldap_int_tls_config/ldap_pvt_tls_config/ in HEAD
wait for 2.5?
Comment 7 Ondřej Kuzník 2020-06-04 08:38:02 UTC
None of this applies to libldap(_r)/liblber in master anymore. Nor does slapd seem to reference ldap_int_* symbols directly.