Full_Name: Pierangelo Masarati Version: 2.3 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (131.175.154.56) ppolicy overlay doesn't build because of missing declarations, which are hidden in include/ldap.h behind #ifdef LDAP_DEVEL; don't know what's best to fix it: #define LDAP_DEVEL (or better #define LDAP_CONTROL_PASSWORDPOLICYREQUEST, as conditionally defined in include/ldap.h when LDAP_DEVEL is #define'd) or inhibit the building of the overlay #ifndef'd LDAP_DEVEL or so. p.
moved from Incoming to Development
changed notes
ando@sys-net.it wrote: >Full_Name: Pierangelo Masarati >Version: 2.3 >OS: Linux >URL: ftp://ftp.openldap.org/incoming/ >Submission from: (NULL) (131.175.154.56) > > >ppolicy overlay doesn't build because of missing declarations, which are hidden >in include/ldap.h behind #ifdef LDAP_DEVEL; don't know what's best to fix it: >#define LDAP_DEVEL (or better #define LDAP_CONTROL_PASSWORDPOLICYREQUEST, as >conditionally defined in include/ldap.h when LDAP_DEVEL is #define'd) or inhibit >the building of the overlay #ifndef'd LDAP_DEVEL or so. > > I'm still undecided here. I would like to see this code get released, but I guess this is still too soon. The code is now stale and needs to be brought up to date with the current draft anyway. So perhaps we should remove the ppolicy overlay from the 2.3 build for now. -- -- Howard Chu Chief Architect, Symas Corp. Director, Highland Sun http://www.symas.com http://highlandsun.com/hyc Symas: Premier OpenSource Development and Support
hyc@symas.com wrote: >ando@sys-net.it wrote: > > > >>Full_Name: Pierangelo Masarati >>Version: 2.3 >>OS: Linux >>URL: ftp://ftp.openldap.org/incoming/ >>Submission from: (NULL) (131.175.154.56) >> >> >>ppolicy overlay doesn't build because of missing declarations, which are hidden >>in include/ldap.h behind #ifdef LDAP_DEVEL; don't know what's best to fix it: >>#define LDAP_DEVEL (or better #define LDAP_CONTROL_PASSWORDPOLICYREQUEST, as >>conditionally defined in include/ldap.h when LDAP_DEVEL is #define'd) or inhibit >>the building of the overlay #ifndef'd LDAP_DEVEL or so. >> >> >> >> >I'm still undecided here. I would like to see this code get released, >but I guess this is still too soon. The code is now stale and needs to >be brought up to date with the current draft anyway. So perhaps we >should remove the ppolicy overlay from the 2.3 build for now. > I would consider the ppolicy a nice plus for 2.3, but it's up to you. In any case, I see that there's ppolicy code in libldap, in the client tools and in the overlay, so there's plenty of places for potential build problems. What about keeping it as is but wrapped around a sort of LDAP_PRERELEASE macro? Something that by default is not enabled, and one may use at own risk, but in a release, not in HEAD. p. SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497
changed notes changed state Open to Release
Pierangelo Masarati wrote: > hyc@symas.com wrote: > >> ando@sys-net.it wrote: >> >> >> >>> Full_Name: Pierangelo Masarati >>> Version: 2.3 >>> OS: Linux >>> URL: ftp://ftp.openldap.org/incoming/ >>> Submission from: (NULL) (131.175.154.56) >>> >>> >>> ppolicy overlay doesn't build because of missing declarations, which >>> are hidden >>> in include/ldap.h behind #ifdef LDAP_DEVEL; don't know what's best >>> to fix it: >>> #define LDAP_DEVEL (or better #define >>> LDAP_CONTROL_PASSWORDPOLICYREQUEST, as >>> conditionally defined in include/ldap.h when LDAP_DEVEL is >>> #define'd) or inhibit >>> the building of the overlay #ifndef'd LDAP_DEVEL or so. >>> >>> >>> >> >> I'm still undecided here. I would like to see this code get released, >> but I guess this is still too soon. The code is now stale and needs >> to be brought up to date with the current draft anyway. So perhaps we >> should remove the ppolicy overlay from the 2.3 build for now. >> > I would consider the ppolicy a nice plus for 2.3, but it's up to you. > In any case, I see that there's ppolicy code in libldap, in the client > tools and in the overlay, so there's plenty of places for potential > build problems. What about keeping it as is but wrapped around a sort > of LDAP_PRERELEASE macro? Something that by default is not enabled, > and one may use at own risk, but in a release, not in HEAD. That would be fine. I.e., putting it into 2.3 but leaving it disabled by default. -- -- Howard Chu Chief Architect, Symas Corp. Director, Highland Sun http://www.symas.com http://highlandsun.com/hyc Symas: Premier OpenSource Development and Support
> That would be fine. I.e., putting it into 2.3 but leaving it disabled by > default. OK, I'll remove the #ifdef LDAP_DEVEL around LDAP_CONTROL_PASSWORDPOLICYREQUEST and LDAP_CONTROL_PASSWORDPOLICYRESPONSE in include/ldap.h in HEAD; by default the overlay is already disabled in configure.in. This should suffice (another recompilation from scratch, sigh ;). p. -- Pierangelo Masarati mailto:pierangelo.masarati@sys-net.it SysNet - via Dossi,8 27100 Pavia Tel: +390382573859 Fax: +390382476497
ando@sys-net.it wrote: >>That would be fine. I.e., putting it into 2.3 but leaving it disabled by >>default. >> >> > >OK, I'll remove the #ifdef LDAP_DEVEL around >LDAP_CONTROL_PASSWORDPOLICYREQUEST and >LDAP_CONTROL_PASSWORDPOLICYRESPONSE in include/ldap.h in HEAD; by default >the overlay is already disabled in configure.in. This should suffice >(another recompilation from scratch, sigh ;). > Yeah. I would love to see things split out so that changing one or two features doesn't force rebuilds of the entire tree. Too bad there's not an easy way to compartmentalize configuration options so that we can have finer grained dependencies (instead of making one minor tweak to portable.h that causes everything to rebuild...). -- -- Howard Chu Chief Architect, Symas Corp. Director, Highland Sun http://www.symas.com http://highlandsun.com/hyc Symas: Premier OpenSource Development and Support
changed notes changed state Release to Closed
moved from Development to Archive.Development
fixed in HEAD/re23