Issue 7858 - [PATCH] nssov/Makefile wrong rpath
Summary: [PATCH] nssov/Makefile wrong rpath
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: contrib (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-25 19:31 UTC by Ryan Tandy
Modified: 2014-10-23 07:29 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Howard Chu 2014-05-25 13:37:46 UTC 
changed notes
changed state Open to Test
moved from Incoming to Contrib
Comment 1 Ryan Tandy 2014-05-25 19:31:29 UTC 
Full_Name: Ryan Tandy
Version: master/932a11a, RE24/d961650
OS: Debian unstable
URL: 
Submission from: (NULL) (24.68.121.206)


Hi,

nssov can't be installed:

$ cd contrib/slapd-modules/nssov
$ make
[...]
$ sudo make install
mkdir -p /usr/local/libexec/openldap
../../../libtool --mode=install cp nssov.la /usr/local/libexec/openldap
libtool: install: error: cannot install `nssov.la' to a directory not ending in
/usr/local/lib
Makefile:67: recipe for target 'install' failed
make: *** [install] Error 1

The Makefile says "-rpath $(libdir)" where every other contrib module uses
"-rpath $(moduledir)". Changing it to that lets it build, and the resulting
module seems to work.

diff --git a/contrib/slapd-modules/nssov/Makefile
b/contrib/slapd-modules/nssov/Makefile
index 8527ee3..28c8003 100644
--- a/contrib/slapd-modules/nssov/Makefile
+++ b/contrib/slapd-modules/nssov/Makefile
@@ -61,7 +61,7 @@ $(OBJS):	nssov.h
 
 nssov.la:	$(OBJS) $(XOBJS)
 	$(LIBTOOL) --mode=link $(CC) $(OPT) -version-info 0:0:0 \
-	-rpath $(libdir) -module -o $@ $(OBJS) $(XOBJS) $(LIBS)
+	-rpath $(moduledir) -module -o $@ $(OBJS) $(XOBJS) $(LIBS)
 
 install: nssov.la
 	mkdir -p $(DESTDIR)$(moduledir)

thanks,
Ryan
Comment 2 Howard Chu 2014-05-25 19:49:46 UTC 
ryan@nardis.ca wrote:
> Full_Name: Ryan Tandy
> Version: master/932a11a, RE24/d961650
> OS: Debian unstable
> URL:
> Submission from: (NULL) (24.68.121.206)
>
>
> Hi,
>
> nssov can't be installed:

Thanks, fixed now in master
>
> $ cd contrib/slapd-modules/nssov
> $ make
> [...]
> $ sudo make install
> mkdir -p /usr/local/libexec/openldap
> ../../../libtool --mode=install cp nssov.la /usr/local/libexec/openldap
> libtool: install: error: cannot install `nssov.la' to a directory not ending in
> /usr/local/lib
> Makefile:67: recipe for target 'install' failed
> make: *** [install] Error 1
>
> The Makefile says "-rpath $(libdir)" where every other contrib module uses
> "-rpath $(moduledir)". Changing it to that lets it build, and the resulting
> module seems to work.
>
> diff --git a/contrib/slapd-modules/nssov/Makefile
> b/contrib/slapd-modules/nssov/Makefile
> index 8527ee3..28c8003 100644
> --- a/contrib/slapd-modules/nssov/Makefile
> +++ b/contrib/slapd-modules/nssov/Makefile
> @@ -61,7 +61,7 @@ $(OBJS):	nssov.h
>
>   nssov.la:	$(OBJS) $(XOBJS)
>   	$(LIBTOOL) --mode=link $(CC) $(OPT) -version-info 0:0:0 \
> -	-rpath $(libdir) -module -o $@ $(OBJS) $(XOBJS) $(LIBS)
> +	-rpath $(moduledir) -module -o $@ $(OBJS) $(XOBJS) $(LIBS)
>
>   install: nssov.la
>   	mkdir -p $(DESTDIR)$(moduledir)
>
> thanks,
> Ryan
>
>


-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
Comment 3 Quanah Gibson-Mount 2014-05-29 11:05:21 UTC 
changed notes
changed state Test to Release
Comment 4 OpenLDAP project 2014-10-23 07:29:40 UTC 
fixed in master
fixed in RE24
fixed in RE25
Comment 5 Quanah Gibson-Mount 2014-10-23 07:29:40 UTC 
changed notes
changed state Release to Closed