Issue 7831 - Double Free in autogroup.c
Summary: Double Free in autogroup.c
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: contrib (show other issues)
Version: 2.4.38
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-04 10:19 UTC by mwarren@symas.com
Modified: 2014-10-23 07:29 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Howard Chu 2014-04-04 03:26:57 UTC 
changed notes
changed state Open to Test
moved from Incoming to Contrib
Comment 1 mwarren@symas.com 2014-04-04 10:19:58 UTC 
Full_Name: Mark Warren
Version: 2.4.38
OS: Ubuntu 12.04.4 LTS
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (12.70.80.130)


A double-free has been located in contrib/slapd-modules/autogroup/autogroup.c

Lines:
 1208 and 1215

Proposed solution:
 Remove Line 1215


diff --git a/contrib/slapd-modules/autogroup/autogroup.c
b/contrib/slapd-modules/autogroup/autogroup.c
index a977561..5bafe2f 100644
--- a/contrib/slapd-modules/autogroup/autogroup.c
+++ b/contrib/slapd-modules/autogroup/autogroup.c
@@ -1212,7 +1212,6 @@ autogroup_response( Operation *op, SlapReply *rs )
 
                                                                       
autogroup_add_group( op, agi, group_agd, NULL, &op->o_req_ndn, 1, 1);
 
-                                                                      
overlay_entry_release_ov( op, e, 0, on );
                                                                       
ldap_pvt_thread_mutex_unlock( &agi->agi_mutex );
                                                                        return
SLAP_CB_CONTINUE;
                                                                }
Comment 2 Quanah Gibson-Mount 2014-05-29 10:49:08 UTC 
changed notes
changed state Test to Release
Comment 3 OpenLDAP project 2014-10-23 07:29:26 UTC 
fixed in master
fixed in RE24
fixed in RE25
Comment 4 Quanah Gibson-Mount 2014-10-23 07:29:26 UTC 
changed notes
changed state Release to Closed