Issue 3593 - Contrib: addpartial overlay
Summary: Contrib: addpartial overlay
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: contrib (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-09 23:17 UTC by David Hawes
Modified: 2014-08-01 21:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description David Hawes 2005-03-09 23:17:52 UTC
Full_Name: David Hawes
Version: 2.2.23
OS: 
URL: ftp://ftp.openldap.org/incoming/david_hawes-addpartial-050309.tgz
Submission from: (NULL) (128.173.13.109)


This is an OpenLDAP overlay that intercepts ADD requests, determines if a change
has actually taken place for that record, and then performs a modify request for
those values that have changed (modified, added, deleted).  If the record has
not changed in any way, it is ignored.  If the record does not exist, the record
falls through to the normal add mechanism.  This overlay is useful for
replicating from sources that are not LDAPs where it is easier to build entire
records than to determine the changes (i.e. a database).

I am submitting this in the hope that someone will find this overlay useful. 
Any and all comments welcome.

Thank you,

david hawes


Comment 1 Kurt Zeilenga 2005-03-13 03:30:25 UTC
moved from Incoming to Contrib
Comment 2 Howard Chu 2005-10-05 19:33:48 UTC
I haven't had a chance to review this yet but it sounds like it would be 
worth incorporating this into the syncrepl consumer. Since the syncrepl 
protocol replicates whole entries, the consumer can waste a lot of time 
re-indexing values that never changed. Hopefully will get to this soon.

-- 
  -- Howard Chu
  Chief Architect, Symas Corp.  http://www.symas.com
  Director, Highland Sun        http://highlandsun.com/hyc
  OpenLDAP Core Team            http://www.openldap.org/project/

Comment 3 Kurt Zeilenga 2005-10-12 00:59:54 UTC
changed state Open to Feedback
Comment 4 David Hawes 2005-10-18 20:10:31 UTC
A patch with some minor changes to this overlay is available at:

ftp://ftp.openldap.org/incoming/david_hawes-addpartial-051017.patch

The patch addresses the following issues:

- The modify operation no longer sends a response to the client.  The response 
is properly intercepted.  
- On a modify error, the proper error is sent to the client.  
- Returns LDAP_SUCCESS to get rid of ugly logging.

david hawes

Comment 5 David Hawes 2007-01-26 20:36:59 UTC
An updated version of addpartial is available at:

ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz

This version includes changes to work with OpenLDAP 2.3 as well as ensuring 
syncrepl works properly.

david hawes

Comment 6 Gavin Henry 2007-07-19 09:35:29 UTC
> An updated version of addpartial is available at:
> 
> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
> 
> This version includes changes to work with OpenLDAP 2.3 as well as ensuring 
> syncrepl works properly.
> 
> david hawes
> 
> 


If this hasn't been added to 2.4/HEAD yet, would you consider updating it for
inclusion in 2.4 contrib?

Thanks,

Gavin.
Comment 7 David Hawes 2007-07-19 19:48:17 UTC
On Thursday 19 July 2007 05:35, Gavin Henry wrote:
> > An updated version of addpartial is available at:
> >
> > ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
> >
> > This version includes changes to work with OpenLDAP 2.3 as well as
> > ensuring syncrepl works properly.
> >
> > david hawes
>
> If this hasn't been added to 2.4/HEAD yet, would you consider updating it
> for inclusion in 2.4 contrib?

Absolutely, I've been meaning to test with 2.4.  I'll bump it to the top of 
the list.

dave 

Comment 8 Gavin Henry 2007-07-19 21:18:21 UTC
<quote who="dhawes@vt.edu">
> On Thursday 19 July 2007 05:35, Gavin Henry wrote:
>> > An updated version of addpartial is available at:
>> >
>> > ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
>> >
>> > This version includes changes to work with OpenLDAP 2.3 as well as
>> > ensuring syncrepl works properly.
>> >
>> > david hawes
>>
>> If this hasn't been added to 2.4/HEAD yet, would you consider updating
>> it
>> for inclusion in 2.4 contrib?
>
> Absolutely, I've been meaning to test with 2.4.  I'll bump it to the top
> of
> the list.

Can you make sure that is dynamically configurable via cn=config like
everything else in 2.4.

Thanks.

>
> dave
>
>
>

Comment 9 David Hawes 2007-07-20 20:21:11 UTC
On Thursday 19 July 2007 17:18, ghenry@suretecsystems.com wrote:
> <quote who="dhawes@vt.edu">
>
> > On Thursday 19 July 2007 05:35, Gavin Henry wrote:
> >> > An updated version of addpartial is available at:
> >> >
> >> > ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
> >> >
> >> > This version includes changes to work with OpenLDAP 2.3 as well as
> >> > ensuring syncrepl works properly.
> >> >
> >> > david hawes
> >>
> >> If this hasn't been added to 2.4/HEAD yet, would you consider updating
> >> it
> >> for inclusion in 2.4 contrib?
> >
> > Absolutely, I've been meaning to test with 2.4.  I'll bump it to the top
> > of
> > the list.
>
> Can you make sure that is dynamically configurable via cn=config like
> everything else in 2.4.
>
> Thanks.

I have tested the overlay at 
ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz, and it 
works with 2.4.4alpha, including dynamic loading via cn=config.

Apart from using "overlay addpartial", there is no slapd configuration for 
addpartial.  I believe this means it doesn't need its own schema to work 
correctly.  Please correct me if I am wrong about this.

Thanks,

dave  

Comment 10 Howard Chu 2007-07-20 20:29:06 UTC
dhawes@vt.edu wrote:
> On Thursday 19 July 2007 17:18, ghenry@suretecsystems.com wrote:
>> <quote who="dhawes@vt.edu">
>>
>>> On Thursday 19 July 2007 05:35, Gavin Henry wrote:
>>>>> An updated version of addpartial is available at:
>>>>>
>>>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
>>>>>
>>>>> This version includes changes to work with OpenLDAP 2.3 as well as
>>>>> ensuring syncrepl works properly.
>>>>>
>>>>> david hawes
>>>> If this hasn't been added to 2.4/HEAD yet, would you consider updating
>>>> it
>>>> for inclusion in 2.4 contrib?
>>> Absolutely, I've been meaning to test with 2.4.  I'll bump it to the top
>>> of
>>> the list.
>> Can you make sure that is dynamically configurable via cn=config like
>> everything else in 2.4.
>>
>> Thanks.
> 
> I have tested the overlay at 
> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz, and it 
> works with 2.4.4alpha, including dynamic loading via cn=config.
> 
> Apart from using "overlay addpartial", there is no slapd configuration for 
> addpartial.  I believe this means it doesn't need its own schema to work 
> correctly.  Please correct me if I am wrong about this.

That's correct. If there was no config needed under the old mechanism, then 
none is needed with the new either.

-- 
   -- Howard Chu
   Chief Architect, Symas Corp.  http://www.symas.com
   Director, Highland Sun        http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP     http://www.openldap.org/project/

Comment 11 Gavin Henry 2007-07-26 13:15:53 UTC
dhawes@vt.edu wrote:
> On Thursday 19 July 2007 17:18, ghenry@suretecsystems.com wrote:
>> <quote who="dhawes@vt.edu">
>>
>>> On Thursday 19 July 2007 05:35, Gavin Henry wrote:
>>>>> An updated version of addpartial is available at:
>>>>>
>>>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
>>>>>
>>>>> This version includes changes to work with OpenLDAP 2.3 as well as
>>>>> ensuring syncrepl works properly.
>>>>>
>>>>> david hawes
>>>> If this hasn't been added to 2.4/HEAD yet, would you consider updating
>>>> it
>>>> for inclusion in 2.4 contrib?
>>> Absolutely, I've been meaning to test with 2.4.  I'll bump it to the top
>>> of
>>> the list.
>> Can you make sure that is dynamically configurable via cn=config like
>> everything else in 2.4.
>>
>> Thanks.
> 
> I have tested the overlay at 
> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz, and it 
> works with 2.4.4alpha, including dynamic loading via cn=config.
> 
> Apart from using "overlay addpartial", there is no slapd configuration for 
> addpartial.  I believe this means it doesn't need its own schema to work 
> correctly.  Please correct me if I am wrong about this.
> 
> Thanks,
> 
> dave  
> 
> 

Anyone mind if I commit this to contrib in HEAD?

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 12 Gavin Henry 2007-07-27 08:59:16 UTC
David Hawes wrote:
> On Thursday 26 July 2007 09:15, you wrote:
>> dhawes@vt.edu wrote:
>>> On Thursday 19 July 2007 17:18, ghenry@suretecsystems.com wrote:
>>>> <quote who="dhawes@vt.edu">
>>>>
>>>>> On Thursday 19 July 2007 05:35, Gavin Henry wrote:
>>>>>>> An updated version of addpartial is available at:
>>>>>>>
>>>>>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
>>>>>>>
>>>>>>> This version includes changes to work with OpenLDAP 2.3 as well as
>>>>>>> ensuring syncrepl works properly.
>>>>>>>
>>>>>>> david hawes
>>>>>> If this hasn't been added to 2.4/HEAD yet, would you consider updating
>>>>>> it
>>>>>> for inclusion in 2.4 contrib?
>>>>> Absolutely, I've been meaning to test with 2.4.  I'll bump it to the
>>>>> top of
>>>>> the list.
>>>> Can you make sure that is dynamically configurable via cn=config like
>>>> everything else in 2.4.
>>>>
>>>> Thanks.
>>> I have tested the overlay at
>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz, and it
>>> works with 2.4.4alpha, including dynamic loading via cn=config.
>>>
>>> Apart from using "overlay addpartial", there is no slapd configuration
>>> for addpartial.  I believe this means it doesn't need its own schema to
>>> work correctly.  Please correct me if I am wrong about this.
>>>
>>> Thanks,
>>>
>>> dave
>> Anyone mind if I commit this to contrib in HEAD?
> 
> I don't think you were asking me about this, but I certainly have no problem 
> with it.  If I need to state the disclaimer I'll gladly do so.  The OpenLDAP 
> public license is included, so that may be all that is needed.
> 
> dave

Yes, that is all that is needed. Adding shortly.

Gavin.

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 13 Gavin Henry 2007-07-27 09:11:50 UTC
David Hawes wrote:
> On Thursday 26 July 2007 09:15, you wrote:
>> dhawes@vt.edu wrote:
>>> On Thursday 19 July 2007 17:18, ghenry@suretecsystems.com wrote:
>>>> <quote who="dhawes@vt.edu">
>>>>
>>>>> On Thursday 19 July 2007 05:35, Gavin Henry wrote:
>>>>>>> An updated version of addpartial is available at:
>>>>>>>
>>>>>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz
>>>>>>>
>>>>>>> This version includes changes to work with OpenLDAP 2.3 as well as
>>>>>>> ensuring syncrepl works properly.
>>>>>>>
>>>>>>> david hawes
>>>>>> If this hasn't been added to 2.4/HEAD yet, would you consider updating
>>>>>> it
>>>>>> for inclusion in 2.4 contrib?
>>>>> Absolutely, I've been meaning to test with 2.4.  I'll bump it to the
>>>>> top of
>>>>> the list.
>>>> Can you make sure that is dynamically configurable via cn=config like
>>>> everything else in 2.4.
>>>>
>>>> Thanks.
>>> I have tested the overlay at
>>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-070126.tgz, and it
>>> works with 2.4.4alpha, including dynamic loading via cn=config.
>>>
>>> Apart from using "overlay addpartial", there is no slapd configuration
>>> for addpartial.  I believe this means it doesn't need its own schema to
>>> work correctly.  Please correct me if I am wrong about this.
>>>
>>> Thanks,
>>>
>>> dave
>> Anyone mind if I commit this to contrib in HEAD?
> 
> I don't think you were asking me about this, but I certainly have no problem 
> with it.  If I need to state the disclaimer I'll gladly do so.  The OpenLDAP 
> public license is included, so that may be all that is needed.
> 
> dave

Committed. Closing ITS.

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 14 Gavin Henry 2007-07-27 09:16:41 UTC
changed notes
changed state Feedback to Test
Comment 15 Gavin Henry 2007-07-27 09:20:20 UTC
Hi David,

http://www.openldap.org/devel/cvsweb.cgi/contrib/slapd-modules/addpartial/

Will be pushed out in the next 2.4 beta.

Please bear in mind that you will be looking after this overlay, so test
as often as you can and re-submit and changes during our release cycle.

Thank you for your contribution.

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 16 Howard Chu 2007-09-04 10:17:30 UTC
changed notes
changed state Test to Release
Comment 17 Howard Chu 2007-11-01 14:47:19 UTC
changed state Release to Closed
Comment 18 David Hawes 2007-11-09 17:12:12 UTC
On Friday 27 July 2007 05:20, ghenry@openldap.org wrote:
> Hi David,
>
> http://www.openldap.org/devel/cvsweb.cgi/contrib/slapd-modules/addpartial/
>
> Will be pushed out in the next 2.4 beta.
>
> Please bear in mind that you will be looking after this overlay, so test
> as often as you can and re-submit and changes during our release cycle.
>
> Thank you for your contribution.

Changes to work properly with 2.4.6 are at:

ftp://ftp.openldap.org/incoming/david_hawes-addpartial-071109.tgz

Thanks,

dave

Comment 19 Gavin Henry 2007-11-11 19:41:25 UTC
dhawes@vt.edu wrote:
> On Friday 27 July 2007 05:20, ghenry@openldap.org wrote:
>> Hi David,
>>
>> http://www.openldap.org/devel/cvsweb.cgi/contrib/slapd-modules/addpartial/
>>
>> Will be pushed out in the next 2.4 beta.
>>
>> Please bear in mind that you will be looking after this overlay, so test
>> as often as you can and re-submit and changes during our release cycle.
>>
>> Thank you for your contribution.
> 
> Changes to work properly with 2.4.6 are at:
> 
> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-071109.tgz
> 
> Thanks,
> 
> dave
> 
> 

Will take a look over the next week.

Thanks.

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 20 Gavin Henry 2007-11-14 17:08:41 UTC
ghenry@OpenLDAP.org wrote:
> dhawes@vt.edu wrote:
>> On Friday 27 July 2007 05:20, ghenry@openldap.org wrote:
>>> Hi David,
>>>
>>> http://www.openldap.org/devel/cvsweb.cgi/contrib/slapd-modules/addpartial/
>>>
>>> Will be pushed out in the next 2.4 beta.
>>>
>>> Please bear in mind that you will be looking after this overlay, so test
>>> as often as you can and re-submit and changes during our release cycle.
>>>
>>> Thank you for your contribution.
>> Changes to work properly with 2.4.6 are at:
>>
>> ftp://ftp.openldap.org/incoming/david_hawes-addpartial-071109.tgz
>>
>> Thanks,
>>
>> dave
>>
>>
> 
> Will take a look over the next week.
> 
> Thanks.
> 

Updated in RE24 and HEAD.

-- 
Kind Regards,

Gavin Henry.
OpenLDAP Engineering Team.

E ghenry@OpenLDAP.org

Community developed LDAP software.

http://www.openldap.org/project/

Comment 21 Howard Chu 2009-02-17 06:59:13 UTC
moved from Contrib to Archive.Contrib
Comment 22 OpenLDAP project 2014-08-01 21:05:17 UTC
Added to HEAD/RE24