Issue 9062 - Please have /build/mkdep respect TMPDIR if set
Summary: Please have /build/mkdep respect TMPDIR if set
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: build (show other issues)
Version: 2.4.48
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-11 18:34 UTC by Chris Zagar
Modified: 2020-01-30 18:31 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Chris Zagar 2019-08-11 18:34:00 UTC
Full_Name: Chris Zagar
Version: 2.4.48
OS: Linux
URL: 
Submission from: (NULL) (68.98.212.84)


/build/mkdep contains this line:

TMP=/tmp/mkdep$$

that forces the use of the /tmp directory. The /tmp directory is vulnerable to
race conditions.  The rest of OpenLDAP obeys the TMPDIR environment variable if
it exists as a mitigation to this risk.  Would you please consider changing this
to:

TMP=${TMPDIR-/tmp}/mkdep$$

so this will obey TMPDIR as well?

Thank you.

Chris Zagar
zagarc@oclc.org
Comment 1 Quanah Gibson-Mount 2019-08-13 15:04:38 UTC
changed notes
changed state Open to Test
moved from Incoming to Build
Comment 2 Quanah Gibson-Mount 2019-08-13 15:06:06 UTC
--On Sunday, August 11, 2019 7:34 PM +0000 zagarc@oclc.org wrote:

> Would you please consider changing this to:
>
> TMP=${TMPDIR-/tmp}/mkdep$$

Thanks for the report, this is fixed in OpenLDAP master.

Regards,
Quanah

--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>

Comment 3 Chris Zagar 2019-08-13 21:41:44 UTC
Thank you!

Chris

From: Quanah Gibson-Mount <quanah@symas.com>
Sent: Tuesday, August 13, 2019 8:06 AM
To: Zagar (Contractor),Chris <zagarc@oclc.org>; openldap-its@OpenLDAP.org
Subject: [External] Re: (ITS#9062) Please have /build/mkdep respect TMPDIR if set


--On Sunday, August 11, 2019 7:34 PM +0000 zagarc@oclc.org<mailto:zagarc@oclc.org> wrote:

> Would you please consider changing this to:
>
> TMP=${TMPDIR-/tmp}/mkdep$$

Thanks for the report, this is fixed in OpenLDAP master.

Regards,
Quanah

--

Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com<http://www.symas.com>>
Comment 4 Quanah Gibson-Mount 2019-10-15 00:13:26 UTC
changed notes
changed state Test to Release
Comment 5 OpenLDAP project 2020-01-30 18:31:37 UTC
Fixed in master
Fixed in RE24 (2.4.49)
Comment 6 Quanah Gibson-Mount 2020-01-30 18:31:37 UTC
changed notes
changed state Release to Closed