Issue 7423 - [PATCH] Update slapo-constraint tests
Summary: [PATCH] Update slapo-constraint tests
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: build (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-25 12:53 UTC by jsynacek@redhat.com
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description jsynacek@redhat.com 2012-10-25 12:53:37 UTC
Full_Name: Jan Synacek
Version: master
OS: linux-fedora17
URL: ftp://ftp.openldap.org/incoming/jsynacek-20121025-constraint-tests-update.patch
Submission from: (NULL) (209.132.186.34)


This patch updates the slapo-constraint testsuit. It adds additional tests for
any constraints using 'uri'. Furthermore, it improves testing of the 'restrict'
parameter.


The attached file is derived from OpenLDAP Software. All of the modifications
to
OpenLDAP Software represented in the following patch(es) were developed by Red
Hat. Red Hat has not assigned rights and/or interest in this work to any party.
I, Jan Synacek am authorized by Red Hat, my employer, to release this work
under the following terms.

Red Hat hereby place the following modifications to OpenLDAP Software (and only
these modifications) into the public domain. Hence, these modifications may be
freely used and/or redistributed for any purpose with or without attribution
and/or other notice.
Comment 1 Michael Ströder 2012-10-27 10:53:45 UTC
jsynacek@redhat.com wrote:
> This patch updates the slapo-constraint testsuit. It adds additional tests for
> any constraints using 'uri'. Furthermore, it improves testing of the 'restrict'
> parameter.

In my RE24 working tree:

git apply --stat jsynacek-20121025-constraint-tests-update.patch

Then I expected
./run -b hdb test064 to fail (without the patch in ITS#7418) but it returned
"Test succeeded".

Ciao, Michael.

Comment 2 jsynacek@redhat.com 2012-10-29 11:40:20 UTC
On 10/27/2012 12:53 PM, Michael Ströder wrote:
> jsynacek@redhat.com wrote:
>> This patch updates the slapo-constraint testsuit. It adds additional tests for
>> any constraints using 'uri'. Furthermore, it improves testing of the 'restrict'
>> parameter.
> 
> In my RE24 working tree:
> 
> git apply --stat jsynacek-20121025-constraint-tests-update.patch
> 
> Then I expected
> ./run -b hdb test064 to fail (without the patch in ITS#7418) but it returned
> "Test succeeded".
> 
> Ciao, Michael.
> 

I'm sorry, one hunk didn't apply correctly.

New URL:
ftp://ftp.openldap.org/incoming/jsynacek-20121029-constraint-tests-update.patch

All the tests should fail without the patch in ITS#7418.

Cheers,

-- 
Jan Synacek
Software Engineer, BaseOS team Brno, Red Hat

Comment 3 sascha.kuehndel@deka.de 2012-10-29 15:41:38 UTC
Hello Jan,

i tested the test-cases:

without patch in 7418, all test cases of test064-constraint failed.
with patch in 7418, test064-constraint was successful.

Bye,
Sascha
Comment 4 Michael Ströder 2012-10-29 18:57:08 UTC
jsynacek@redhat.com wrote:
> On 10/27/2012 12:53 PM, Michael Ströder wrote:
>> jsynacek@redhat.com wrote:
>>> This patch updates the slapo-constraint testsuit. It adds additional tests for
>>> any constraints using 'uri'. Furthermore, it improves testing of the 'restrict'
>>> parameter.
>>
>> In my RE24 working tree:
>>
>> git apply --stat jsynacek-20121025-constraint-tests-update.patch
>>
>> Then I expected
>> ./run -b hdb test064 to fail (without the patch in ITS#7418) but it returned
>> "Test succeeded".
> I'm sorry, one hunk didn't apply correctly.
> 
> New URL:
> ftp://ftp.openldap.org/incoming/jsynacek-20121029-constraint-tests-update.patch
> 
> All the tests should fail without the patch in ITS#7418.

I can confirm that it now works as expected. Thank you.

Ciao, Michael.

Comment 5 Howard Chu 2012-10-30 23:10:44 UTC
changed notes
changed state Open to Test
moved from Incoming to Build
Comment 6 Quanah Gibson-Mount 2012-10-31 20:00:37 UTC
changed notes
changed state Test to Release
Comment 7 Quanah Gibson-Mount 2013-03-05 02:17:31 UTC
changed notes
changed state Release to Closed
Comment 8 OpenLDAP project 2014-08-01 21:04:07 UTC
fixed in master
fixed in RE24