Logged in as guest
Viewing Build/6883 Full headers
Major security issue: yes no
Notes: needs cleanup, e.g. drop GNU Make dependencies Fixed via ITS#7308 Notification:
Date: Tue, 29 Mar 2011 15:25:10 +0000 From: bgmilne@staff.telkomsa.net To: openldap-its@OpenLDAP.org Subject: Improved Makefiles for contrib modules
Full_Name: Buchan Milne Version: 2.4.25 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (196.25.124.16) While the code in contrib is not supported, some overlays provide make files, some don't, and there were variations in a lot of the make files (e.g. use of DESTDIR or not). In order to add make files for overlays that don't have them, improve the consistency of the make files between overlays that had them, and to provide some basic sanity testing in a 'test' target, I have created the patch at: http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/current/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=648744&view=markup The patch is against 2.4.25, but should apply to master (except that there two additional overlays are present in master). Where feasible I have retained the majority of an existing make file, in other cases, where modifications would exceed the original content, I have replaced existing make files wholesale. The attached patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not assigned rights and/or interest in this work to any party.
Date: Tue, 29 Mar 2011 12:20:04 -0700 From: Quanah Gibson-Mount <quanah@zimbra.com> To: bgmilne@staff.telkomsa.net, openldap-its@openldap.org Subject: Re: (ITS#6883) Improved Makefiles for contrib modules
--On Tuesday, March 29, 2011 3:25 PM +0000 bgmilne@staff.telkomsa.net wrote: > Full_Name: Buchan Milne > Version: 2.4.25 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (196.25.124.16) > > > While the code in contrib is not supported, some overlays provide make > files, some don't, and there were variations in a lot of the make files > (e.g. use of DESTDIR or not). > > In order to add make files for overlays that don't have them, improve the > consistency of the make files between overlays that had them, and to > provide some basic sanity testing in a 'test' target, I have created the > patch at: > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curre > nt/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64 > 8744&view=markup > > The patch is against 2.4.25, but should apply to master (except that > there two additional overlays are present in master). Where feasible I > have retained the majority of an existing make file, in other cases, > where modifications would exceed the original content, I have replaced > existing make files wholesale. > > The attached patch file is derived from OpenLDAP Software. All of the > modifications to OpenLDAP Software represented in the following patch(es) > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > assigned rights and/or interest in this work to any party. Hi Buchan, Can you make the patch available via git-format-patch? Thanks, Quanah -- Quanah Gibson-Mount Sr. Member of Technical Staff Zimbra, Inc A Division of VMware, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration
From: Buchan Milne <bgmilne@staff.telkomsa.net> To: quanah@zimbra.com Subject: Re: (ITS#6883) Improved Makefiles for contrib modules Date: Fri, 3 Jun 2011 10:37:13 +0200 Cc: openldap-its@openldap.org
--Boundary-00=_50J6N9eQwpy3uQe Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit On Tuesday, 29 March 2011 21:20:53 quanah@zimbra.com wrote: > --On Tuesday, March 29, 2011 3:25 PM +0000 bgmilne@staff.telkomsa.net wrote: > > Full_Name: Buchan Milne > > Version: 2.4.25 > > OS: Linux > > URL: ftp://ftp.openldap.org/incoming/ > > Submission from: (NULL) (196.25.124.16) > > > > > > While the code in contrib is not supported, some overlays provide make > > files, some don't, and there were variations in a lot of the make files > > (e.g. use of DESTDIR or not). > > > > In order to add make files for overlays that don't have them, improve the > > consistency of the make files between overlays that had them, and to > > provide some basic sanity testing in a 'test' target, I have created the > > patch at: > > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curre > > nt/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64 > > 8744&view=markup > > > > The patch is against 2.4.25, but should apply to master (except that > > there two additional overlays are present in master). Where feasible I > > have retained the majority of an existing make file, in other cases, > > where modifications would exceed the original content, I have replaced > > existing make files wholesale. > > > > The attached patch file is derived from OpenLDAP Software. All of the > > modifications to OpenLDAP Software represented in the following patch(es) > > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > > assigned rights and/or interest in this work to any party. > > Hi Buchan, > > Can you make the patch available via git-format-patch? Please find it attached. Regards, Buchan --Boundary-00=_50J6N9eQwpy3uQe Content-Type: text/x-patch; charset="UTF-8"; name="0001-Fix-contrib-Makefiles-to-use-libtool-and-be-consiste.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-contrib-Makefiles-to-use-libtool-and-be-consiste.patch" =46rom 168ed0544cfd529c8bdff1e5366c1bc60477b1cb Mon Sep 17 00:00:00 2001 =46rom: Buchan Milne <bgmilne@staff.telkomsa.net> Date: Fri, 3 Jun 2011 10:18:39 +0200 Subject: [PATCH] Fix contrib Makefiles to use libtool and be consistent (IT= S#6883) This makes existing Makefiles provided with contrib modules more consistent, using libtool for compiling and linking. A trivial test target has also been added, which tests that the module can be loaded. Existing Makefiles were consulted, but were mainly copied from the first working/tested Makefile. As such, any pre-existing copyright notices have been replaced. Makefiles are also provided for all the contrib modules that did not have Makefiles. =2D-- contrib/slapd-modules/acl/Makefile | 48 +++++++++++++++ contrib/slapd-modules/addpartial/Makefile | 50 ++++++++++++++--- contrib/slapd-modules/allop/Makefile | 47 +++++++++++++++ contrib/slapd-modules/allowed/Makefile | 58 ++++++++++--------- contrib/slapd-modules/autogroup/Makefile | 36 +++++++++--- contrib/slapd-modules/cloak/Makefile | 43 ++++++++++++-- contrib/slapd-modules/denyop/Makefile | 48 +++++++++++++++ contrib/slapd-modules/dsaschema/Makefile | 47 +++++++++++++++ contrib/slapd-modules/dupent/Makefile | 58 +++++++++---------- contrib/slapd-modules/kinit/Makefile | 47 +++++++++++++++ contrib/slapd-modules/lastbind/Makefile | 32 +++++++--- contrib/slapd-modules/lastmod/Makefile | 48 +++++++++++++++ contrib/slapd-modules/noopsrch/Makefile | 58 +++++++++---------- contrib/slapd-modules/nops/Makefile | 47 ++++++++++++---- contrib/slapd-modules/nssov/Makefile | 13 ++++- contrib/slapd-modules/passwd/Makefile | 86 +++++++++++++++---------= =2D--- contrib/slapd-modules/passwd/sha2/Makefile | 48 +++++++++++++--- contrib/slapd-modules/trace/Makefile | 48 +++++++++++++++ 18 files changed, 680 insertions(+), 182 deletions(-) create mode 100644 contrib/slapd-modules/acl/Makefile create mode 100644 contrib/slapd-modules/allop/Makefile create mode 100644 contrib/slapd-modules/denyop/Makefile create mode 100644 contrib/slapd-modules/dsaschema/Makefile create mode 100644 contrib/slapd-modules/kinit/Makefile create mode 100644 contrib/slapd-modules/lastmod/Makefile create mode 100644 contrib/slapd-modules/trace/Makefile diff --git a/contrib/slapd-modules/acl/Makefile b/contrib/slapd-modules/acl= /Makefile new file mode 100644 index 0000000..9f48c0d =2D-- /dev/null +++ b/contrib/slapd-modules/acl/Makefile @@ -0,0 +1,48 @@ +# $OpenLDAP$ +# Copyright 2011 Buchan Milne <bgmilne@staff.telkomsa.net> +# All rights reserved. +# +# Redistribution and use i
From: Buchan Milne <bgmilne@staff.telkomsa.net> To: openldap-its@openldap.org Subject: Re: (ITS#6883) Improved Makefiles for contrib modules Date: Thu, 16 Feb 2012 13:37:57 +0200 Cc: quanah@zimbra.com
--Boundary-00=_XqOPP0RBjyQeXED Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit On Tuesday, 29 March 2011 17:25:10 you wrote: > Full_Name: Buchan Milne > Version: 2.4.25 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (196.25.124.16) > > > While the code in contrib is not supported, some overlays provide make > files, some don't, and there were variations in a lot of the make files > (e.g. use of DESTDIR or not). > > In order to add make files for overlays that don't have them, improve the > consistency of the make files between overlays that had them, and to > provide some basic sanity testing in a 'test' target, I have created the > patch at: > http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/openldap/curren > t/SOURCES/openldap-2.4.25-contrib-makefiles-with-tests.patch?revision=64874 > 4&view=markup > > The patch is against 2.4.25, but should apply to master (except that there > two additional overlays are present in master). Where feasible I have > retained the majority of an existing make file, in other cases, where > modifications would exceed the original content, I have replaced existing > make files wholesale. > > The attached patch file is derived from OpenLDAP Software. All of the > modifications to OpenLDAP Software represented in the following patch(es) > were developed by Buchan Milne (bgmilne@staff.telkomsa.net). I have not > assigned rights and/or interest in this work to any party. Attached is an updated patch against current master (since ftp.openldap.org/incoming is out of disk space). Please let me know how we can get this patch merged. Regards, Buchan --Boundary-00=_XqOPP0RBjyQeXED Content-Type: text/x-patch; charset="UTF-8"; name="0001-Fix-contrib-Makefiles-to-use-libtool-and-be-consiste.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-contrib-Makefiles-to-use-libtool-and-be-consiste.patch" =46rom 168ed0544cfd529c8bdff1e5366c1bc60477b1cb Mon Sep 17 00:00:00 2001 =46rom: Buchan Milne <bgmilne@staff.telkomsa.net> Date: Fri, 3 Jun 2011 10:18:39 +0200 Subject: [PATCH] Fix contrib Makefiles to use libtool and be consistent (ITS#6883) This makes existing Makefiles provided with contrib modules more consistent, using libtool for compiling and linking. A trivial test target has also been added, which tests that the module can be loaded. Existing Makefiles were consulted, but were mainly copied from the first working/tested Makefile. As such, any pre-existing copyright notices have been replaced. Makefiles are also provided for all the contrib modules that did not have Makefiles. =2D-- contrib/slapd-modules/acl/Makefile | 48 +++++++++++++++ contrib/slapd-modules/addpartial/Makefile | 50 ++++++++++++++--- contrib/slapd-modules/allop/Makefile | 47 +++++++++++++++ contrib/slapd-modules/allowed/Makefile | 58 ++++++++++--------- contrib/slapd-modules/autogroup/Makefile | 36 +++++++++--- contrib/slapd-modules/cloak/Makefile | 43 ++++++++++++-- contrib/slapd-modules/denyop/Makefile | 48 +++++++++++++++ contrib/slapd-modules/dsaschema/Makefile | 47 +++++++++++++++ contrib/slapd-modules/dupent/Makefile | 58 +++++++++---------- contrib/slapd-modules/kinit/Makefile | 47 +++++++++++++++ contrib/slapd-modules/lastbind/Makefile | 32 +++++++--- contrib/slapd-modules/lastmod/Makefile | 48 +++++++++++++++ contrib/slapd-modules/noopsrch/Makefile | 58 +++++++++---------- contrib/slapd-modules/nops/Makefile | 47 ++++++++++++---- contrib/slapd-modules/nssov/Makefile | 13 ++++- contrib/slapd-modules/passwd/Makefile | 86 +++++++++++++++---------= =2D--- contrib/slapd-modules/passwd/sha2/Makefile | 48 +++++++++++++--- contrib/slapd-modules/trace/Makefile | 48 +++++++++++++++ 18 files changed, 680 insertions(+), 182 deletions(-) create mode 100644 contrib/slapd-modules/acl/Makefile create mode 100644 contrib/slapd-modules/allop/Makefile create mode 100644 contrib/slapd-modules/denyop/Makefile create mode 100644 contrib/slapd-modules/dsaschema/Makefile create mode 100644 contrib/slapd-modules/kinit/Makefile create mode 100644 contrib/slapd-modules/lastmod/Makefile create mode 100644 contrib/slapd-modules/trace/Makefile diff --git a/contrib/slapd-modules/acl/Makefile b/contrib/slapd-modules/acl= /Makefile new file mode 100644 index 0000000..9f48c0d =2D-- /dev/null +++ b/contrib/slapd-modules/acl/Makefile @@ -0,0 +1,48 @@ +# $OpenLDAP$ +# Copyright 2011 Buchan Milne <bgmilne@staff.telkomsa.net> +# All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted only as authorized by the OpenLDAP +# Public License. +# +# A copy of this license is available in the file LICENSE in
Date: Sun, 19 Feb 2012 02:28:45 +0100 From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no> To: Buchan Milne <bgmilne@staff.telkomsa.net> Cc: <openldap-its@openldap.org> Subject: Re: (ITS#6883) Improved Makefiles for contrib modules
On Thu, 16 Feb 2012 11:38:13 GMT, bgmilne@staff.telkomsa.net wrote: > Please let me know how we can get this patch merged. OpenLDAP needs more active developers... Anyway: It should remove GNU Make dependencies, not introduce them: Only use '$<' in inference rules, not explicit target rules (like ITS#7160). Drop '%.x: %.y' rules. I've scribbled a draft for that at repo <http://folk.uio.no/hbf/OpenLDAP/openldap.git>, branch its6883. (Not tested, and I need to install a non-Gnu Make to test with too.) I'll work at it later, but don't quite know when. Unless you beat me to it. Also I suppose '+=' should go away. Which I would mean move what is added to a new variable so the user can easily say things like make CPPFLAGS='-Dwhatever $(DEFS)'. Or maybe use LT_CPPFLAGS= ..whatever $(CPPFLAGS) ... like e.g. slapd/overlays/Makefile ends up doing. THat one has an awful number of Make variables and is fairly unreadable to me, probably to satisfy autoconf & co. But a few more vars seems useful. -- Hallvard
______________ © Copyright 2013, OpenLDAP Foundation, info@OpenLDAP.org
