Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (129.240.6.233) Submitted by: hallvard configure should mention syncrepl here: --enable-rewrite enable DN rewriting in back-ldap and rwm overlay test059-slave-config fails with --disable-rewrite. Testrun/test.out says parse_syncrepl_line: unable to parse "suffixmassage=cn=schema,cn=config,cn=slave"
What's special about DN rewriting so it has a configure option anyway? It doesn't disable building of libraries/librewrite. -- Hallvard
> What's special about DN rewriting so it has a configure option > anyway? It doesn't disable building of libraries/librewrite. It used to, as far as I remember. I remember something about performing simple suffixmassage when librewrite is not built. In any case I agree that given the widespread usage of rewrite capabilities (authz regexp, for example) not building librewrite is somehow pointless. p.
moved from Incoming to Build
h.b.furuseth@usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: HEAD > OS: > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (129.240.6.233) > Submitted by: hallvard > > > configure should mention syncrepl here: > --enable-rewrite enable DN rewriting in back-ldap and rwm overlay > > test059-slave-config fails with --disable-rewrite. Testrun/test.out says > parse_syncrepl_line: > unable to parse "suffixmassage=cn=schema,cn=config,cn=slave" > > Ando wrote: >> What's special about DN rewriting so it has a configure option >> anyway? It doesn't disable building of libraries/librewrite. > > It used to, as far as I remember. I remember something about performing > simple suffixmassage when librewrite is not built. In any case I agree > that given the widespread usage of rewrite capabilities (authz regexp, for > example) not building librewrite is somehow pointless. Agreed. I'm fine with dropping this configure switch and unifdef'ing it so that librewrite is always used. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/
Howard Chu writes: > Agreed. I'm fine with dropping this configure switch and unifdef'ing it so > that librewrite is always used. Built unless --disable-slapd, I think. It is not installed, and the other libraries do not use it. -- Hallvard
Note: The --enable-rewrite flag literally has no effect, since BUILD_REWRITE is not honored anywhere as it is.
Ah, actually... it does affect how back-meta etc are built... but not whether or not the library is built.
(In reply to Quanah Gibson-Mount from comment #6) > Note: The --enable-rewrite flag literally has no effect, since BUILD_REWRITE > is not honored anywhere as it is. Maybe not in the build system, but the ENABLE_REWRITE and SLAP_AUTH_REWRITE defines in the code are fully respected.
(In reply to Ryan Tandy from comment #8) > (In reply to Quanah Gibson-Mount from comment #6) > > Note: The --enable-rewrite flag literally has no effect, since BUILD_REWRITE > > is not honored anywhere as it is. > > Maybe not in the build system, but the ENABLE_REWRITE and SLAP_AUTH_REWRITE > defines in the code are fully respected. Right, I noted that in comment#7 ;) I was referring back to comment#5 ;)
https://git.openldap.org/openldap/openldap/-/merge_requests/40
Commits: • bc9a9286 by Quanah Gibson-Mount at 2020-04-22T14:49:10+00:00 ITS#6740 - Always enable rewrite