Viewing Build/6740
Full headers

Major security issue: yes  no

Notes:

Notification:

Date: Wed, 08 Dec 2010 10:21:22 +0000
From: h.b.furuseth@usit.uio.no
To: openldap-its@OpenLDAP.org
Subject: syncrepl/--disable-rewrite dependency

Full_Name: Hallvard B Furuseth
Version: HEAD
OS: 
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (129.240.6.233)
Submitted by: hallvard


configure should mention syncrepl here:
    --enable-rewrite  enable DN rewriting in back-ldap and rwm overlay

test059-slave-config fails with --disable-rewrite. Testrun/test.out says
    parse_syncrepl_line:
    unable to parse "suffixmassage=cn=schema,cn=config,cn=slave"

Followup 1

From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
Date: Wed, 8 Dec 2010 11:37:17 +0100
To: openldap-its@openldap.org
Subject: Re: (ITS#6740) syncrepl/--disable-rewrite dependency

What's special about DN rewriting so it has a configure option
anyway?  It doesn't disable building of libraries/librewrite.

-- 
Hallvard

Followup 2

Date: Wed, 8 Dec 2010 17:36:40 +0100 (CET)
Subject: Re: (ITS#6740) syncrepl/--disable-rewrite dependency
From: masarati@aero.polimi.it
To: h.b.furuseth@usit.uio.no
Cc: openldap-its@openldap.org

> What's special about DN rewriting so it has a configure option
> anyway?  It doesn't disable building of libraries/librewrite.

It used to, as far as I remember.  I remember something about performing
simple suffixmassage when librewrite is not built.  In any case I agree
that given the widespread usage of rewrite capabilities (authz regexp, for
example) not building librewrite is somehow pointless.

p.

Followup 3

Date: Wed, 16 Feb 2011 16:59:31 -0800
From: Howard Chu <hyc@symas.com>
To: h.b.furuseth@usit.uio.no
CC: openldap-its@openldap.org
Subject: Re: (ITS#6740) syncrepl/--disable-rewrite dependency

h.b.furuseth@usit.uio.no wrote:
> Full_Name: Hallvard B Furuseth
> Version: HEAD
> OS:
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (129.240.6.233)
> Submitted by: hallvard
>
>
> configure should mention syncrepl here:
>      --enable-rewrite  enable DN rewriting in back-ldap and rwm overlay
>
> test059-slave-config fails with --disable-rewrite. Testrun/test.out says
>      parse_syncrepl_line:
>      unable to parse "suffixmassage=cn=schema,cn=config,cn=slave"
>
>

Ando wrote:
>> What's special about DN rewriting so it has a configure option
>> anyway?  It doesn't disable building of libraries/librewrite.
>
> It used to, as far as I remember.  I remember something about performing
> simple suffixmassage when librewrite is not built.  In any case I agree
> that given the widespread usage of rewrite capabilities (authz regexp, for
> example) not building librewrite is somehow pointless.

Agreed. I'm fine with dropping this configure switch and unifdef'ing it so 
that librewrite is always used.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Followup 4

From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
Date: Thu, 17 Feb 2011 13:43:17 +0100
To: Howard Chu <hyc@symas.com>
Cc: openldap-its@openldap.org
Subject: Re: (ITS#6740) syncrepl/--disable-rewrite dependency

Howard Chu writes:
> Agreed. I'm fine with dropping this configure switch and unifdef'ing it so 
> that librewrite is always used.

Built unless --disable-slapd, I think.  It is not installed, and the
other libraries do not use it.

-- 
Hallvard