Issue 5887 - Fix GnuTLS support for TLS_CIPHER_SUITE
Summary: Fix GnuTLS support for TLS_CIPHER_SUITE
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: 2.4.13
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 16:04 UTC by Quanah Gibson-Mount
Modified: 2014-08-01 21:04 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Quanah Gibson-Mount 2009-01-14 16:04:12 UTC
Full_Name: Quanah Gibson-Mount
Version: 2.4.13
OS: NA
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (75.111.29.239)


See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510346

Summary from Simon Josefsson:

A proper fix requires co-ordination with the OpenLDAP people.  Either
they 1) remove all strange code for parsing ciphers for GnuTLS and only
use gnutls_priority_set_direct on the TLS_CIPHER_SUITE string, or 2)
they introduce a new configuration keyword TLS_PRIORITY that is is sent
to GnuTLS's priority functions.  Given that TLS_CIPHER_SUITE accepts
OpenSSL strings like 'HIGH:+SSLv2' I believe that matches GnuTLS
priority strings, so I would recommend 1).  And improve the
documentation to point at, e.g., gnutls_priority_init(3) or the GnuTLS
manual in the OpenLDAP documentation.

/Simon

Comment 1 Howard Chu 2009-01-14 19:26:37 UTC
quanah@OpenLDAP.org wrote:
> Full_Name: Quanah Gibson-Mount
> Version: 2.4.13
> OS: NA
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (75.111.29.239)
>
>
> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510346
>
> Summary from Simon Josefsson:
>
> A proper fix requires co-ordination with the OpenLDAP people.  Either
> they 1) remove all strange code for parsing ciphers for GnuTLS and only
> use gnutls_priority_set_direct on the TLS_CIPHER_SUITE string, or 2)
> they introduce a new configuration keyword TLS_PRIORITY that is is sent
> to GnuTLS's priority functions.  Given that TLS_CIPHER_SUITE accepts
> OpenSSL strings like 'HIGH:+SSLv2' I believe that matches GnuTLS
> priority strings, so I would recommend 1).  And improve the
> documentation to point at, e.g., gnutls_priority_init(3) or the GnuTLS
> manual in the OpenLDAP documentation.

Sounds like we should do (1). There was no such API in GnuTLS when our support 
was written, which is why we had to go to the trouble of parsing the cipher 
suites ourselves. I'm fine with ripping that all out, if someone will tell us 
what minimum version of GnuTLS provides the new API.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/

Comment 2 Quanah Gibson-Mount 2009-01-14 19:33:46 UTC
--On Wednesday, January 14, 2009 7:29 PM +0000 hyc@symas.com wrote:

> quanah@OpenLDAP.org wrote:
>> Full_Name: Quanah Gibson-Mount
>> Version: 2.4.13
>> OS: NA
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (75.111.29.239)
>>
>>
>> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510346
>>
>> Summary from Simon Josefsson:
>>
>> A proper fix requires co-ordination with the OpenLDAP people.  Either
>> they 1) remove all strange code for parsing ciphers for GnuTLS and only
>> use gnutls_priority_set_direct on the TLS_CIPHER_SUITE string, or 2)
>> they introduce a new configuration keyword TLS_PRIORITY that is is sent
>> to GnuTLS's priority functions.  Given that TLS_CIPHER_SUITE accepts
>> OpenSSL strings like 'HIGH:+SSLv2' I believe that matches GnuTLS
>> priority strings, so I would recommend 1).  And improve the
>> documentation to point at, e.g., gnutls_priority_init(3) or the GnuTLS
>> manual in the OpenLDAP documentation.
>
> Sounds like we should do (1). There was no such API in GnuTLS when our
> support  was written, which is why we had to go to the trouble of parsing
> the cipher  suites ourselves. I'm fine with ripping that all out, if
> someone will tell us  what minimum version of GnuTLS provides the new API.

Simon?

--Quanah


--

Quanah Gibson-Mount
Principal Software Engineer
Zimbra, Inc
--------------------
Zimbra ::  the leader in open source messaging and collaboration

Comment 3 Simon Josefsson 2009-01-14 19:44:25 UTC
Quanah Gibson-Mount <quanah@zimbra.com> writes:

> --On Wednesday, January 14, 2009 7:29 PM +0000 hyc@symas.com wrote:
>
>> quanah@OpenLDAP.org wrote:
>>> Full_Name: Quanah Gibson-Mount
>>> Version: 2.4.13
>>> OS: NA
>>> URL: ftp://ftp.openldap.org/incoming/
>>> Submission from: (NULL) (75.111.29.239)
>>>
>>>
>>> See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510346
>>>
>>> Summary from Simon Josefsson:
>>>
>>> A proper fix requires co-ordination with the OpenLDAP people.  Either
>>> they 1) remove all strange code for parsing ciphers for GnuTLS and only
>>> use gnutls_priority_set_direct on the TLS_CIPHER_SUITE string, or 2)
>>> they introduce a new configuration keyword TLS_PRIORITY that is is sent
>>> to GnuTLS's priority functions.  Given that TLS_CIPHER_SUITE accepts
>>> OpenSSL strings like 'HIGH:+SSLv2' I believe that matches GnuTLS
>>> priority strings, so I would recommend 1).  And improve the
>>> documentation to point at, e.g., gnutls_priority_init(3) or the GnuTLS
>>> manual in the OpenLDAP documentation.
>>
>> Sounds like we should do (1). There was no such API in GnuTLS when our
>> support  was written, which is why we had to go to the trouble of parsing
>> the cipher  suites ourselves. I'm fine with ripping that all out, if
>> someone will tell us  what minimum version of GnuTLS provides the new API.
>
> Simon?

The APIs were released as stable for v2.2.0 on 2007-12-14.  Perhaps you
could have an autoconf test for gnutls_priority_set_direct and only
enable the new code conditionally.

/Simon

Comment 4 Howard Chu 2009-01-26 02:21:33 UTC
changed notes
changed state Open to Test
moved from Incoming to Software Enhancements
Comment 5 Quanah Gibson-Mount 2009-01-26 23:28:51 UTC
changed notes
changed state Test to Release
Comment 6 Quanah Gibson-Mount 2009-02-15 02:08:56 UTC
changed notes
changed state Release to Closed
Comment 7 OpenLDAP project 2014-08-01 21:04:53 UTC
added in HEAD
added in RE24