Issue 554 - Add checking for per-entry sizelimit
Summary: Add checking for per-entry sizelimit
Status: VERIFIED FIXED
Alias: None
Product: OpenLDAP
Classification: Unclassified
Component: slapd (show other issues)
Version: unspecified
Hardware: All All
: --- normal
Target Milestone: ---
Assignee: OpenLDAP project
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-06-02 05:56 UTC by st-wong@cuhk.edu.hk
Modified: 2014-08-01 21:05 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description st-wong@cuhk.edu.hk 2000-06-02 05:56:05 UTC
Full_Name: ST Wong
Version: 1.2.10, 2.0-alpha3
OS: Solaris 2.6
URL: ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.search-*
Submission from: (NULL) (137.189.4.7)


Our LDAP servers are used by both human users and application programs.  We want
to enforce different 
sizelimit on various clients.  Codes are added to
servers/slapd/back-ldbm/search.c
to set per entry sizelimit.  The global sizelimit defined in slapd.conf applies
to
bounded sessions for LDAP entries without attribute "sizelimit" defined, or
those
unbound connections.

Our LDAP servers run Solaris 2.6.  Modifications are made to OpenLDAP 1.2.10 and
2.0Alpha3.

Comment 1 Kurt Zeilenga 2000-06-02 11:40:20 UTC
changed notes
changed state Open to Suspended
moved from Incoming to Development
Comment 2 Kurt Zeilenga 2000-06-02 18:39:54 UTC
At 05:56 AM 6/2/00 GMT, st-wong@cuhk.edu.hk wrote:
>Full_Name: ST Wong
>Version: 1.2.10, 2.0-alpha3
>OS: Solaris 2.6
>URL: ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.search-*

As our incoming directory is not searchable:

ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.
search-1.2.10
ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.
search-2.0alpha3


Will review as time permits.  If you get a chance, would appreciate
it if you update the patches so that they can be cleanly applied
to latest openldap-devel software and generated per our contributing
guidelines <http://www.openldap.org/devel/contributing.html>.  (diff -u,
etc).
Comment 3 Kurt Zeilenga 2000-06-03 18:17:20 UTC
Forwarded to ITS...

At 01:23 AM 6/4/00 +0800, you wrote:
>Hi, 
>
>The change is applied to the HEAD branch.  Diff -u output is put int
>ftp://ftp.openldap.org/incoming/st-wong-000604.servers-slapd-back-ldbm-search.diff
>
>Thanks a lot.
>/ST
>
>> The best is to use CVS's builtin diff, it supports -u.
>> 
>> >Will install another diff program if necessary.
>> >
>> >Would you pls advise ?
>> >Sorry for the trouble caused.
>> >
>> >Thanks a lot.
>> >/ST
>> >
>> >> At 05:56 AM 6/2/00 GMT, st-wong@cuhk.edu.hk wrote:
>> >> >Full_Name: ST Wong
>> >> >Version: 1.2.10, 2.0-alpha3
>> >> >OS: Solaris 2.6
>> >> >URL: ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.search-*
>> >> 
>> >> As our incoming directory is not searchable:
>> >> 
>> >> ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.
>> >> search-1.2.10
>> >> ftp://ftp.openldap.org/incoming/st-wong-000602.server.slapd.back-ldbm.
>> >> search-2.0alpha3
>> >> 
>> >> 
>> >> Will review as time permits.  If you get a chance, would appreciate
>> >> it if you update the patches so that they can be cleanly applied
>> >> to latest openldap-devel software and generated per our contributing
>> >> guidelines <http://www.openldap.org/devel/contributing.html>.  (diff -u,
>> >> etc).
>
>
Comment 4 Kurt Zeilenga 2000-06-07 11:19:16 UTC
changed notes
changed state Suspended to Closed
Comment 5 Kurt Zeilenga 2000-06-07 18:13:27 UTC
Though such a feature may be useful, your implementation is not
suitable for inclusion into OpenLDAP for the following reasons.

1) no dead lock prevention
2) assumes bind DN refers to an entry within same backend
   operation is being processed by
3) no access control applied

It is likely better to implement per-user (soft and hard?) limits
using variables associated with the session and populated at
bind time.  If you would like to work on such, please discuss and
coordinate on our developer list.

If you do not concur with this review, please post
a rebuttal to our developer list.

We do appreciate your efforts and hope you will see them
through.
	Kurt

Comment 6 OpenLDAP project 2014-08-01 21:05:27 UTC
Needs work.  Author to resubmit as needed.