CVS log for libraries/liblber/io.c

Request diff between arbitrary revisions

Re-fix ITS#6764 (check for ber == NULL _before_ using ber)

Re-fix ITS#6764 (check for ber == NULL _before_ using ber)

Happy New Year!

Happy New Year

ITS#6764

ITS#6603

ber_flatten must return -1 on unmatched "{" "}" (ITS#6764)

remove #ifdef EAGAIN, EWOULDBLOCK (ITS#6603)

happy belated new year

happy belated New Year

ITS#6215

For ITS#6215: Do not expose obsolete Seqorset. Note ber_write(,,,nonzero) is gone.

More ITS#6215 -
Speedup & less memory allocation:
  Simplify the work to encode tag, length, integer/enum, sequence/set.
  Drop struct seqorset and allocations of it.  Replace BerElement.ber_sos.
  Drop ber_write(,,,nonzero) support. Callers, if any, need to be rewritten.
  Make ber_log_sos_dump() and ber_sos_dump() stubs, they could no longer work.
Fix ber_write() buffer overrun after ber_start_seqorset().
Check overflow and max sizes, e.g. for functions returning int size.
Some cleanup, and handwaves in the direction of supporting CHAR_BIT>8.
Add/fix comments and a few descriptive types/macros.

ITS#6215: Fix buffer overrun and write through NULL pointer

Skip redundant PACKETS logging

Skip redundant PACKETS logging

Update copyright for next release

Update copyright notices

ITS#5580

ITS#5580

ITS#5580: Revert prev commit, failed on byte-at-a-time input. Different
approach used here.

ITS#5580 fix length decoding, verified with PROTOS

Happy new year! (belated)

Happy new year! (belated)

Happy New Year (belated)

Cleanup debug calls

Cleanup debug calls

Sync with HEAD for OL 2.4.5

Make LDAP_MEMORY_DEBUG a bitmask. #define LDAP_MEMORY_DEBUG_ASSERT. ITS#4990.

Add ber_skip_data() to help positioning in structured BER data

Quick merge: everything from HEAD

happy new year

happy new year

ITS#4606 fix from HEAD - use sock_err* macros instead of errno

Sync with HEAD

ITS#4606 errno is not per-thread on WIN32, always use WSAGet/SetLastError
(with notable exceptions: ignore tests for EINTR which winsock never sets)

Sync with HEAD

Cleanup since last patch (remove unused label)

Sync with HEAD

better fix for ITS#4483

don't leak a BerElement

Happy new year!

Happy new year!

Sync with HEAD

Cleanup lbo_valid / meminuse / memfuncs

Sync with HEAD
Changes needs updating for release...

silence warnings

Sync with HEAD

Happy new year!

Happy New Year!

unifdef -UNEW_LOGGING

ITS#3086: remove uninitialized value lint

ITS#3086: removed uninitialized value lint

NUL-terminate alloc'd berbuf (ITS#3086)

Happy new year

Happy new year

Sync with HEAD

acknowledgements and notices

Notice updates

Changes from HEAD for beta

code cleanup

Cast unsigned char *p to char *.

    Fixed liblber ber_get_next trickle bug (ITS#2490)
    Fixed ldapsearch -p without -h bug (ITS#2532)
    Fixed slapd option ordering bug (ITS#2217)
    Removed lint
    Documentation
        Misc man page updates

Fix reading multibyte lengths

Reverse unintended commit

cleanup

Add trickle code to test ber_get_next.
Use etest {...} | dtest {...} to test.

Fix dtest ber_get_next() usage

ber_get_next - set errno to 0 before calling ber_int_sb_read(), otherwise
an EOF will return with the previously set errno value.

- change in message to modlist conversion

More ITS#2490 - fix retries for multi-byte lengths

ITS#2490 - more retry checks

ITS#2490 - allow retry for incomplete reads of BER tag & len

Fixed SASL interactive free bug (ITS#2423)
Fixed liblber multi-value decode bug (ITS#2458)
Fixed liblber over read bug (ITS#2465)

Clean up prev commit

Fix multi-byte tag parsing

ITS#2465 fix?  ber_get_next must read at least sizeof(tag)+sizeof(len)
which should be at most 8 bytes. However if we read more than the minimum
message length, we have a problem because we steal bytes from any following
message, and there is no buffer mechanism to push back excess data.
The shortest legitimate message is Unbind at 7 bytes, but there shouldn't
be anything following it. Abandon at 8 bytes is next, so always requesting
at least 8 bytes should be safe. Always requesting 9 was a problem.

Please double-check these assumptions...

More malloc context tweaks

Extended API for ber_mem functions, add context argument.
Must always use ber_mem funcs, even if CSRIMALLOC is present.

ITS#2434 ber accessors

mark a few translatable strings

Use ifdef not comment to comment out code

Numerous minor fixes from HEAD, see CHANGES

Fix ITS#2344, prev commit changed too much.

Changes:
    Fixed liblutil getpeereid replacement function
    Fixed liblber 64bit len/tag bug
    Updated liblber ber_get_stringbv handling
    Build Environment
        Updated NT build environment w/ slurpd support
        Updated test suite

Use fixed sizes for ber_get_next to avoid 64-bit hangs.

Changes
    Updated libldap TLS certificate checking
    Updated client tool argument handling
    Updated test suite
    Updated liblutil detach handling
    Added libldap ldap_whoami routines
    Added liblber ber_flatten2 routine
    Added liblutil passwd sanity checks
    Fixed liblber PROTOS bugs
    Fixed ber_flush debug level
    Fixed libldap NULL cred bug
    Build Environment
        Check back-bdb requirement for BDB 4.1

Misc -llber fixes, lint removal, etc.

ber_flush shouldn't be logging with _ANY, changed to _TRACE

ITS#2275: PROTOS ber_get_next() fix
Needs review!!!!

Happy new year

Updated ITS#2246 fix

Fix ITS#2246, fix in rev 1.73 was in the wrong place

Added ber_flatten2 - uses passed in struct berval, allocates copy or
directly re-uses existing ber buf.

Increate EXBUFSIZ

Bump EXBUFSIZ up a bit

mostly logging

Coverted LDAP_LOG macro to use subsystem ID int values instead of string values

Fix SEGV on single-byte connection input

Suck in changes from HEAD
    Fix slapd schema error alignment bug
    Update slapd SASL proxy policy code
    Update slapd require "strong" check
    Update back-bdb entry locking
    Add slapd disallow bind_simple_unprotected directive
    Add back-monitor added monitorContext support
    Add slapd IPv4/v6 only options
    Ass slapd SASL setpass support
    Remove lint
    Build Environment
        Add monitor backend test
        Update <ac/socket.h> SHUT_RDWR
        Fix SASL-less build issues
        Fix back-perl build issues

ITS#1891 in ber_flush, no-op if towrite == 0

Suck in HEAD changes since 2.1alpha

ITS#1732 signed/unsigned fixes

For ITS#1601, add ber_init2() using given buffer in-place instead of
allocating a copy.

Fix previous commit, need to detect very short packets.

ber_get_next: return error if decoded ber_len is smaller than actual count

Misc cleanup, lint removal, and minor optimizations

Rewrote ber_get_next, fixed byte-order dependency on ber_tag and optimized

Prep for in-place parsing. Cache a ber_tag byte.
No visible impact from these changes.

meaningful message in case max_incomingis hit

Update copyrights for year 2002

Update copyright statements

Added ber_free_buf()

Fix buffer overflow bug (ITS#1345)

Fix an off by one bug which could cause a realloced buffer to be
too small.  Changed extra size algorithm to use a much simplier
approach and detailed non-optimized version.

Make some additional UTF8 public
Remove lint

Import changes from HEAD including
updated MacOS X support
modlist2mods error reporting

Misc cleanup

lber hardening

Import -llber hardening

Add a bit of hardening

reimplementation of sb_max_incoming

ITS#133

new logging

Import latest BER library changes

Remove max buffer constraint!
and general cleanup

Import latest from devel

s/SAFEMEMCPY/AC_MEMCPY/
Use AC_FMEMCPY where appropriate (-llber)

Remove lint

Remove unnecessary forward declaration

Update to latest devel codes

Minor cleanup

Merge latest devel codes into releng 2 branch.
Remove back-perl, back-sql, back-tcl from branch as they have yet
to be updated.
Additional changes are needed prior to release of alpha4.

ITS#537: lber io rewrite from Gambor Gombas.
Copyright 2000 Gábor Gombás. All rights reserved.
This is free software. You may redistribute and use it under the same
terms as OpenLDAP itself.

ITS#533: simplify ber_next_read

SOCKBUF_VALID should be called with sb not ber

Y2k copyright update

Fixed back-ldbm/modify mutlivalued indexing bug
Fixed -llber seqorset buffer overrun bug (ITS#479)

ITS#479 fix: ber_put_seqorset() writes a few bytes beyond an allocated buffer
Commit based upon patch and comments provided by Alan Clark <aclark@novell.com>.
> Kudos to Dave Steck for the find and fix

Remove lint
Add copyrights

Remove LBER_{TAG,INT,LEN}_{NTOH,HTON} macros.  Rewrite code to
manual push bytes about.  Allows ber_*_t to be any 32-bit or
larger type.  Reworked AC_{HTON,NTOH}{L,S} macros to care only
about 32-bit (netlong) and 16-bit (netshort) reordering as
needed for BSD socket interface.

Hack to free seqorset when ber_free(ber, 1) is called.

Minor adjustments based upon initial read of draft-ietf-ldapext-ldap-c-api-04.txt.

ITS#325: use simple pointer arithmetic to avoid problems on systems
with odd pointer representations (such as Cray T90).

Merge in all devel changes since 2.0-alpha2.
Move OPENLDAP_REL_ENG_2_MP forward.

Add OpenLDAP RCSid to *.[ch] in clients, libraries, and servers.
Replace old Id as needed (back-tcl).
Leave updating of contribWare to contributors (for now).

Plug ber leakage:
result was leaking ber's in some error cases.  ber_flush now called
with no freeing so that caller of send_ldap_ber() can free its own ber.
c->c_currentber was also being leaked if connection was destory
current when a PDU input was outstanding.
Fixed ber_flush to free ber upon write only to file.

detect write() and use HAVE_WRITE instead of
  !defined( DOS ) && !defined( MACOS )
Add detection for read & recv/send for later use.

*** empty log message ***

ber_int_t, ber_tag_t, ber_socket_t, ber_len_t
added lber_types.h.nt, lber_types.h.in
removal of NULLxxx internal macros (in favor of NULL).
ch_free added to slapd,slurpd/ch_malloc.c
#define free ch_free (should be removed after s/free/ch_free/g) in proto-slap.h
ch_malloc and friends use ber_memalloc and friends

s/NULLxxx/NULL
s/xxx/ber_xxx_t/

Introduction of BER types (ber_int_t, ber_tag_t, ber_len_t, ber_socket_t)
and lber_types.h (NT version only, need to write configure support for other
platforms).   Changes to sources are likely incomplete and buggy.
This is a work in progress.

Hide assert(p == NULL) behind LDAP_MEMORY_DEBUG.
Add detection for duplicate free in LDAP_MEMORY_DEBUG code.

Enable browsing info in MSVC debugging configurations.
Toy with dllimport/dllexport stuff (think I'll leave the real dll work to
somebody else).
Added ldap_strdup() wrapper of ber_strdup().

s/<stdlib.h>/<ac/stdlib.h>/

First cut at ber_set_option(NULL,LBER_OPT_MEMORY_FN, myrealloc) where
myrealloc is pointer to a realloc() wrapper.
Must be first library call or else.

Add LBER_ and LDAP_ memory allocators/deallocators for internal
library use:
  LBER_ macros expand to system routines.
  LDAP_ macros expand to new ber_ allocators.

Add ber_ and ldap_ memory allocators/deallocator:
  ber_ routines are wrappers of LBER_ macros.
  ldap_ routines are wrappers of ber_ routines.

Removed safe_realloc() macro from various files.  This issue
(if an issue) should be resolved across whole package.

ldapmodify.c now uses ber_ allocators to resolve ber_bvfree()
vs. WIN32 multiple heaps issue.

These changes should facilate implementation of
  ber_set_option( NULL, LBER_OPT_MEMORY_FN, ...)
and
  ldap_set_option( NULL, LDAP_OPT_MEMORY_FN, ...).

ber_clear() no longer needed.  Removed.

Changed lc_conn to be a pointer to a BerElement to aid in state management.
Added validation to exposed opaque data structures (BerElement, Sockbuf,
and LDAP).  Added macros BER_VALID, SOCKBUF_VALID, LDAP_VALID.
Added ber_pvt_ber_bytes() and ber_pvt_ber_remaining() macros to hide
some ber internals.  These really should be handled by ber_get_option().

etest/dtest now work correctly.  Commented out bogus assert
in io.c.

found my lber bug... ber_buf should have been freed in ber_peek_tag.  Ugh!

Fix initialization bug in ber_init_w_nullc()
Added assert(), additional comments, and a few minor adjustments.

Fixed bug in dtest code.

Add UL to LBER tags.

Vienna Bulk Commit
This commit includes many changes.  All changes compile under NT but
have not been tested under UNIX.

A Summary of changes (likely incomplete):

NT changes:
	Removed lint.
	Clean up configuration support for "Debug", "Release", "SDebug",
		and "SRelease" configurations.
	Share output directories for clients, libraries,
		and slapd.  (maybe they should be combined further
		and moved to build/{,S}{Debug,Release}).
	Enable threading when _MT is defined.
	Enable debuging when _DEBUG is defined.
	Disable setting of NDEBUG under Release/SRelease.  Asserts
		are disabled in <ac/assert.h> when LDAP_DEBUG is not
		defined.
	Added 'build/main.dsp' Master project.
	Removed non-slapd projects from slapd.dsp (see main.dsp).
	Removed replaced many uses of _WIN32 macro with feature based
		macros.

ldap_cdefs.h changes
	#define LDAP_CONST const
		(see below)
	#define LDAP_F(type) LDAP_F_PRE type LDAP_F_POST
		To allow specifiers to be added before and after
		the type declaration.  (For DLL handling)

LBER/LDAP changes
	Namespace changes:
		s/lber_/ber_/ for here and there.
		s/NAME_ERROR/LDAP_NAME_ERROR/g
	Deleted NULLMSG and other NULL* macros for namespace reasons.
	"const" libraries.  Installed headers (ie: lber.h, ldap.h)
		use LDAP_CONST macro.  Normally set to 'const' when
		__STDC__.  Can be set externally to enable/disable
		'constification' of external interface.  Internal
		interface always uses 'const'.  Did not fix warnings
		in -lldif (in lieu of new LDIF parser).

	Added _ext API implementations (excepting search and bind).
		Need to implement ldap_int_get_controls() for reponses
		with controls.

	Added numberous assert() checks.

LDAP_R
	_MT defines HAVE_NT_THREADS
	Added numberous assert() checks.
	Changed ldap_pthread_t back to unsigned long.  Used cast
	to HANDLE in _join().

LDBM
	Replaced _WIN32 with HAVE_SYSLOG

ud
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).

slapd
	Made connection sockbuf field a pointer to a sockbuf.  This
		removed slap.h dependency on lber-int.h.  lber-int.h now only
		included by those files needing to mess with the sockbuf.
	Used ber_* functions/macros to access sockbuf internals whenever
		possible.
	Added version string if MKVERSION is not defined.  (MKVERSION
		needs to be set under UNIX).
	Removed FD_SET unsigned lint

slapd/tools
	Used EXEEXT to added ".exe" to routines.  Need to define EXEEXT
		under UNIX.

ldappasswd
	Added ldappasswd.dsp.  Ported to NT.  Used getpid() to seed rand().

nt_debug
	Minor cleanup.  Added "portable.h" include and used <ac/*.h> where
	appropriate.  Added const to char* format argument.

Lint removal:  signed i < unsigned j

Provide global assert solution.  <ac/assert.h> (new) is now included
by portable.h with NDEBUG undefined.  This makes assert() is always
available and automatically disables itself when LDAP_DEBUG is undefined.
I've included a basic assert() for pre-STDC compilers.  It relies on
abort() which may not actually be available.  (well replace abort()
with whatever is appropriate if and when we're faced with a pre-STDC
compiler that doesn't have assert()).

Added support in liblber and libldap for partial reads, i.e. situations in
which only part of a LDAPMessage is available on a socket.

The server-code seemed to handle this correctly already, so I didn't touch
it.

My apologies for the hack in ber_get_next :-).

Back out previous change; it was an accidental commit

Declare lber_pvt_sb_* functions from io.c in lber-int.h

The new&improved Sockbuf. This adds the infrastructure on which
support for TLS and SASL will be build.

Please inform me of any problems.

Updates for MSVC 5.0.  Fix libraries names to be ol{ber,dap,..}32.lib.
Fix library/include paths for building "Release".
Create getpass() from ud's mygetpass().

Zap ber buf pointer after free.

zap ber buf pointer on free.

Update copyright of build environment, includes, and liblber/libldap.

Minor update to copyright (forgot 'portions')

Add simple copyright notice

Added lber_get/set_option.  Removed lber_debug/ldap_debug.
Updated other codes as needed.

Add draft-ietf-ldapext-ldap-c-api-01 routines ber_init()
and ber_flatten() to the -llber.

Import changes from -devel to remove lint.

Remove lint in UserDirectory found on NT

Update for Alpha3 from -devel as of OPENLDAP_DEVEL_981116.
Includes everything but ldapext & ldap.conf changes.

Remove extern declarations of library functions from source.c.
  This could cause problems on odd systems.  The generic
  headers should be extended as needed to include necessary
  system headers or, if necessary, make explicit declarations.
Extended ac/string.h header to look for string.h/strings.h if
  STDC_HEADERS is not defined.  Also provide basic declarations for
  str*() functions.  This could cause problems on odd systems.
Extended ac/unistd.h header to define basic declaration for misc
  functions that might be missing from headers.   This includes
  externs for getenv(), getopt(), mktemp(), tempname().
Protect fax500.h from multiple inclusion.  Moved includes of
  system/generic headers back to source files.
Made mail500 helper functions static.
Fixed includes of ctype.h, signal.h, etc. to use generics.
lutil/tempname.c: was including stdlib.h twice, one should stdio.h.
Wrapped <sys/resource.h> with HAVE_SYS_RESOURCE_H.
lber/io.c/ber_get_next(): Changed noctets back to signed.
  Used with BerRead which expects signed int as second arg and
  returns signed int.

Protoized, moved extern definitions to .h files, fixed related bugs.
Most function and variable definitions are now preceded by its extern
definition, for error checking.  Retyped a number of functions, usually
to return void.  Fixed a number of printf format errors.

API changes (in ldap/include):
  Added avl_dup_ok, avl_prefixapply, removed ber_fatten (probably typo
  for ber_flatten), retyped ldap_sort_strcasecmp, grew lutil.h.

A number of `extern' declarations are left (some added by protoize), to
be cleaned away later.  Mostly strdup(), strcasecmp(), mktemp(), optind,
optarg, errno.

Update with latest from -devel.

Some gcc -W cleanup

rename ber_init() to ber_init_w_nullc in preparation of LDAPv3 ber_init()

update ldap/lber headers towards ldapext-ldap-c-api-01

merged with autoconf branch

remove some lint...

clean up includes

Fix fake error generation.

Modified NT changes to work under UNIX.

HTONL -> AC_HTONL

VC++ Port: round 1

Clean up sh commands in Makefiles (incorrect use of ';').
Fix make install problems.

Everything compiles....  but tests fail...

removed lint

changes from Terry Lambert

apply FreeBSD changes to main branch

Import of FreeBSD LDAP 3.3 Port

Initial revision

Import of Umich LDAP 3.3